Help In Looping

[f1amingheart]

Can anyone help me figure out passing by function for a loop?

int element(string Name, double Number, int Group, int Period, string Charge, string Formula, double Mass,double& Neutrons)
{int x,y;
 cout<<"Group no:";
 cin>>x;
cout<<"Period no:";
cin>>y;
if ((x == 1) && (y == 1) )
{
Name ="hydrogen";
Number = 1;
Group = 1;
Period = 1;
Formula = "H";
Charge = "1+";
Mass = 1.01;
Table (Name, Number, Group, Period, Formula, Charge, Mass, Neutrons );
else if ((x ==s ) ||( y==s )||(x <=0 ) ||( y<=0 )||(x > 18 ) ||( y> 4 ))
 {
 cout<< "Unrecognized command.\n";
 element(Name,Number,Group,Period,Charge,Formula,Mass,Neutrons);
 }
else if(cont==N)
{menu();}


	return cont;}

int Table(string Name, double Number, int Group, int Period, string Formula, string Charge, double Mass,double& Neutrons)
{do{
Neutrons = (Mass - Number);
system ( "cls" );
cout<< "Element Name:  " <<Name<<"\n";
cout<<"Continue?(Y/N) :"<<endl;
		cin>>cont ;	

{element(Name,Number,Group,Period,Charge,Formula,Mass,Neutrons);}

}while(cont!=N||cont!=n);
return cont;
}

Here's what I get when I run the code:
when i enter y/n,the loop still continue.
when i enter s for x,the whole program loop.

Thanks in advanced.

[vlad from moscow]

Change statement

while(cont!=N || cont!=n);

to

while(cont!=N && cont!=n);

[f1amingheart]

Tried that,but still looping.What I am trying to do is set a condition for the part 2 of the code but seems like it doesn't work that way?

And one more thing,else if ((x ==s ) ||( y==s )when I enter a char for x,the whole program goes into an infinity loop.Any help?

[Eyad]

Table (Name, Number, Group, Period, Formula, Charge, Mass, Neutrons )

you should but them in the same order as

element(string Name, double Number, int Group, int Period, string Charge, string Formula, double Mass,double& Neutrons)

[Eyad]

and what do you mean with the s?

else if ((x ==s ) ||( y==s )||(x <=0 ) ||( y<=0 )||(x > 18 ) ||( y> 4 ))

you should but it within quotes 's'

[f1amingheart]

I am just calling the function.Will it have any implication if i retain the same format?

[Eyad]

It matches their types and in most cases their order.

[f1amingheart]

oh,i meant char.When users are prompted to enter the x and y,if they enter a char,I want the system to stop.

[Eyad]

while(cont!='N'||cont!='n');

[Eyad]

or
while(cont='Y'||cont='y');

[f1amingheart]

while(cont='Y'||cont='y');,returns an error,must be modifiable.One more thing,can I set a condition where if when user input other than integer,the program will stop?

[Eyad]

yes you can, and it is called Exception handling but you need to write one more function to do it.

[f1amingheart]

Okay,but the loop thing still ain't working.Is it because the loop involves 2 functions?

[Eyad]

oops my bad, while(cont=='Y'||cont=='y');

[f1amingheart]

Nope,still the same,it still loops.

[Eyad]

why you are returning cont? just get rid of it

[f1amingheart]

i was testing something previously.I changed it to return 0

[whitenite1]

You may want to declare what cont IS, in your functions.

[f1amingheart]

I declared cont as char,at the top of the code.These 2 functions are just part of the whole code which I am having trouble with.The code is pretty lengthy.