How can I fill in an array with random numbers?

[Gregory Sakas]

I want to fill an array with random numbers 1-32, but each one should be in there only once. This code:

for(counter=0;counter<32;counter++)
{
	do
	{
		randnum = rand() % 32 + 1;
		i = SequentialSearch(randnumvect, randnum);
		if(i!=-1)
			returned==randnum;
		else
			returned==-999;
	}
	while(randnum==returned);
	randnumvect.resize(randnumvect.size()+1);
	randnumvect[counter] = randnum;
}

With this sequential search:

int SequentialSearch(const vector<int> &randnumvect, int search)
{
	int i;
	
	for(i=0;i<randnumvect.size();i++)
	{
		if(search==randnumvect[i])
			return i;
	}
	i = -1;
	return i;
}

Puts the numbers in randomly, but there are some repeats. What am I doing wrong?

[cire]

#include <algorithm>

for ( counter=0; counter <32; ++counter )
    randnumvect.push_back(counter+1) ;

std::random_shuffle( randnumvect.begin(), randnumvect.end() ) ;

[Gregory Sakas]

Thanks! It works! Is there any way to modify the code I posted?

[4z0M4iN6]

Gregory Sakas wrote:

Thanks! It works! Is there any way to modify the code I posted?

You could edit your post

[vlad from moscow]

Do not be hurry. Your code is invalid. You use the comparision operator instead of the assignment operator in the following code snip

if(i!=-1)
returned==randnum;
else
returned==-999;