While Loop
May 4, 2012 at 6:04am UTC
Hi! I'm doing a class project where you read in from a master file and a transactions file and output/delete based on certain criteria. I validate and sort the master file into an array called customer. The issue I'm having is that it successfully deletes the first record that is supposed to be deleted, but after it deletes the second (and last) record that is supposed to be deleted it calls in the next action code (A, D, E, or P), but instead of going to the appropriate if loop, it goes to the Delete loop for all of the remaining records despite them having differect codes. They do all make it to the newMaster file, but there are some that are also supposed to be printed to the console, but they don't get there. Sorry this is so long, but I really appreicate any help you can offer.
Thanks!
1while (!inMaster.eof())
{
if (validcustID(temp.custID))
{
if (temp.Status == "S" )
{temp.Limit = 0;
customer[i] = temp; //output to array
i++;
inMaster >> temp;
count++;}
else
{
customer[i] = temp; //output to array
inMaster >> temp;
i++;
count++;
}
}
else
{
outError << "Invalid customer ID with the following record" << "\t" ;
outError << temp; //output to error_log
inMaster >> temp;
}
}
if (validcustID(temp.custID))
{
if (temp.Status == "S" )
{temp.Limit = 0;
customer[i] = temp; //output to array
i++;
count++;}
else
{
customer[i] = temp; //output to array
i++;
count++;
}
}
else
{
outError << "Invalid customer ID with the following record" << "\t" ;
outError << temp; //output to error_log
}
sort (customer, count); //sorted by count instead of i because i is created before something is written
//newMaster.txt is the Master file altered by the Transactions file
string TransCode;
string TransString;
float TransFloat;
int Field;
record TransTemp;
i=0;
inTransaction >> TransCode;
while ((!inTransaction.eof()) && (i<count))
{
if (TransCode == "A" )
{
cout << "Add" << endl;
inTransaction >> TransTemp;
if (TransTemp.custID > customer[i].custID)
{
//add array to newMaster then read in new array
outNewMaster << customer[i];
//do i need to bring in the next array here, or does it automatically do that?
}
else if (TransTemp.custID == customer[i].custID)
{
//add trans record to newMaster then read in new TransTemp
outNewMaster << TransTemp;
inTransaction >> TransCode;
i++;
}
else if (TransTemp.custID < customer[i].custID)
{
//add trans record to newMaster then read in new TransTemp and new array
outNewMaster << TransTemp;
inTransaction >> TransCode;
i++;
}
cout << "End Add" << endl;
}
if (TransCode == "D" )
{
cout << "Delete" << endl;
inTransaction >> TransTemp.custID;
if (TransTemp.custID == customer[i].custID)
{
//add nothing to newMaster read in new TransTemp and new array record
i++;
inTransaction >> TransTemp;
}
else if (TransTemp.custID > customer[i].custID)
{
//add array to newMaster then read in new array
outNewMaster << customer[i];
i++;
}
else if (TransTemp.custID < customer[i].custID)
{
//read in new TransTemp
inTransaction >> TransCode;
}
cout << "End Delete" << endl;
}
if (TransCode == "E" )
{
cout << "Edit" << endl;
inTransaction >> TransTemp.custID;
if (TransTemp.custID > customer[i].custID)
{
//output array to newMaster then read in new array
outNewMaster << customer[i];
i++;
}
if (customer[i].custID == TransTemp.custID)
{
inTransaction >> Field;
//detrmine field number
if (Field == 1)
{
inTransaction >> customer[i].FirstName;
outNewMaster << customer[i];
i++;
inTransaction >> TransCode;
}
else if (Field == 2)
{
inTransaction >> customer[i].LastName;
outNewMaster << customer[i];
i++;
inTransaction >> TransCode;
}
else if (Field == 3)
{
inTransaction >> TransFloat;
float value;
if (customer[i].Status == "H" )
{
value = ((customer[i].Balance)/2);
if (TransFloat <= value)
{
customer[i].Status = "O" ;
customer[i].Balance = TransFloat;
outNewMaster << customer[i];
i++;
inTransaction >> TransCode;
}
else
{
customer[i].Balance = TransFloat;
outNewMaster << customer[i];
i++;
inTransaction >> TransCode;
}
}
else
{
customer[i].Balance = TransFloat;
outNewMaster << customer[i];
i++;
inTransaction >> TransCode;
}
}
else if (Field == 4)
{
inTransaction >> customer[i].Limit;
outNewMaster << customer[i];
i++;
inTransaction >> TransCode;
}
else if (Field == 5)
{
inTransaction >> customer[i].Status;
outNewMaster << customer[i];
i++;
inTransaction >> TransCode;
}
//determine whether it is string or float
//set corresponding field to change value
//edit array record then output to newMaster then read in new TransTemp and new array
}
else if (TransTemp.custID < customer[i].custID)
{
//read in new TransTemp
inTransaction >> TransCode;
}
cout << "End Edit" << endl;
}
if (TransCode == "P" )
{
cout << "Print" << endl;
inTransaction >> TransTemp.custID;
if (TransTemp.custID > customer[i].custID)
{
//output array then read in new array record
outNewMaster << customer[i];
i++;
}
else if (TransTemp.custID == customer[i].custID)
{
//print array to screen and newMaster then read in new TransTemp and new array
cout << customer[i].custID << "\t" << customer[i].FirstName << "\t" << customer[i].LastName << "\t" << customer[i].Balance << "\t" << customer[i].Limit << "\t" << customer[i].Status << endl;
outNewMaster << customer[i];
i++;
inTransaction >> TransCode;
}
else if (TransTemp.custID < customer[i].custID)
{
//read in new TransTemp
inTransaction >> TransCode;
}
cout << "End Print" << endl;
}
else
{
//output invalid transaction action code to Error_Log
outError << TransTemp << endl;
}
}
May 4, 2012 at 5:56pm UTC
Such posts are often very time consuming without a "test harness"
Topic archived. No new replies allowed.
