Can't seem to make random number generator generate random accuracy?

[idgafsmd]

Have you sometimes ever hear that beep sound in your ear? and the myth is when you hear a "BEEP" that means someone is talking about you, rather it is real or not, your suppose to have someone guess a number from 1 - 26, and what ever the number that the person gave you, you find the the letter of it. Example: the person said 3, so that means someone who starts with the letter "C" was talking about you or 1 then it is letter "A". So, yea, what ever anyways, that's what my program is suppose to do, but UNFORTUNATELY it keeps displaying the same letter "K". Maybe it can be the do-while-loop? or the way I assigned random being int iRandom(0+rand()%27) or I don't know? I switched the 0 to 1 and the only difference was instead of "K" being displayed, "L" was only displaying.

Here is my code:

#include <iostream>
#include <ctime>
#include <cstdlib>
/*By the way, does it really matter if I include cstdlib?
I noticed without the header file random numbers can still be generated*/
#include <Windows.h>
#include <string>

void cleanUp(void);

class PeoplesFirstLetterName {
protected:
	char a, b, c, d, e, f, g, h, i, j, k ,l, m, n, o, p, q, r, s, t, u, v, w, x, y, z;

public:
	PeoplesFirstLetterName
		(char setA=('A'), char setB=('B'), char setC=('C'), char setD=('D'), char setE=('E'), char setF=('F'),
		 char setG=('G'), char setH=('H'), char setI=('I'), char setJ=('J'), char setK=('K'), char setL=('L'),
		 char setM=('M'), char setN=('N'), char setO=('O'), char setP=('P'), char setQ=('Q'), char setR=('R'),
		 char setS=('S'), char setT=('T'), char setU=('U'), char setV=('V'), char setW=('W'), char setX=('X'),
		 char setY=('Y'), char setZ=('Z')) {
			 a=setA, b=setB, c=setC, d=setD, e=setE, f=setF, g=setG, h=setH, i=setI, j=setJ, k=setK, l=setL,
				 m=setM, n=setN, o=setO, p=setP, q=setQ, r=setR, s=setS, t=setT, u=setU, v=setV, w=setW, x=setX,
				 y=setY, z=setZ;
	}
};

class FirstLetters : public PeoplesFirstLetterName {
public:
	void letterA() {std::cout<<("Someone with the Letter: ")<<(a)<<("\nis talking about you")<<std::endl;};
	void letterB() {std::cout<<("Someone with the Letter: ")<<(b)<<("\nis talking about you")<<std::endl;};
	void letterC() {std::cout<<("Someone with the Letter: ")<<(c)<<("\nis talking about you")<<std::endl;};
	void letterD() {std::cout<<("Someone with the Letter: ")<<(d)<<("\nis talking about you")<<std::endl;};
	void letterE() {std::cout<<("Someone with the Letter: ")<<(e)<<("\nis talking about you")<<std::endl;};
	void letterF() {std::cout<<("Someone with the Letter: ")<<(f)<<("\nis talking about you")<<std::endl;};
	void letterG() {std::cout<<("Someone with the Letter: ")<<(g)<<("\nis talking about you")<<std::endl;};
	void letterH() {std::cout<<("Someone with the Letter: ")<<(h)<<("\nis talking about you")<<std::endl;};
	void letterI() {std::cout<<("Someone with the Letter: ")<<(i)<<("\nis talking about you")<<std::endl;};
	void letterJ() {std::cout<<("Someone with the Letter: ")<<(j)<<("\nis talking about you")<<std::endl;};
	void letterK() {std::cout<<("Someone with the Letter: ")<<(k)<<("\nis talking about you")<<std::endl;};
	void letterL() {std::cout<<("Someone with the Letter: ")<<(l)<<("\nis talking about you")<<std::endl;};
	void letterM() {std::cout<<("Someone with the Letter: ")<<(m)<<("\nis talking about you")<<std::endl;};
	void letterN() {std::cout<<("Someone with the Letter: ")<<(n)<<("\nis talking about you")<<std::endl;};
	void letterO() {std::cout<<("Someone with the Letter: ")<<(o)<<("\nis talking about you")<<std::endl;};
	void letterP() {std::cout<<("Someone with the Letter: ")<<(p)<<("\nis talking about you")<<std::endl;};
	void letterQ() {std::cout<<("Someone with the Letter: ")<<(q)<<("\nis talking about you")<<std::endl;};
	void letterR() {std::cout<<("Someone with the Letter: ")<<(r)<<("\nis talking about you")<<std::endl;};
	void letterS() {std::cout<<("Someone with the Letter: ")<<(s)<<("\nis talking about you")<<std::endl;};
	void letterT() {std::cout<<("Someone with the Letter: ")<<(t)<<("\nis talking about you")<<std::endl;};
	void letterU() {std::cout<<("Someone with the Letter: ")<<(u)<<("\nis talking about you")<<std::endl;};
	void letterV() {std::cout<<("Someone with the Letter: ")<<(v)<<("\nis talking about you")<<std::endl;};
	void letterW() {std::cout<<("Someone with the Letter: ")<<(w)<<("\nis talking about you")<<std::endl;};
	void letterX() {std::cout<<("Someone with the Letter: ")<<(x)<<("\nis talking about you")<<std::endl;};
	void letterY() {std::cout<<("Someone with the Letter: ")<<(y)<<("\nis talking about you")<<std::endl;};
	void letterZ() {std::cout<<("Someone with the Letter: ")<<(z)<<("\nis talking about you")<<std::endl;};
};

void menu() {
	std::string tab(6,('\t')), tab1(4,('\t')), tab2(5,('\t')), underScores(80,('_'));
	std::cout<<("Who is talking about you?")<<(tab)<<("\b[FindOut]")
		<<(underScores)<<(tab1)<<("\b\bType in<[ who ]>to begin")<<std::endl
		<<std::endl
		<<(tab2)<<("\b:> ");
}

int main() {
	FirstLetters expose;
	
	srand(NULL(time));
	int iRandom(0+rand()%27);

	bool dontExit(false);

	menu();

	std::string input;

	do {
		std::cin>>input;

		if (input == ("who")) {
			if (iRandom == 1) {
				expose.letterA();
			} else if (iRandom == 2) {
				expose.letterB();
			} else if (iRandom == 3) {
				expose.letterC();
			} else if (iRandom == 4) {
				expose.letterD();
			} else if (iRandom == 5) {
				expose.letterE();
			} else if (iRandom == 6) {
				expose.letterF();
			} else if (iRandom == 7) {
				expose.letterG();
			} else if (iRandom == 8) {
				expose.letterH();
			} else if (iRandom == 9) {
				expose.letterI();
			} else if (iRandom == 10) {
				expose.letterJ();
			} else if (iRandom == 11) {
				expose.letterK();
			} else if (iRandom == 12) {
				expose.letterL();
			} else if (iRandom == 13) {
				expose.letterM();
			} else if (iRandom == 14) {
				expose.letterN();
			} else if (iRandom == 15) {
				expose.letterO();
			} else if (iRandom == 16) {
				expose.letterP();
			} else if (iRandom == 17) {
				expose.letterQ();
			} else if (iRandom == 18) {
				expose.letterR();
			} else if (iRandom == 19) {
				expose.letterS();
			} else if (iRandom == 20) {
				expose.letterT();
			} else if (iRandom == 21) {
				expose.letterU();
			} else if (iRandom == 22) {
				expose.letterV();
			} else if (iRandom == 23) {
				expose.letterW();
			} else if (iRandom == 24) {
				expose.letterX();
			} else if (iRandom == 25) {
				expose.letterY();
			} else if (iRandom == 26) {
				expose.letterZ();
			}
		} else {
			std::cout<<("\nInvalid Command\n");
		}

	} while(!dontExit);

	return 0;
}

void cleanUp(void) { /*FYI this is to clear, but I have not used it yet because of my issue*/
	DWORD n, size;
	COORD coord={0};
	CONSOLE_SCREEN_BUFFER_INFO csbi;
	HANDLE h = GetStdHandle(STD_OUTPUT_HANDLE);
	GetConsoleScreenBufferInfo(h, &csbi);
	size = csbi.dwSize.X * csbi.dwSize.Y;
	FillConsoleOutputCharacter(h, TEXT(' '), size, coord, &n);
	GetConsoleScreenBufferInfo(h, &csbi);
	FillConsoleOutputAttribute(h, csbi.wAttributes, size, coord, &n);
	SetConsoleCursorPosition(h, coord);
}

[kbw]

I would expect rand() to be called in the loop, not once before you enter the loop.

You could use an array of characters to eliminate all that duplicate code.

[whitenite1]

You have your random setup wrong. You never assign it a value. Change it to int iRandom=(1+rand()%26); and the program will run correctly.

[idgafsmd]

So I took kbw's advice and whitenite1's advice, still no luck. Am I doing something wrong?
I tried:

 

	do {	srand(NULL(time));
		std::cin>>input;
		
		if (input == ("who")) {
			int iRandom=(0+rand()%27); //I assigned the value
			if (iRandom == 1) {
				expose.letterA();
			} else if (iRandom == 2) {
				expose.letterB();
			} 

and another method I tried:

	do { 
		std::cin>>input;
		
		if (input == ("who")) {
                        srand(NULL(time));
			int iRandom=(1+rand()%27); //I assigned the value
			if (iRandom == 1) {
				expose.letterA();
			} else if (iRandom == 2) {
				expose.letterB();
			} 

[Need4Sleep]

just a little side note for all those functions, you could use a for loop and an array to save a ton of code and worries.

[whitenite1]

Don't move int iRandom=(1+rand()%26); into the do loop. Just replace your int iRandom(0+rand()%27);, with it.

[Disch]

He doesn't even need an array. They're all literal values.

char c = char(rand() % 26) + 'A';

std::cout<< "Someone with the Letter: " << c << "\nis talking about you" << std::endl;

Anyway, kbw's advice was to move rand to inside the loop, not srand.

srand should stay at the top. rand() should be moved to wherever you want a new random number. If you want a new random number every time the loop runs, then rand() belongs in the loop.

[idgafsmd]

May you show me an example for the for loop using an array? You don't have to use my code or you can just direct me to a site. And still I can't figure out to generate random numbers, I tried so many differents techniques.

[idgafsmd]

Interesting... I figured out a more simple way -_-

#include <iostream>
#include <ctime>

signed int holdUp();

int main() {
	srand(time(NULL));
	char letters(('A') + rand() % 26);

	std::cout<<("Someone who starts with the letter ")<<(letters)<<(" was talking about you.")<<std::endl;

	holdUp();return 0;
}

signed int holdUp() {
	std::cin.sync(),
		std::cin.ignore();
	return(0);
}

[idgafsmd]

Instead of

srand(NULL(time));
I switched too
srand(time(NULL)); //Could that have been my issue? or it didn't matter?
//Because it seemed fined to me =D! 

[idgafsmd]

Thank you guys for all your help!

[Disch]

A general rule of thumb: If you find yourself making variables like "foo1", "foo2", 'foo3", etc, then you are doing something wrong.

[idgafsmd]

Disch can you be my MENTOR!? LOL