Random number generator function issue?

[cpplover]

This is the program I have for a random number generator.
somehow, it does not work and the console output screen hangs.
Anything missing here?

#include <iostream>
#include<cstdlib>
#include<ctime>
using namespace std;

int main (){
  int *data;
  srand ( time(NULL) );
  for( int i=0; i<100;i++) {
 data[i] = rand();
cout<<data[i]<<endl;
}
  return 0;
}

[Cubbi]

You're treating data as if it was a pointer to an element of an array, but it isn't. It's just an uninitialized pointer, and accessing it is an error.

If you just want to output your values, don't store them unnecessarily:

#include <iostream>
#include <cstdlib>
#include <ctime>
using namespace std;

int main ()
{
    srand ( time(NULL) );
    for( int i=0; i<100;i++)
        cout << rand() << '\n';
}

If you do need to store them, use a vector:

#include <iostream>
#include <cstdlib>
#include <ctime>
#include <vector>
using namespace std;

int main ()
{
  vector<int> data(100);
  srand ( time(NULL) );
  for( size_t i=0; i<data.size(); i++)
  {
      data[i] = rand();
      cout << data[i] << '\n';
  }
}

[cpplover]

thanks it worked :)