Eulidian Algorythim

[hvigil]

int[code] gcd( int x , int y)
{
	int  r = x & y;
	while (r != 0)
	{
		x = y;
		y = r;
		r = x % y;
		return r;


	}
}

[/code]

is this the correct way to find the GCD???

[Stewbond]

I think it's simpler than that. The main problem is that you have return r; inside the while loop. That means that you'll return after the first run of the loop. That means you'll never actually loop.

Try this out:

int gcd( int x , int y)
{
    while (y != 0)
    {
        int z = y;
        y = x % y;
        x = z;
    }
}

Or if you are into recursion:

int gcd( int x, int y)
{
    if (y == 0) return x;
    return gcd(y, x%y);
}