need help passing a string into a function

[mjbasford]

pretty new at this, ignore the rest but I am having issues passing a string value into a function in order to get it to display the info. below is the entire program, as is it compiles and runs, but crashes everytime.

Any help is greatly appreciated.

#include <iostream>
#include <string>
using namespace std;

string first, last;
string display(string);

main()
{
      string name, first, last;
      int x,y;
      
      cout << "Enter you name in First Last format ";
      getline(cin, name, '\n');
      
      y = name.find(" ");
      name = name.insert(y, "  ");
      
      cout << "Whole name: " << name << endl;
      
      x = name.length();
      first.assign(name, 0, y);
      name.erase(0, y + 3);
      last = name;
      
      cout << display(first) << display(first) << display(last) << display(last) << display(last);
      
      return 0;
}


string display(string text)
{
       cout << text << endl << text << endl;
       return 0;
       
}

edit, i have tried it with return 0; in only main, only display and in neither

[LB]

This does not even compile. Display is marked as returning a string but you have it returning an int.

[Incis B]

MJ, place this print statement into your print subrtn.
printf(" \n\n I am in the print fnc, and TEXT is : %s ", text );

and you'll see that the first string "FIRST is corrupted.
maybe not getting init'l ized or loosing it's pointer.

also,
string display(string);
The fnc DISPLAY takes the string "string" as it's arg, which is fine.
however it doesn't RTN anything !!

If a fnc doesn't return anything or rtn's void then it's usually
better to declare it as such.
void display(string);

Having just finished typing that, I noticed that you return a "0" ( or zero) within display(),
so you can remove the "0" (or zero) , and just say RETURN
having declared it as a VOID - - - void display(string)
or declare it as INT- - - int display(string)
The point being, that the two ( declaration and fnc) should match "TYPE"


Remember, you can always use fprint statements or other such statements to show where you are in the code, and, more importantly, what values are being returned ( or not) and what their values are ( or are not).

[mjbasford]

Thank you, i made a few changes based on what you suggested and it is all working now.