functions

[tke693]

I'm having trouble writing a program that uses functions to read a file and gets a list of 3 students name and 3 grade scores for each. it is then supposed to calculate the average score assign a grade and print there names average score and grade to an out put file. the problem im having is that after reading the first line of data it skips the second students data entirely then reads the thirds students name but uses the grades from the first student. any help would be greatly appreciated.

this is the data info it should get if read correctly:

Mickey Mouse 45 78 91
Minnie Mouse 95 92 88
Donald Duck 72 81 89

and this is my program


#include <iostream>
#include <iomanip>
#include <string>
#include <fstream>
using namespace std;

void greeting();
void getName(ifstream& fin, string& first, string& last);
void readScore(ifstream& fin, int& cscore1, int& cscore2, int& cscore3);
void reportNoScore();
double calculateAverage(int& cscore1, int& cscore2, int& cscore3);
char assignGrade(double& cAveScore);
void printData(string& first, string& last, double& gAveScore, char& cGrade, ofstream& out);
void farewell();


int main()
{
string fname = " ";
string lname = " ";
int score1 = 0;
int score2 = 0;
int score3 = 0;
char grade = ' ';
double aveScore = 0.0;

ifstream in;
in.open("A6Data.txt");
ofstream out;
out.open("Grade.txt");

greeting();

while (!in.eof())
{
getName(in, fname, lname);
readScore(in, score1, score2, score3);
aveScore = calculateAverage(score1, score2, score3);
grade = assignGrade(aveScore);
printData(fname, lname, aveScore, grade, out);
}




farewell();

in.close();
out.close();
return 0;
}

void greeting()
{ cout << "Welcome this is a simple grade calculating program." << endl;
}
void getName(ifstream& fin, string& first, string& last)
{


fin >> first >> last;
fin.ignore(10, '\n');
cout << first <<" " << last << " " ;


}
void readScore(ifstream& gin, int& cscore1, int& cscore2, int& cscore3)
{

gin.ignore(20, ' ');
gin.ignore(20, ' ');
gin >> cscore1 >> cscore2 >> cscore3;
cout << cscore1 << " " << cscore2 << " " << cscore3 << " ";


}


void reportNoScore()
{ cout << "This Person has no score please make sure there is a score";
}


double calculateAverage(int& cscore1, int& cscore2, int& cscore3)
{ double gAveScore;

gAveScore = (cscore1 + cscore2 + cscore3) / 3;

cout << gAveScore << " ";

return gAveScore;
}

char assignGrade(double& gAveScore)
{ char cGrade = ' ';

if (gAveScore >= 90)
{
cGrade = 'A';
}
else if (gAveScore >= 80)
{
cGrade = 'B';
}
else if (gAveScore >= 70)
{
cGrade = 'C';
}
else if(gAveScore >= 60)
{
cGrade = 'D';
}
else if((gAveScore >= 0) && (gAveScore < 60))
{
cGrade = 'F';
}

cout << cGrade << endl;

return cGrade;
}
void printData(string& first, string& last, double& gAveScore, char& cGrade, ofstream& out)
{


out << first << " " << last << " " << gAveScore << " " << cGrade << " " << endl;
}
void farewell()
{ cout << "Thank you for using this simple grade calculator :) " << endl;
}

[Subzero030201]

Code works now

#include <iostream>
#include <iomanip>
#include <string>
#include <fstream>
using namespace std;

void greeting();
void getName(ifstream& fin, string& first, string& last);
void readScore(ifstream& fin, int& cscore1, int& cscore2, int& cscore3);
void reportNoScore();
double calculateAverage(int& cscore1, int& cscore2, int& cscore3);
char assignGrade(double& cAveScore);
void printData(string& first, string& last, double& gAveScore, char& cGrade, ofstream& out);
void farewell();


int main()
{
string fname = " ";
string lname = " ";
int score1 = 0;
int score2 = 0;
int score3 = 0;
char grade = ' ';
double aveScore = 0.0;

ifstream in;
in.open("A6Data.txt");
ofstream out;
out.open("Grade.txt");

greeting();

while (!in.eof())
{
getName(in, fname, lname);
readScore(in, score1, score2, score3);
aveScore = calculateAverage(score1, score2, score3);
grade = assignGrade(aveScore);
printData(fname, lname, aveScore, grade, out);
}

//printData(fname, lname, aveScore, grade, out);


farewell();

in.close();
out.close();
return 0;
}

void greeting()
{ cout << "Welcome this is a simple grade calculating program." << endl;
}
void getName(ifstream& fin, string& first, string& last)
{


fin >> first >> last;
//fin.ignore(10, '\n');
cout << first <<" " << last << " " ;


}
void readScore(ifstream& gin, int& cscore1, int& cscore2, int& cscore3)
{

//gin.ignore(20, ' ');
//gin.ignore(20, ' ');
gin >> cscore1 >> cscore2 >> cscore3;
cout << cscore1 << " " << cscore2 << " " << cscore3 << " ";


}


void reportNoScore()
{ cout << "This Person has no score please make sure there is a score";
}


double calculateAverage(int& cscore1, int& cscore2, int& cscore3)
{ double gAveScore;

gAveScore = (cscore1 + cscore2 + cscore3) / 3;

cout << gAveScore << " ";

return gAveScore;
}

char assignGrade(double& gAveScore)
{ char cGrade = ' ';

if (gAveScore >= 90)
{
cGrade = 'A';
}
else if (gAveScore >= 80)
{
cGrade = 'B';
}
else if (gAveScore >= 70)
{
cGrade = 'C';
}
else if(gAveScore >= 60)
{
cGrade = 'D';
}
else if((gAveScore >= 0) && (gAveScore < 60))
{
cGrade = 'F';
}

cout << cGrade << endl;

return cGrade;
}
void printData(string& first, string& last, double& gAveScore, char& cGrade, ofstream& out)
{


out << first << " " << last << " " << gAveScore << " " << cGrade << " " << endl;
}
void farewell()
{ cout << "Thank you for using this simple grade calculator :) " << endl;
}

[tke693]

wow really is that all i had to do...i feel like an idiot....thank you sooooooo much