Counting Characters

[Joshua Spears]

Hello again C++ WORLD! I am once again having trouble with my program. I am trying to creat a program that will count the total number of characters, the number of letters, total upper and total lowercase, total punctiations and total numbers in the input. Also re-write the code in all caps. I have written it thus far (without the code to make it turn into all caps) where there are no errors (build errors) but It does not do anything when ran. I need any kind of help with what is wrong with how I wrote the program and what I can do to make it run.

P.S. Teacher says I need the functions cin.get(), int isAlpha(), int isDigit(), int isUpper(), and int isLower(). Thanks in advance for all the help!

#include <iostream>
#include <iomanip>

using namespace std;

char c = 0;
char a;

int CharCount = 0,      // Total characters count
	AlphaCount = 0,     // Total letter count
	CapCount = 0,       // Total uppercase letter count
	LowerCaseCount = 0, // Total lowercase letter count
	PunctCount = 0,     // Total punctiation count
	DigitCount = 0;     // Total number count
	

int isChar(char c)
{

	CharCount = AlphaCount + DigitCount + PunctCount;

}

int isAlpha(char c)
{
	if (c >= 'a' && c <='z' || c >= 'A' && c <= 'Z')
	return 1;

	else 
	return 0;	  
}

int isDigit(char c)
{

	if (c >= '0' && c <= '9')
	return 1;
	
	else
	return 0;
}

int isUpper(char c)
{

	if (c >= 'A' && c <= 'Z')
	return 1;
	
	else
	return 0;
}

int isLower(char c)
{
 	if (c >= 'a' && c <='z')
	return 1;

	else 
	return 0;	  	   
}

int main()
{
cout << "Type a series of lines to get character counts for each line" << endl;
cout << "Type a line consisting of a single period '.' to stop" << endl;

cout << "\n";

cin.get(c);
	while (c != '.')
		{
		        CharCount += isChar(c);
			AlphaCount += isAlpha(c);
			CapCount += isUpper(c);
			LowerCaseCount += isLower(c);
			DigitCount += isDigit(c); 
			
			if (c >= '!' && c <= ')')
				{ 
					PunctCount++;
				}	  	  	  
		}
		

cout << "Char count:         " << CharCount << endl;
cout << "Alpha count:        " << AlphaCount << endl;
cout << "Caps count:         " << CapCount << endl;
cout << "Lower case count:   " << LowerCaseCount << endl;
cout << "Punctuation count:  " << PunctCount << endl;
cout << "Digit count:        " << DigitCount << endl;

return 0;

}

Example Output:

Joe Hill
JOE HILL

Char count:    8
Alpha count:   7
Cap count:     2
Lower case:    5
Punct:         0
Digit count:   0

[Vins3Xtreme]

you can use the functions just definied in the header <cctype> for yout purpouse:
http://cplusplus.com/reference/clibrary/cctype/

[coder777]

You need a secon cin.get() before the end of the loop (before line 68)

[Joshua Spears]

Wow!! Thanks guys!!! The only problem I am having now is that am I getting a crazy number for my CharCount???? Im sure that's an error in computation on my part so I can figure that out. Thanks again !!!!

[NerdTastic]

What do you mean crazy? is the number super high, super low, or negative?

[Joshua Spears]

NerdTastic (32) Mar 13, 2012 at 10:22am
What do you mean crazy? is the number super high, super low, or negative?

Text:

Apples!!

Char count: 16
Alpha count: 6
Caps count: 1
Lower case count: 5
Punctuation count: 2
Digit count: 0

Everything else is ok, just the char count.
Doesnt make sense why its doing this.

[zb0S216C]

Try counting the amount of characters with this:

int Char_Count( const char *String )
{
    if( !String )
        return( 0 );

    int Count( 0 );
    while( *String )
    {
        if( *String == ' ' )
        {
            ++String;
            continue;
        }

        ++Count, ++String;
    }

    return( Count );
}

I tested it and it works. Note that this function doesn't count white-space as a character.

_Wazzak

[Joshua Spears]

Framework (1924) Mar 13, 2012 at 12:09pm
Try counting the amount of characters with this:

 int Char_Count( const char *String )
{
    if( !String )
        return( 0 );

    int Count( 0 );
    while( *String )
    {
        if( *String == ' ' )
        {
            ++String;
            continue;
        }

        ++Count, ++String;
    }

    return( Count );
} 

I tested it and it works. Note that this function doesn't count white-space as a character.

Wazzak

Thank you very much for your help but my teacher says I need to use the int isChar(char c) technique. To learn it or something.

[cire]

int isChar(char c)
{
	CharCount = AlphaCount + DigitCount + PunctCount;
}

IsChar does nothing with c. Why is that?

	while (c != '.')
		{
		        CharCount += isChar(c);
			AlphaCount += isAlpha(c);
			CapCount += isUpper(c);
			LowerCaseCount += isLower(c);
			DigitCount += isDigit(c); 
			
			if (c >= '!' && c <= ')')
				{ 
					PunctCount++;
				}	  	  	  
		}

On the last iteration of the loop, what happens? IsChar() depends on the values updated by the function calls following it. Is that order right? Do you really want to be adding CharCount to the value it returns?

Since IsChar doesn't do what one would think it should, you can move it out of the loop entirely and just call it after.

I suspect, however, that your instructor is expecting the definition of isChar to look more like:

int isChar(char c)
{
        // Yes, I realize you don't have an IsPunct() function.  You get the drift!
	return IsAlpha(c) || IsDigit(c) || IsPunct(c) ;
}

[coder777]

This is certainly what you mean:

int isChar(char c)
{
	if (isAlpha(c) || isDigit(c) || isPunct(v))
	return 1;

	else 
	return 0;	  
}

[cire]

That's another way of writing it, yes.

[coder777]

@cire: Um, last time I saw your post the 'isChar()' wasn't there, I swear. This let me look kinda...

Joshua Spears wrote:

To learn it or something.

Gawd, theacher these days...

[cire]

Heheh. Yeah. I see now your post time was the same as my edit time.

[Joshua Spears]

wow seriously... THANKS!!!! I've been really stuck (prob because I'm a beginner lol) but all the help is GREATLY APPRECIATED!!!! and that's a thanks to EVERYONE!!