pls can u find the error in my program

[yashashvini]

#include<iostream>
#include<conio.h>
#include<math.h>
using namespace std;
int main()
{
int n,s,a,c,i,b,;

a=0;
c=0;
cout<<"enter the binary number"<<endl;
cin>>n;
cout<<"enter the no of digits in the number"<<endl;
cin>>s;
for(i=0;i<s;i++)
{
for(b=0;b<s;b++)
{

c=c+((n/pow(10,b))%10)*pow(2,b);
}
}
cout<<"the decimal equivalent is:"<<c<<endl;
getch();
return 0;
}

[ne555]

It does not compile

[Stewbond]

1. You had a comma in your declarations immediately before the semi-colon.
2. Depending on your compiler, you may not have a pow function that accepts 2 ints.

#include<iostream>
#include<conio.h> 
using namespace std;

int pow(int num,int exp) // This will work for your purposes.
{
	int out = 1;
	while (exp-- > 0)  out *= num;
	return out;
}

int main()
{
	int n,s,a,c,i,b; // You had a comma before the semi-colon

	a=0;
	c=0;
	cout<<"enter the binary number"<<endl;
	cin>>n;
	cout<<"enter the no of digits in the number"<<endl;
	cin>>s;

	for(i=0;i<s;i++)
	{
		for(b=0;b<s;b++)
		{
			c=c+((n/pow(10,b))%10)*pow(2,b); // If your compiler doesn't have int pow(int,int) supported, you'll need to write one or cast these.
		}
	}
	cout<<"the decimal equivalent is:"<<c<<endl;
	getch();
	return 0;
}

Now it will compile. I'll let you figure out the problems with the algorithm giving you the wrong number.

Hint: I entered 1101 (13) and it converted it to 52 (which is actually 110100)

***SPOILER HINT****

for (int digit = 0; binary > 0; digit++)
{
	decimal += (binary%10) * pow(2,digit);	// Extract the right-most digit and multiply by the value of this decimal place
	binary /= 10; // Shift the decimal place over
}

[yashashvini]

thank u