[SOLVED] Various Problems with HANGMAN Program

[bluezor]

SOLVED

Thanks!

[anders43]

What code do you have so far?

[bluezor]

I didn't actually have a specific code. I tried all sorts of stuff from the internet, including some from source codes.

Here's my example using the site's one though. (Also, I need to know if an array is good to hold the words for processing. Will it be too big, since it's over 80,000 words?)

#include <iostream>
#include <fstream>
using namespace std;

int main()
{
string word_array[89523];
string words;
ifstream myFile ("EnglishWords.txt");
if (myFile.is_open())
{
while (!myFile.eof())
{
getline (myFile, line);
word_array[89523] = { line };
}
myFile.close();
}
else
{
cout << "Unable to open or locate 'EnglishWords.txt'" << endl;
}
return(0);
}

This is only the code for trying to get the words into an array (or something to hold the words). But of course, it won't work.

[guestgulkan]

Well, this is wrong for a start:

word_array[89523] = { line };

for two reasons:

1. The value 89523 is outside the bounds of the array - and would probably cause an access violation. The array bounds are
word_array[0] upto and including word_array[89522]

2. Evenif you had used a value within the bounds of the array, you are simply using the same array subscript over and over again.

[helios]

80000 words at an average of 10 letters per word is 800 KiB, without counting structure overhead.

word_array[89523] = { line };
What?

A vector will be better suited for this task. You don't have to worry about how many line there actually are in the file.

[bluezor]

Would my method of getting the lines work?

[firedraco]

Yes, but the way you are using it you will want (need) to use a vector.

[bluezor]

#include <iostream>
#include <fstream>
#include <string>
#include <vector>
using namespace std;

int main()
{
    string line;
    vector<string>words;
    ifstream myFile ("EnglishWords.txt");
    if (myFile.is_open())
    {
        while (!myFile.eof())
        {
            getline (myFile, line);
            words.push_back(line);
        }
    }
    else
    {
        cout << "Could not locate or open 'EnglishWords.txt'" << endl;
    }
    cout << words[5] << endl;
}

I tried again using a vector (with a tutorial from cprogramming.com). This code is used to just try and get the words into a vector first, but of course, it doesn't work. I think I don't really understand how vectors work and might need some help.

Thanks!

[seymore15074]

80,000 words! Use a set (rather than a vector) for fast look ups; assuming that all you want to find out is if the word exists or not...

Anyway, add "return 0;" at the end and make sure you have EnglishWords.txt in the right directory and that looks like it'll work fine. Post your errors/results when you claim that it is not working so that we may be more helpful.

Also, add "myFile.close();" after the while loop.

[bluezor]

SOLVED

[bluezor]

SOLVED

My final production -

//Code source mostly based on HANGMAN by Sam Paterson.
//You may contact him at <[e-mail]>.
//Actual Hangman.cpp coded by Bluezor or Jackie.
//You may contact me at <***.******@gmail.com>.

/////////////////////////////////////////////////////////

#include <iostream>
#include <fstream>
#include <string>
#include <vector>
#include <set>
#include <ctime>
using namespace std;

vector <string> words;
vector <string> board;
vector <pair <pair <size_t, size_t>, char > > body;
set <char> used_letters;
string word;
string word_letters;
int randomNumber = rand() % 89523;
bool completed_loading = false;

inline void TOLOWER (string& st)
{
    for (size_t i = 0; i < st.size(); i++)
    {
        st[i] = tolower(st[i]);
    }
}

inline void check_cin()
{
    if (!cin)
    {
        if (cin.eof())
        exit(EXIT_SUCCESS);
        cin.clear();
        cin.ignore(numeric_limits<streamsize>::max(), '\n');
    }
}

void readFile()
{
    string line;
    ifstream myFile ("EnglishWords.txt");
    if (myFile.is_open())
    {
        while (!myFile.eof())
        {
            getline (myFile, line);
            words.push_back(line);
        }
        myFile.close();
        completed_loading = true;
    }
    else
    {
        cout << "Could not locate or open 'EnglishWords.txt'." << endl;
        cout << "Press ENTER to continue...";
        cin.ignore( std::numeric_limits<std::streamsize>::max(), '\n' );
    }
}

void fill_place_holders()
{
    for (size_t i = 0; i < word.size(); i++)
    word_letters.append("-");
}

void pickWord()
{
    word = words[randomNumber];
}

void print_board()
{
    vector <string>::iterator it;
    for (it = board.begin(); it != board.end(); it++)
    {
        cout << *it << endl;
    }
    cout << endl << endl << "Word: " << word_letters << endl;
    cout << "Used letters: ";
    set <char>::iterator set_it;
    for (set_it = used_letters.begin(); set_it != used_letters.end(); set_it++)
    {
        cout << *set_it << " " << endl;
    }
}

void create_board_and_body()
{
    board.push_back ("-----");
    board.push_back ("    |");
    board.push_back ("    |");
    board.push_back ("    |");
    board.push_back ("    |");
    board.push_back ("   /|\\");

    body.push_back(make_pair(make_pair(4,3), '\\'));
    body.push_back(make_pair(make_pair(4,1), '/'));
    body.push_back(make_pair(make_pair(3,2), '|'));
    body.push_back(make_pair(make_pair(2,3), '\\'));
    body.push_back(make_pair(make_pair(2,2), '|'));
    body.push_back(make_pair(make_pair(2,1), '/'));
    body.push_back(make_pair(make_pair(1,2), '0'));
}

void add_part()
{
    if (!body.size())
    {
        cout << "The man got hanged!" << endl;
        cout << "You thoroughly mourn to realise the word was " << word << endl;
        cout << "Press ENTER to continue...";
        cin.ignore( std::numeric_limits<std::streamsize>::max(), '\n' );
        exit(EXIT_SUCCESS);
    }
    pair <pair <size_t, size_t>, char > part = body.back();
    body.pop_back();
    board[part.first.first][part.first.second] = part.second;
}

void users_turn()
{
    char letter;
    cout << "Enter a letter to guess." << endl;
    check_cin();
    cin >> letter;
    letter = tolower(letter);

    while (used_letters.find(letter) != used_letters.end() || !isalpha(letter))
    {
        cout << "Letter taken already, or bad letter. \n\n" << endl;
        cout << "Enter a letter to guess." << endl;
        check_cin();
        cin >> letter;
        letter = tolower(letter);
    }

    used_letters.insert(letter);
    bool found = false;
    for (size_t i = 0; i < word.size(); i++)
    {
        if (word[i] == letter)
        {
            word_letters[i] = letter;
            found = true;
        }
    }

    if (word_letters.find("-") == string::npos)
    {
        cout << "You got it! The word is " << word << "!" << endl;
        cout << "Congratulations! You saved the man from being hanged!" << endl;
        exit(EXIT_SUCCESS);
    }

    if (!found)
    add_part();
}

int main()
{
    srand(time(0));

    cout << "Choosing a word from 'EnglishWords.txt', please wait." << endl;
    readFile();
    pickWord();
    if (completed_loading = true)
    {
        cout << "COMPLETE!" << endl;
    }
    fill_place_holders();
    create_board_and_body();
    print_board();

    while(true)
    {
        users_turn();
        print_board();
    }

    cout << "Press ENTER to continue...";
    cin.ignore( std::numeric_limits<std::streamsize>::max(), '\n' );
    return(0);
}

Wow! That is some SERIOUSLY complicated code for me. :@.

NOTE: Original code posted in http://peabody.weeman.org/hangman.cpp.