C++ weather statistics tracking program <SOLVED>

[Vader07]

I am a student in a beginner's C++ class and my final project is to create a weather statistics tacking program.

Link to the assnmnt: http://brahms.eecs.utoledo.edu/~jguernse/_pdf/project4.pdf

My code seems to be retarded and doesn't seem to work properly after 31 lines of output.
Here is the abomination:

#include <iostream>
#include <iomanip>
#include <cctype>
#include <cstdlib>
#include <cmath>
#include <string>
#include <fstream>
#include <time.h>

using namespace std;

// Author: nunya
// Project 4

int main (void){
	ifstream hourlyTemp;
    ifstream averageTemp;
    ifstream historicalTemp;
    string filename;
    double days[31][24];

	//Attempting to open files
	hourlyTemp.open("c:/temperature/File 1.txt");
	if (hourlyTemp.fail()) {
		cout << "Couldn't open input file" << endl;
		cin.ignore();
		return EXIT_FAILURE;
	}
	averageTemp.open("c:/temperature/File 2.txt");
	if (averageTemp.fail()) {
		cout << "Couldn't open input file" << endl;
		cin.ignore();
		return EXIT_FAILURE;
	}
	historicalTemp.open("c:/temperature/File 3.txt");
	if (historicalTemp.fail()) {
		cout << "Couldn't open input file" << endl;
		cin.ignore();
		return EXIT_FAILURE;
	}

    for(int day = 0; day < 31; day++){
        for(int hour = 0; hour < 24; hour++){
            hourlyTemp >> days[day][hour];
            cout << days[day][hour] << " ";
        }
        cout << endl;
    }

    double lowtemp;
    double lowtemps[31];
    double hightemp;
    double hightemps[31];
    double averagetemp;
    double averagetemps[31];
    for (int day = 0; day<31; day++){
        lowtemp = days [day][0];
        for (int hour = 0;hour <24; hour++){
            if (days[day][hour] < lowtemp){
                lowtemp = days [day][hour];
            }
        }
        lowtemps [day]=lowtemp;
        cout << "Low temp for Day:   " << lowtemp << endl;
    }

     for (int day = 0; day<31; day++){
        hightemp = days[day][0];
        for (int hour = 0; hour<24; hour++){
            if (days[day][hour] > hightemp) {
             hightemp= days [day][hour];
            }

        }
        hightemps[day]=hightemp;
        cout << " High temp for the Day:  " << hightemp << endl;
     }
     for (int day = 0; day < 31; day++){
        averagetemp = days[day][0];
        for (int hour=0; hour < 24; hour++) {
            averagetemp=averagetemp + days[day][hour];
        }
        averagetemp=averagetemp/24;
        averagetemps[day]=averagetemp/24;
        cout << "Average temp for the Day:  " << averagetemp << endl;
     }
    cin.ignore();
    cin.ignore();
    return EXIT_SUCCESS;
}

Fun, eh?

Thank you in advance for the help. :)

P.S. Don't worry about the deadline, my professor gave us all a grace period. We are all stuggling...

[firedraco]

How exactly is it "not working properly"? Also...your code looks fine...what do the text files look like?

[Vader07]

I have it so that it should be identical every 4 lines (to check and see if it is working correctly) and it isn't exactly correct!

File 1:
10 6 4 1 -2 -4 -3 -1 3 5 10 17 19 20 20 22 21 20 19 17 15 13 11
19 19 19 19 18 18 18 19 20 20 21 23 25 28 31 35 34 32 30 28 27 27 26
25 25 24 24 24 23 23 24 26 28 29 30 32 33 35 37 36 34 33 30 29 28 27
26 25 25 24 23 22 22 22 23 23 24 24 23 20 17 13 12 12 11 10 10 10 10
10 6 4 1 -2 -4 -3 -1 3 5 10 17 19 20 20 22 21 20 19 17 15 13 11
19 19 19 19 18 18 18 19 20 20 21 23 25 28 31 35 34 32 30 28 27 27 26
25 25 24 24 24 23 23 24 26 28 29 30 32 33 35 37 36 34 33 30 29 28 27
26 25 25 24 23 22 22 22 23 23 24 24 23 20 17 13 12 12 11 10 10 10 10
10 6 4 1 -2 -4 -3 -1 3 5 10 17 19 20 20 22 21 20 19 17 15 13 11
19 19 19 19 18 18 18 19 20 20 21 23 25 28 31 35 34 32 30 28 27 27 26
25 25 24 24 24 23 23 24 26 28 29 30 32 33 35 37 36 34 33 30 29 28 27
26 25 25 24 23 22 22 22 23 23 24 24 23 20 17 13 12 12 11 10 10 10 10
10 6 4 1 -2 -4 -3 -1 3 5 10 17 19 20 20 22 21 20 19 17 15 13 11
19 19 19 19 18 18 18 19 20 20 21 23 25 28 31 35 34 32 30 28 27 27 26
25 25 24 24 24 23 23 24 26 28 29 30 32 33 35 37 36 34 33 30 29 28 27
26 25 25 24 23 22 22 22 23 23 24 24 23 20 17 13 12 12 11 10 10 10 10
10 6 4 1 -2 -4 -3 -1 3 5 10 17 19 20 20 22 21 20 19 17 15 13 11
19 19 19 19 18 18 18 19 20 20 21 23 25 28 31 35 34 32 30 28 27 27 26
25 25 24 24 24 23 23 24 26 28 29 30 32 33 35 37 36 34 33 30 29 28 27
26 25 25 24 23 22 22 22 23 23 24 24 23 20 17 13 12 12 11 10 10 10 10
10 6 4 1 -2 -4 -3 -1 3 5 10 17 19 20 20 22 21 20 19 17 15 13 11
19 19 19 19 18 18 18 19 20 20 21 23 25 28 31 35 34 32 30 28 27 27 26
25 25 24 24 24 23 23 24 26 28 29 30 32 33 35 37 36 34 33 30 29 28 27
26 25 25 24 23 22 22 22 23 23 24 24 23 20 17 13 12 12 11 10 10 10 10
10 6 4 1 -2 -4 -3 -1 3 5 10 17 19 20 20 22 21 20 19 17 15 13 11
19 19 19 19 18 18 18 19 20 20 21 23 25 28 31 35 34 32 30 28 27 27 26
25 25 24 24 24 23 23 24 26 28 29 30 32 33 35 37 36 34 33 30 29 28 27
26 25 25 24 23 22 22 22 23 23 24 24 23 20 17 13 12 12 11 10 10 10 10
10 6 4 1 -2 -4 -3 -1 3 5 10 17 19 20 20 22 21 20 19 17 15 13 11
19 19 19 19 18 18 18 19 20 20 21 23 25 28 31 35 34 32 30 28 27 27 26
25 25 24 24 24 23 23 24 26 28 29 30 32 33 35 37 36 34 33 30 29 28 27

File 2:
22 -4 10.57
35 18 24.17
37 23 28.65
24 10 18.73
22 -4 10.57
35 18 24.17
37 23 28.65
24 10 18.73
22 -4 10.57
35 18 24.17
37 23 28.65
24 10 18.73
22 -4 10.57
35 18 24.17
37 23 28.65
24 10 18.73
22 -4 10.57
35 18 24.17
37 23 28.65
24 10 18.73
22 -4 10.57
35 18 24.17
37 23 28.65
24 10 18.73
22 -4 10.57
35 18 24.17
37 23 28.65
24 10 18.73
22 -4 10.57
35 18 24.17
37 23 28.65

File 3:
28
28
29
29
28
28
29
29
28
28
29
29
28
28
29
29
28
28
29
29
28
28
29
29
28
28
29
29
28
28
29

I'm not sure what to make of it, really.

[Vader07]

Alright, I have finished the project, I have changed a LOT since I first posted and it actually works. Let me know what you think of it. I am quite proud of myself. :)

#include <iostream>
#include <iomanip>
#include <cctype>
#include <cstdlib>
#include <cmath>
#include <string>
#include <fstream>
#include <time.h>

using namespace std;

// Author: nunya
// Project 4

void main() {
	float average;
	int a, b, c, days, month, h; 
	ifstream input;
	int X[31][24];
	int avg[31] = {0};
	int hist[31];
	int histAvg[31];
	int lowMeanHigh[31][3];

	input.open ("File 1.txt");
	if (input.fail()) {
		cout << "File 1 not found.\n";
		cin.ignore();
		exit(1);
	}
	do {
		cout << "Enter month number :";
		cin >> month;
		if (month == 2)
			days = 28;
		else if (month == 4 || month == 6 || month == 9 || month == 11)
			days = 30;
		else
			days = 31;
	}
	while (month < 0 && month > 13);
	for (b = 0; b < days; b++) {
		average=0;
		for (a = 0; a < 24; a++) {
			input >> h;
			avg[b]+=h;
		}
		avg[b] = avg[b]/24;
	}
	input.close();
	
	input.open ("File 3.txt");
	if (input.fail()) {
		cout << "File 3 not found.\n";
		cin.ignore();
		exit(1);
	}
	for (a = 0; a < days; a++) 
		input >> histAvg[a];
	input.close();
	
	for (a = 0; a < days; a++)
		hist[a] = avg[a] - histAvg[a];

	cout << "Daily Average Temperature Histogram\n" << "Day +----+----+----+----+----+----+----|----+----+----+----+----+----+----+\n";
	for (a = 0; a < days; a++) {
		if (a < 9)
			cout << a + 1 << "    ";
		else
			cout << a + 1 << "   ";
		if (hist[a] < 0) {
			h = 34 + hist[a];
			do {
				cout << " ";
				h--;
			}
			while (h > 0);
			do {
				cout << "*";
				hist[a]++;
			}
			while (hist[a] < 0);
			cout << "|";
		}
		else if (hist[a] > 0) {
			h = 34;
			do {
				cout << " ";
				h--;
			}
			while(h > 0);
			cout << "|";
			do {
				cout << "*";
				hist[a]--;
			}
			while (hist[a] > 0);
		}
		else {
			h = 34;
			do {
				cout << " ";
				h--;
			}
			while(h > 0);
			cout << "|";
		}
		cout<<"\n";
	}
	
	input.open ("File 1.txt");
	if (input.fail()) {
		cout << "File 1 not found.\n";
		cin.ignore();
		exit(1);
	}
	for (b = 0; b < days; b++) {
		for (a = 0; a < 24; a++) {
			input >> X[b][a];
		}
	}
	input.close();

	for (b = 0; b < days; b++) {
		for (a = 0; a < 24; a++) {
			for (c = 0; c <23; c++) {
				if (X[b][c+1] < X[b][c]) {
					h = X[b][c];            
					X[b][c] = X[b][c+1];
					X[b][c+1] = h;
				}
			}
		}
		lowMeanHigh[b][0]=X[b][0];
		lowMeanHigh[b][1]=X[b][11];
		lowMeanHigh[b][2]=X[b][23];
	}

	input.open ("File 2.txt");
	if (input.fail()) {
		cout << "File 2 not found.\n";
		cin.ignore();
		exit(1);
	}

	input.close();

	cout << "\n\nDaily Lows, Medians, and Highs Chart\n" << "Day +----+----+----+----+----+----+----|----+----+----+----+----+----+----+\n";

	for (b = 0; b < days; b++)
		for(a = 0; a < 3; a++) {
			lowMeanHigh[b][a] = lowMeanHigh[b][a] - histAvg[b] + 34; 
		}
	for (b = 0; b < days; b++) {
		if (b < 9)
			cout << b + 1 << "    ";
		else
			cout << b + 1 << "   ";
		for(a = 0; a < 70; a++) {
			if (a == 34)
				cout << "|";
			else if (a == lowMeanHigh[b][0])
				cout << "L";
			else if (a == lowMeanHigh[b][1])
				cout << "M";
			else if (a == lowMeanHigh[b][2])
				cout << "H";
			else
				cout << " ";
		}
		cout << "\n";
	}
	cin.ignore();
	cin.ignore();
	//This program made me want to die. AHHHHHHHHHH!
}

Feel free to leave your impression of it. :) Thanks!