C++

Forum

 
calculator

moot1 (259)
what can i add to this program to make it better

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
 
#include <iostream>
#include <cstdlib>

using namespace std;

int main()
{
    int Total = 0;
	int Amount;
	int Number;
	int whatoperation;
	int answertoaverage;
	int restart;

	while (restart) {
    system("CLS");

	cout << "Here are your choices(enter the number before the operation)" << endl << endl;
	cout << "1.Addition" << endl;
	cout << "2.Subtraction" << endl;
	cout << "3.Multiplication" << endl;
	cout << "4.Division" << endl;
	cout << "5.Average Calculator" << endl;

	cin >> whatoperation;

	system("CLS");

	switch(whatoperation){
    case 1:
    cout << "Enter in how many numbers you want to use" << endl;
	cin >> Amount;

	for(int i = 0; i < Amount; i++)   // Keeps looping until i == Amount
	{
		cout << "Number " << i << ": " ;  // Shows user what number they are entering
		cin >> Number;

		Total = Number + Total;  // Adds number to total
	}

	cout << "The total is " << Total << endl;  // Prints out total value when loop has finished
	Total = 0;  // resets total back to zero
	break;

	case 2:
	cout << "Enter in how many numbers you want to use" << endl;
	cin >> Amount;

	for(int i = 0; i < Amount; i++)
	{
		cout << "Number " << i << ": " ;
		cin >> Number;

		if(i == 0)
		{
			Total = Total + Number;
		}

		else
		{
			Total = Total - Number;
		}
	}

	cout << "The total is " << Total << endl;
	Total = 0;
	break;

	case 3:
	cout << "Enter in how many numbers you want to use" << endl;
	cin >> Amount;

	for(int i = 0; i < Amount; i++)
	{
		cout << "Number " << i << ": " ;
		cin >> Number;

		if(i == 0)
		{
			Total = Total + Number;
		}

		else
		{
			Total = Total * Number;
		}
	}
	cout << "The answer is " << Total << endl;
    Total = 0;
	break;

	case 4:
	cout << "Enter in how many numbers you want to use" << endl;
	cin >> Amount;

	for(int i = 0; i < Amount; i++)
	{
		cout << "Number " << i << ": " ;
		cin >> Number;

		if(i == 0)
		{
			Total = Total + Number;
		}

		else
		{
			Total = Total / Number;
		}
	}
	cout << "The total is " << Total << endl;
	Total = 0;
	break;
	case 5:
	cout << "Enter how many numbers you want to find the average of: ";
	cin >> Amount;

	for(int i = 0; i < Amount; i++)
	{
	    cout << "Number " << i << ": " ;
		cin >> Number;

		Total = Number + Total;
	}
	answertoaverage = Total / Amount;
	cout << "The average of those " << Amount << " numbers is " << answertoaverage << endl;
	answertoaverage = 0;
}
	cout << "enter 1 to restart or 2 to quit: ";
	cin >> restart;
	if(restart == 1){
    }else{
        break;
    }

    }

    cin.get();
	return 0;
}
Last edited on
ResidentBiscuit (4459)
Functions, and get rid of system calls. I hardly read it because the lack of functions
moot1 (259)
I don't see anywhere I can put a function that will make the program shorter
ResidentBiscuit (4459)
Shorter? Maybe not much. More readable and able to be modified easier? Definitely
Bnn678 (33)
i would suggest, just a thought, instead of doing case/break you could use if and else statements
ResidentBiscuit (4459)
Eh, I think case statement is better.
moot1 (259)
ok i tryed to make case 1 into a function but when i press 1 to add it goes right to the restart screen. why?

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
 
#include <iostream>
#include <cstdlib>

using namespace std;

int addition()
{
    int Total = 0;
	int Amount;
	int Number;
	int whatoperation;
	int answertoaverage;
	int restart;

    cout << "Enter in how many numbers you want to use" << endl;
	cin >> Amount;

	for(int i = 0; i < Amount; i++)   // Keeps looping until i == Amount
	{
		cout << "Number " << i << ": " ;  // Shows user what number they are entering
		cin >> Number;
	}
}

int main()
{
    int Total = 0;
	int Amount;
	int Number;
	int whatoperation;
	int answertoaverage;
	int restart;

	while (restart) {
    system("CLS");

	cout << "Here are your choices(enter the number before the operation)" << endl << endl;
	cout << "1.Addition" << endl;
	cout << "2.Subtraction" << endl;
	cout << "3.Multiplication" << endl;
	cout << "4.Division" << endl;
	cout << "5.Average Calculator" << endl;

	cin >> whatoperation;

	system("CLS");

	switch(whatoperation){
    case 1:
    int addition();

    break;
    case 2:
	cout << "Enter in how many numbers you want to use" << endl;
	cin >> Amount;

	for(int i = 0; i < Amount; i++)
	{
		cout << "Number " << i << ": " ;
		cin >> Number;

		if(i == 0)
		{
			Total = Total + Number;
		}

		else
		{
			Total = Total - Number;
		}
	}

	cout << "The total is " << Total << endl;
	Total = 0;
	break;

	case 3:
	cout << "Enter in how many numbers you want to use" << endl;
	cin >> Amount;

	for(int i = 0; i < Amount; i++)
	{
		cout << "Number " << i << ": " ;
		cin >> Number;

		if(i == 0)
		{
			Total = Total + Number;
		}

		else
		{
			Total = Total * Number;
		}
	}
	cout << "The answer is " << Total << endl;
    Total = 0;
	break;

	case 4:
	cout << "Enter in how many numbers you want to use" << endl;
	cin >> Amount;

	for(int i = 0; i < Amount; i++)
	{
		cout << "Number " << i << ": " ;
		cin >> Number;

		if(i == 0)
		{
			Total = Total + Number;
		}

		else
		{
			Total = Total / Number;
		}
	}
	cout << "The total is " << Total << endl;
	Total = 0;
	break;
	case 5:
	cout << "Enter how many numbers you want to find the average of: ";
	cin >> Amount;

	for(int i = 0; i < Amount; i++)
	{
	    cout << "Number " << i << ": " ;
		cin >> Number;

		Total = Number + Total;
	}
	answertoaverage = Total / Amount;
	cout << "The average of those " << Amount << " numbers is " << answertoaverage << endl;
	answertoaverage = 0;
}
	cout << "enter 1 to restart or 2 to quit: ";
	cin >> restart;
	if(restart == 1){
    }else{
        break;
    }

    }

    cin.get();
	return 0;
}
ResidentBiscuit (4459)
Well, you're missing a return statement. You gave your function a type other than void, therefore you have to return the corresponding type, which for you is int.
moot1 (259)
i re did it but it still doesnt work?
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
 
#include <iostream>
#include <cstdlib>

using namespace std;

void add()
{
    int Total = 0;
	int Amount;
	int Number;
	int whatoperation;
	int answertoaverage;
	int restart;

    cout << "Enter in how many numbers you want to use" << endl;
	cin >> Amount;

	for(int i = 0; i < Amount; i++)   // Keeps looping until i == Amount
	{
		cout << "Number " << i << ": " ;  // Shows user what number they are entering
		cin >> Number;

		Total = Number + Total;  // Adds number to total
	}

	cout << "The total is " << Total << endl;  // Prints out total value when loop has finished
	Total = 0;  // resets total back to zero

	return;
}

int main()
{
    int Total = 0;
	int Amount;
	int Number;
	int whatoperation;
	int answertoaverage;
	int restart;

	while (restart) {
    system("CLS");

	cout << "Here are your choices(enter the number before the operation)" << endl << endl;
	cout << "1.Addition" << endl;
	cout << "2.Subtraction" << endl;
	cout << "3.Multiplication" << endl;
	cout << "4.Division" << endl;
	cout << "5.Average Calculator" << endl;

	cin >> whatoperation;

	system("CLS");

	switch(whatoperation){
    case 1:
    int add();
	break;

	case 2:
	cout << "Enter in how many numbers you want to use" << endl;
	cin >> Amount;

	for(int i = 0; i < Amount; i++)
	{
		cout << "Number " << i << ": " ;
		cin >> Number;

		if(i == 0)
		{
			Total = Total + Number;
		}

		else
		{
			Total = Total - Number;
		}
	}

	cout << "The total is " << Total << endl;
	Total = 0;
	break;

	case 3:
	cout << "Enter in how many numbers you want to use" << endl;
	cin >> Amount;

	for(int i = 0; i < Amount; i++)
	{
		cout << "Number " << i << ": " ;
		cin >> Number;

		if(i == 0)
		{
			Total = Total + Number;
		}

		else
		{
			Total = Total * Number;
		}
	}
	cout << "The answer is " << Total << endl;
    Total = 0;
	break;

	case 4:
	cout << "Enter in how many numbers you want to use" << endl;
	cin >> Amount;

	for(int i = 0; i < Amount; i++)
	{
		cout << "Number " << i << ": " ;
		cin >> Number;

		if(i == 0)
		{
			Total = Total + Number;
		}

		else
		{
			Total = Total / Number;
		}
	}
	cout << "The total is " << Total << endl;
	Total = 0;
	break;
	case 5:
	cout << "Enter how many numbers you want to find the average of: ";
	cin >> Amount;

	for(int i = 0; i < Amount; i++)
	{
	    cout << "Number " << i << ": " ;
		cin >> Number;

		Total = Number + Total;
	}
	answertoaverage = Total / Amount;
	cout << "The average of those " << Amount << " numbers is " << answertoaverage << endl;
	answertoaverage = 0;
}
	cout << "enter 1 to restart or 2 to quit: ";
	cin >> restart;
	if(restart == 1){
    }else{
        break;
    }

    }

    cin.get();
	return 0;
}
ResidentBiscuit (4459)
Lol well now you have a void function, with a return -_-

http://www.cplusplus.com/doc/tutorial/functions/

Read all of this. Hopefully that will help
Topic archived. No new replies allowed.