is this the best way to do this

[markkirby]

Hi
Im new to programing and am not taking a course or any thing just using this site so I would be very great full if someone would tell me if this example is the best syntax for this situation


#include <iostream>
#include <string>
using namespace std;
int main()
{

int x = 1;
string y;

while (x == 1)
{
{ cout << "hello press start to play q to quit" << endl;
loop:
getline (cin, y);}

if (y == "s")
{x = x + 1;}

else if (y == "q" )
{ x = x+2;}

else
{cout << "Invalid input" << endl;
goto loop;}
}
while (x == 2)
{cout << "starting..." << endl;
return 0;}

while (x == 3)

{cout << "goodbye..." << endl;
return 0;}
}

[ls909]

This post should have been deleted.

[LB]

I did some indentation fixing for you:

#include <iostream>
#include <string>
using namespace std;

int main() 
{
	int x = 1;
	string y;

	while (x == 1)
	{
		{
			cout << "hello press start to play q to quit" << endl; 
		loop:
			getline (cin, y);}

			if (y == "s")
			{
				x = x + 1;
			}
			else if (y == "q" )
			{
				x = x+2;
			}
			else
			{
				cout << "Invalid input" << endl;
				goto loop;
			}
		}
		while (x == 2)
		{
			cout << "starting..." << endl;
			return 0;
		}
		while (x == 3)
		{
			cout << "goodbye..." << endl;
			return 0;
		} 
	}

As you can see, it is MUCH easier to read, and you can clearly see that you are missing the closing brace for main. Also, I am curious why you used a nameless scope on line 12?

[markkirby]

Im sorry when I was pasting it in I lost the last brace I know it works but just wanted to know if it was writen properly

[z05DSL3A]

The use of goto is deprecated.

No it's not. It is just discouraged.

[strongdrink]

Nameless scopes are not commonly used. The only use I've seen them in is when a block of code only needs to be used once, the variable declarations are used once, and when it pulls data from variables outside of the scope. (a function is normally used for this, but there are exceptions)

Also, please use better titles :)

[z05DSL3A]

ls909,

Don't be so hard on yourself. Don't be afraid to contribute and don't take offence if someone corrects you. It's all good.

[LB]

@strongdrink: I use nameless scopes when I need unconditional code to execute with temporary stack variables. Since he is not making any temporary stack variables it seems odd :\ unless he just wanted to keep the "loop" label in its own scope?

[Moschops]

ls909, him say:

You could use something like this:

while (true)
{
     cout << "Hello, press 's' to play, or 'q' to quit." << endl;
     cin >> y; // Why use getline()?
     cin.ignore(); // Clear the input buffer.
     if(y == "s")
     {
          x = x + 1;
     }
     if(y == "q")
     {
          x = x + 2;
     }
     if(y != "s" || "q")
     {
          continue;
     }
     else
     {
          break;
     }
}

But he became very shy :(

[strongdrink]

@LB yeah, pretty much what I was trying to say..