change conversion...isn't working completly correct

[Lacy]

//So I'm writing this program that converts change into smaller denominations. //For example .97 would be 3 quarters, 2 dimes, 0 nickels, with 2 remaining. //The program compiles and runs but it's not the completely correct output. Can //anyone help.
//Converts change into small denominations.

#include "stdafx.h"
#include<iostream>
#include<conio.h>
using namespace std;

int main()
{
int quarters = .25;
int dimes = .10;
int nickels = .05;
int pennies = .01;
double usersMoney;
cout << "Enter a decimal for change amount";
cin >> usersMoney;
int amount = (usersMoney / .25);
int remaining = usersMoney - (amount * .25);
int amount1 = (remaining / .10);
int remaining1 = remaining - (amount1 * .10);
int amount2 = (remaining1 / .05);
int remaining2 = remaining1 - (amount2 * .05);
cout << usersMoney << " converted is: " << amount << " quarters " << amount1 << " dimes " << amount2 << " nickels. With " << remaining2 << " remaining." << endl;
getch();
return 0;
}

[eypros]

You are declaring too many variables I think.

Anyway your big problem (there are other problems also but let's focus on the one bothering you) is that you declare remaining as int. So you miss all the accuracy you can get. Declare them as double. This applies to all your remainingN variables

Please use code brackets also. And read (if you haven't)
http://www.cplusplus.com/forum/beginner/1/

[Stewbond]

Integers don't take decimals. So when you set: int quarters = .25, you are really setting it to 0 because the last bit is truncated (as per the warning you are probably getting). If you say amount * .25 you are dividing by 4 and then you lose the remainder.

Instead of using double as suggested above. I suggest using ints so you can take advantage of integer division which would be useful here.

Convert a dollar decimal value to an integer "cents" value by multiplying by 100. Also, instead of using remaining, remaining1, remaining2, just use the %= operator to reduce the value by the amount that you are allocating to a higher denomination.

Finally, rename amount, amount1 and amount2. These are not descriptive and will confuse you when you look at this later. Just call them quarters, dimes and nickels. I see that you already have something with that name, but you don't do anything with them, so just delete them.

Example:

int main()
{
	float dollars;

	cout << "Enter an amount to divide (eg. 13.75)" << endl;
	cin >> dollars; //Get your change value

	int cents = dollars*100; //Convert it to an integer number of cents.  
//	int cents = (int)(dollars * 100.); <-- same as line above, but no warning!

	int twenties = cents / 2000; // Integer division (how many times can cents be divided by 2000?)
	cents = cents % 2000; // Modulus (if I divide cents/2000, what will my remainder be? Set my new value to that)

	int tens = cents / 1000;	//Now cents is lower than 2000, how many 10s can we get with it?	
	cents %= 1000; // This is the same as cents = cents % 1000;

	int fives = cents / 500;
	cents %= 500;

	int ones = cents / 100;
	cents %= 100;

	int quarters = cents / 25;
	cents %= 25;

	int dimes = cents / 10;
	cents %= 10;

	int nickles = cents / 5;
	cents %= 5;

	int pennies = cents; // What's left over!

	cout << dollars		<< "\t Dollars becomes:" << endl;
	cout << twenties	<< "\tTwenties" << endl;
	cout << tens		<< "\tTens" << endl;
	cout << fives		<< "\tFives" << endl;
	cout << ones		<< "\tOnes" << endl;
	cout << quarters	<< "\tQuarters" << endl;
	cout << dimes		<< "\tDimes" << endl;
	cout << nickles		<< "\tNickels" << endl;
	cout << pennies		<< "\tPennies\n" << endl;

	cin.get();

	return 0;
}