Where did my lines go?

[shooninjo]

Hello. I am currently searching for two missing lines. The code is this:

#include <iostream>
#include <vector>
#include "conio.h"
#include "windows.h"



using namespace std;

typedef struct _Rect{
int left;
int top;
int right;
int bottom;

}Rect;

void gotoxy(int x, int y)
 {
   static HANDLE hStdout = NULL;
   COORD coord;

   coord.X = x;
   coord.Y = y;

   if(!hStdout)
   {
     hStdout = GetStdHandle(STD_OUTPUT_HANDLE);
   }

   SetConsoleCursorPosition(hStdout,coord);
 }


void DrawRect(Rect rect){

int x1=rect.left, x2=rect.right, y1=rect.top, y2=rect.bottom;
int i;

//horisontella sidor
gotoxy(x1+1, y1); for(i=0; i<x2-x1; i++); cout<<(char)255;
gotoxy(x1+1, y2); for(i=0; i<x2-x1; i++); cout<<(char)255;

//vertikala sidor

for(i=0; i<y2-y1; i++){gotoxy(x1, y1+i); cout<<(char)179;}
for(i=0; i<y2-y1; i++){gotoxy(x2, y1+i); cout<<(char)179;}


gotoxy(x1, y1); cout<< (char)218; //övre vänster hörn
gotoxy(x2, y1); cout<< (char)191; //övre högra hörn
gotoxy(x1, y2); cout<< (char)192; //nedre vänsta hörn
gotoxy(x2, y2); cout<< (char)217; //nedre högra hörn


}

int main()
{
    Rect aRect={30, 3, 49, 14};
    //int width=aRect.right-aRect.left, heigth=aRect.bottom-aRect.top;

    DrawRect(aRect);

    return 0;
}

However only the vertical lines draws, what am I doing wrong?

Thanks in advance!

[whitenite1]

@shooninjo

Well, for one, char(255) is nothing that's printable. You needed char(196). Plus, the for loop is never incremented, a 1 was added, but that's all. It should have been increased by i, like the verticals. And lastly, for the horizontal line loops, you had a semi-colon after the for statement, which shouldn't be there. Here is your program, with corrections.

#include <iostream>
#include <vector>
#include "conio.h"
#include "windows.h"



using namespace std;

typedef struct _Rect{
	int left;
	int top;
	int right;
	int bottom;

}Rect;

void gotoxy(int x, int y)
{
	static HANDLE hStdout = NULL;
	COORD coord;

	coord.X = x;
	coord.Y = y;

	if(!hStdout)
	{
		hStdout = GetStdHandle(STD_OUTPUT_HANDLE);
	}

	SetConsoleCursorPosition(hStdout,coord);
}


void DrawRect(Rect rect)
{

	int x1=rect.left, x2=rect.right, y1=rect.top, y2=rect.bottom;
	int i;

	//horisontella sidor
	
	for(i=0; i<x2-x1; i++)
	{
		gotoxy(x1+i, y1);
		cout<<(char)196;
	}
	
	for(i=0; i<x2-x1; i++)
	{
		gotoxy(x1+i, y2);
		cout<<(char)196;
	}

	//vertikala sidor

	for(i=0; i<y2-y1; i++)
	{
		gotoxy(x1, y1+i);
		cout<<(char)179;
	}
	for(i=0; i<y2-y1; i++)
	{
		gotoxy(x2, y1+i);
		cout<<(char)179;
	}


	gotoxy(x1, y1);
	cout<< (char)218; //övre vänster hörn
	gotoxy(x2, y1);
	cout<< (char)191; //övre högra hörn
	gotoxy(x1, y2); 
	cout<< (char)192; //nedre vänsta hörn
	gotoxy(x2, y2);
	cout<< (char)217; //nedre högra hörn
}

int main()
{
	Rect aRect={30, 3, 49, 14};
	//int width=aRect.right-aRect.left, heigth=aRect.bottom-aRect.top;

	DrawRect(aRect);
	cout << endl << endl;

	return 0;
}

[shooninjo]

Thanks :)