with sort algorithm??

could you tell me how to change this with sort algorithm??


void insertName(vector<string>& x, string n){ 
   if( n > x[x.size()-1] ) x.push_back(n);
   else { 
     int i =0;
     while( n > x[i] )i++;   
     x.insert(x.begin()+i,n);
   }
}

here is my whole code:

#include <iostream>
#include <vector>
#include <string>
#include <fstream>
using namespace std;
void fillVector(vector<string>& );
void printVector(vector<string> );
void insertName(vector<string>& , string );
int main(){ 
   vector<string> N;
   fillVector(N);
   printVector(N);
   cout<<"Enter name to insert : ";
   string name;
   cin>>name;
   insertName(N, name);
   printVector(N);
   return 0; 
}
void printVector(vector<string> x){
   for(int i=0; i<x.size(); i++)
       cout<<x[i]<<' ';
   cout<<endl;     
}
void fillVector(vector<string>& x){
   string name;
   ifstream fin("names.txt");
   while( fin>>name )		
     x.push_back(name);    
}
void insertName(vector<string>& x, string n){ 
   if( n > x[x.size()-1] ) x.push_back(n);
   else { 
     int i =0;
     while( n > x[i] )i++;   
     x.insert(x.begin()+i,n);
   }
}

Last edited on

Galik (2254)

I think your first problem is if the vector is empty to avoid a seg-fault:

void insertName(vector<string>& x, string n){ 
   if( n > x[x.size()-1] ) x.push_back(n); // what if x is empty?
   else { 
     int i =0;
     while( n > x[i] )i++;   // should this be while(n < x[i]) ??
     x.insert(x.begin()+i,n);
   }
}

Also instead of x[x.size()-1] you can use x.back().

lena123 (9)

no, i know that x isn't empty, i put values from file names.txt, witch is not empty and names in this file are ordered by alphabet. i want to put one another name from keyboard so the order not to abolish, and to do this with sort algorithm and not so, as it's shown above.

Last edited on

vetal10 (4)

what do you need the sort algorithm for??as much as i can see you don't sort your vector, you just add a string.
and instead

1
2
3

 int i =0;
     while( n > x[i] )i++;   // should this be while(n < x[i]) ??
     x.insert(x.begin()+i,n);

you can use

x.insert(find_if(x.begin(),x.end(),bind2nd(cmp,n)),n);
...
bool cmp(const string& s1,const string& s2){
return s2>s1;
}

Galik (2254)

lena123 wrote:
no, i know that x isn't empty,

When writing functions you can't make those kind of assumptions. It may be true in your current example, but it won't necessarily be true when you come to use your function in the future, or if someone else uses your function.

Last edited on

Topic archived. No new replies allowed.

C++

Forum

with sort algorithm??