Human Error

[Da0omph]

Somewhere in this code, I'm have an error in my logic.
As you can see in the beginning of the do while statement, I want to find out the length of BiNum, line 58. If you in fact you input a 16 character string, for example 11111111 11111111, I want to simply output 17, including the space. However, I get the output of 8. Can anyone tell where my code when wrong?

I apologize. Please ignore the system("pause"), I assure you, they will not be in the finished program. Thank you.

#include <iostream>
#include <string>
#include <string>
#include "windows.h"
#include <tchar.h>

void clearScreen()
{
  HANDLE output_handle = GetStdHandle(STD_OUTPUT_HANDLE);
  DWORD bytes_write, size;
  COORD coord = {0, 0};
  CONSOLE_SCREEN_BUFFER_INFO csbi;

  GetConsoleScreenBufferInfo(output_handle, &csbi);

  size = csbi.dwSize.X * csbi.dwSize.Y;

  FillConsoleOutputCharacter(output_handle, ' ', size, coord, &bytes_write);
  SetConsoleCursorPosition(output_handle, coord);
}

int biToDec(std::string a)
{
	int temp = 0;

	for(unsigned int i = 0; i < 8; i++)
	{
		if(temp > 0 ||a[i] == '1')
		{	
			switch(a[i])
			{
				case '0':
				temp *= 2;
				break;

				case '1':
				temp = (temp * 2) + 1;
				break;
			}
		}
	}
	return temp;
}

int main()
{
    SetConsoleTitle(_T( "Binary Converter by: Robert Cruz" ));
    char cChar;

    do
	{
        std::string biNum;
        bool biCorrect = false;

        std::cout << "Enter an 8 bit binary string: ";
        std::cin >> biNum;

		std::cout << biNum.length();
		system("pause");

		for(unsigned int i = 0; i < biNum.length(); i++)
		{
				if(biNum.substr(i, 1) == " ")
					std::cout << i << " ";
		}

		system("pause");


        while(!(biCorrect))
        {
			// Program can do calculations like 11; 11 = 3
            while(biNum.length() < 8)
			{
				// Inserts 0 in front of string till it has a total 8 character in order to read. 
				for(unsigned int i = 0; i < 8 - biNum.length(); i++)
					biNum.insert(0, 1, '0');
			}

			// Checks to see if the string is a multiple of 8, in which case can be calculation.
            while(biNum.length() % 8 != 0)
            {
                std::cout << "Please enter an 8 bit binary string consisting only of 0s and 1s.";
                std::cin.ignore();
                std::cin.get();
                clearScreen();
                std::cout << "Enter an 8 bit binary string: "; std::cin >> biNum;

            }

			for(unsigned int i = 0; i < biNum.length(); i++)
            {
                if(biNum[i] == '0' || biNum[i] == '1')
                    biCorrect = true;
                else
                {
                    biCorrect = false; i = 0;
                    std::cout << "Please enter an 8 bit binary string consisting only of 0s and 1s.";
                    std::cin.ignore();
                    std::cin.get();
                    clearScreen();
                    std::cout << "Enter an 8 bit binary string: "; std::cin >> biNum;
                    while(biNum.length() < 8)
                    {
                        for(unsigned int i = 0; i < 8 - biNum.length(); i++)
                        biNum.insert(0, 1, '0');
                    }
                }
            }
		}
		
		
		// Output
		if(biNum.length() == 8)
		{
				std::cout << "The decimal value of your binary string is: " << biToDec(biNum) << std::endl;
				std::cout << "The ASCII value of your binary string is: " << static_cast<char>(biToDec(biNum));
		}
		else
		{

			bool finish = false;
			unsigned int j = 0;
			std::string sentence;
			while(!finish)
			{

				std::string tempStr;
				while(j < biNum.length())
				{
					tempStr.assign(biNum, j, 8);
					j = j + 8;

					if(j == biNum.length())
					finish = true;
					break;
				}


				//std::cout << "The decimal value of your binary string is: " << biToDec(tempStr) << std::endl;
				//std::cout << "The ASCII value of your binary string is: " << static_cast<char>(biToDec(tempStr)) << std::endl << std::endl;
				sentence += static_cast<char>(biToDec(tempStr));
			}

			std::cout << "Your string read's: " << sentence;
		}

        std::cout << "\nDo you want to continue using this program? <y/n>: "; std::cin >> cChar;
        std::cout << std::endl;
    } while(cChar == 'y' || cChar == 'Y');
    return 0;
}

[Da0omph]

I solved my problem myself. However, I'm not entirely sure why it solves it.

I added:
std::getline(cin, biNum);
In place of line 58. Can anyone tell me why?

[Dacster13]

cin reads up to the first space character ' ' or newline character '\n' which ever comes first. So if there's a space in there somewhere it will only read the characters that comes before the space.

On the other hand getline reads everything until it encounters a newline character '\n'. So it would read everything including the space. I hope that explains why it works. :)

[Da0omph]

Thank you for the explanation. I got that part working correctly; however, when it runs the second time of the do while, it doesn't ask for user input. Why is that so?

[Da0omph]

Again, I solved my problem. Thanks everyone for your help.