C++

Forum

 
program.exe has stopped working

Turco08 (2)
As with anyone else posting problems here, I am new to C++, and programming. I am currently in a logics class that is not language specific and use the RAPTOR flowchart program. I created a program and felt like trying to do the C++ code. I am using Code::Blocks and using this site as well as others as tutorials to help. I have been slowly writing parts of the program and testing it to make sure it is right. Currently though I am having an issue finding what is going wrong. The Build returns no error in the code, but when I run the program, it doesn't work. This is the source code:

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
 
#include <iostream>
#include <cstdlib>
#include <string>
#include <time.h>
using namespace std;

int main ()
{
    int card[10], number[10];
    string suit[10];
    int k;
    srand(time(0));
//Draw each card. RNG 1-52 with IF statements to prevent duplicates
    for (k=1;k<11;k++){
        card[k] = rand()%52+1;
        switch (k){
           case 1:
           break;
           case 2:
                   label2:
                   if (card[k]==card[1]){
                       card[k] = rand()%52+1;
                       goto label2;
                   }
                   break;
           case 3:
                   label3:
                   if (card[k]==card[1]||card[k]==card[2]){
                       card[k] = rand()%52+1;
                       goto label3;
                   }
                   break;
           case 4:
                   label4:
                   if (card[k]==card[1]||card[k]==card[2]||card[k]==card[3]){
                       card[k] = rand()%52+1;
                       goto label4;
                   }
                   break;
           case 5:
                   label5:
                   if (card[k]==card[1]||card[k]==card[2]||card[k]==card[3]||card[k]==card[4]){
                       card[k] = rand()%52+1;
                       goto label5;
                   }
                   break;
           case 6:
                   label6:
                   if (card[k]==card[1]||card[k]==card[2]||card[k]==card[3]||card[k]==card[4]||card[k]==card[5]){
                       card[k] = rand()%52+1;
                       goto label6;
                   }
                   break;
           case 7:
                   label7:
                   if (card[k]==card[1]||card[k]==card[2]||card[k]==card[3]||card[k]==card[4]||card[k]==card[5]||card[k]==card[6]){
                       card[k] = rand()%52+1;
                       goto label7;
                   }
                   break;
           case 8:
                   label8:
                   if (card[k]==card[1]||card[k]==card[2]||card[k]==card[3]||card[k]==card[4]||card[k]==card[5]||card[k]==card[6]
                   ||card[k]==card[7]){
                       card[k] = rand()%52+1;
                       goto label8;
                   }
                   break;
           case 9:
                   label9:
                   if (card[k]==card[1]||card[k]==card[2]||card[k]==card[3]||card[k]==card[4]||card[k]==card[5]||card[k]==card[6]
                   ||card[k]==card[7]||card[k]==card[8]){
                       card[k] = rand()%52+1;
                       goto label9;
                 }
                   break;
           case 10:
                   label10:
                   if (card[k]==card[1]||card[k]==card[2]||card[k]==card[3]||card[k]==card[4]||card[k]==card[5]||card[k]==card[6]
                   ||card[k]==card[7]||card[k]==card[8]||card[k]==card[9]){
                       card[k] = rand()%52+1;
                       goto label10;
                   }
                   break;
        }                                          //end switch
    }                                              //end for
        //Set each card's number and suit
    for (k=1;k<11;k++){
        if (card[k]<=13){
            number[k]=card[k];
            suit[k]="H";
        }
        else if (card[k]<=26){
            number[k]=card[k]-13;
            suit[k]="D";
        }
        else if (card[k]<=39){
            number[k]=card[k]-26;
            suit[k]="S";
        }
        else {
            number[k]=card[k]-39;
            suit[k]="C";
            }
    }                                               //end for
    for (k=1;k<11;k++){
        cout << k <<". " <<card[k] <<": " <<number[k] <<" of " <<suit[k];

    }
    cin.get();
}                                                //end main()


The program window returns :

Process returned -1073741819 (0xC0000005) execution time : 2.990 s

Before adding the card's number and suit, testing went fine and I was able to display 10 random numbers ("cards"), so I am assuming the error is somewhere in the second half, but can't be sure.

Also please forgive any crude coding. I've only been at this for 2 days.
Last edited on
Breadman (111)
Just change every for (k=1;k<11;k++) into
for (k=0;k<10;k++) Because arrays start from index 0, not 1.

Also about the crude coding if possible dont use gotos. They are evil and will eat you.
velcro (31)
I'm way less versed than you are, surmising by your code, but we have already studied switch statements. Every one we had to write included the default: case at the end. Hope that helps.
eypros (329)
default: is not necessary for a switch loop to work fine. It just defines a case which is executed when no other case is valid. There are situation where the uncatched cases should not be treated so default: is unnecessary there.
velcro (31)
@eypros
Thanks for teaching me about default within switch. I'm very new to C++ and just offer what I've learned in this first class I'm taking this semester.
Turco08 (2)
@Breadman

gaah....thank you! That is the problem with having only used RAPTOR flowcharts. RAPTOR program is highly simplified and it starts arrays at 1 instead of 0.

As for the goto, I thought about trying a while loop last night.
Topic archived. No new replies allowed.