Where is the problem??!!

[detroit]

I have no errors but it wont compile, when i try to bebug it , it takes me to an unfamiliar place.

Please take a look and see if you can help me out...

Thanks in advance

#include <iostream>
#include <string>
#include <conio.h>
using namespace std;

class Pet
{
private:
	char* name;
	int age;
	double weight;
public:
	Pet(){ name = NULL; age = 0; weight = 0.0;}// default constructor
	Pet(const char*, int, double); // argument constructor
	Pet(const Pet&);
	~Pet();
	Pet& operator = (Pet);
	//void getName()const; // read the name
	//void getAge()const; // read the age
	//void getWeight()const; // read weight
	void getInfo() const;
	void setName(char*);// set the name
	void setAge(int); // set the age
	void setWeight(double); // set the weight
	string getLifespan();// return a string
};
Pet::Pet(const char* n, int a, double w)
{
	int length = strlen(n)+1;
	name = new char[length];
	strcpy_s(name, length, n);

	age = a;
	weight = w;
	
}
Pet::Pet(const Pet& otherPet)
{
	int length = strlen( otherPet.name )+1;
	name = new char[strlen(otherPet.name)+1];
	strcpy_s(name, length, otherPet.name);		

	age = otherPet.age;
	weight = otherPet.weight;
}
Pet::~Pet()
{
	delete[] name;
}
Pet& Pet::operator =(Pet otherPet)
{
	delete[]name;

	int length = strlen( otherPet.name )+1;
	name = new char[strlen(otherPet.name)+1];
	strcpy_s(name, length, otherPet.name);

	age = otherPet.age;
	weight = otherPet.weight;

	return *this;	
}
void Pet::setName(char * n)
{
	delete[] name;

	int length = strlen(n) + 1;
	name = new char[length];
	strcpy_s(name, length, n);
}
void Pet::setAge(int a)
{
	age = a;
}
void Pet::setWeight(double w)
{
	weight = w;
}

void Pet::getInfo() const
{
	if (name != NULL)
	{
		cout <<"Pet Name: " << name << endl;
	}
	cout <<"Pet Age: " << age << endl;
	cout <<"Pet Weight: " << weight << endl;

}

int main()
{
	Pet p1;
	Pet p2("Sparky", 1, 17.2);
	Pet p3(p1);
	Pet p4 = p1;

	cout <<"p1 is : ";  p1.getInfo(); cout << endl;
	cout <<"p2 is : ";  p2.getInfo(); cout << endl;
	cout <<"p3 is : ";  p3.getInfo(); cout << endl;
	cout <<"p4 is : ";  p4.getInfo(); cout << endl;

	p1.setName("yayo");

	cout <<"p1 is : ";  p1.getInfo(); cout << endl;
	cout <<"p2 is : ";  p2.getInfo(); cout << endl;
	cout <<"p3 is : ";  p3.getInfo(); cout << endl;
	cout <<"p4 is : ";  p4.getInfo(); cout << endl;

	p2 = p1;

	cout <<"p2 is: "; p2.getInfo(); 

	_getch();
	return 0;
}

[Moschops]

If there are no errors, what reason does the compiler give for not compiling?

[detroit]

A microsoft windows pops out, saynig that project.exe has stoped working.
A problem caused the program to stop working correctly.

It is asking for Debug, and when I try to debug it doesn't take me to my code but to some other code that I am not familiar with.

The file name for that unfamiliar page is strken.asm (I am assuming it is in relation to my strlen in my code)
But I do not see what I did wrong.....

Very confusing,

I hope I am making some sense...

[Moschops]

When you get to this:

Pet p4 = p1;

you then go to this:

int length = strlen( otherPet.name )+1;

but otherPet.name is a null pointer, so strlen tries to derefernce a null pointer, so there is a segFault.

[detroit]

Thanks for pointing that out Moschops
I can't belive I missed that,

I also made the adjustment on

p3(p2) // this was wrong as well

But I am getting an error still:

The error window says:

Debug Error.

HEAP CORRUPTION DETECTED: after normal block(#150)at 0x00781780

CTR detected that the application wrote to memory after end of heap buffer.

Again when I try to debug this it takes me to an unfamiliar window (dbgheap.c)

I have no idea what this really means and where the mistake might be???

Please any suggesiton or help is appreciated

Thanks for the help and time...

[detroit]

I figured it out coooool

Thanks again for your help Moschops

[Moschops]

Stick this:

if (otherPet.name == 0) std::cout << "About to deref null pointer" << std::endl;

right after

Pet::Pet(const Pet& otherPet)
{

and see if it's output just before it all goes wrong.

Essentially, you're passing a bad pointer (or good pointer and bad amount of stuff to read/write) to one of the library functions. Hence the crash happens inside that library function.

I can't replicate your code exactly as you used some Win specific code, and I had to swap out strcpy_s with strncpy.

[detroit]

Yes it did print it out right before the window poped op.

That brings a more light to the problem that I had

I used strcpy_s beacuse it is the safe version of visual studio

Thanks again.