C++

Forum

 
Mode Program Help.

biplav17 (159)
I think everything is right but it is still not working. Wonder why. Here is my function. Help please. And I am not allowed to use pointer on this. SO just array and loops.

int mode_calculator(int arrayname[] , int arraylength)
{
int count[arraylength];
int holder;
for (int m=0 ; m < arraylength; m++)
{
for (int n = 0 ; n <arraylength ; n++)
{
if (arrayname[m] = arrayname[n])
{
count[m]++;
}

}
if (count [m] >= count [m-1])
{
holder = arrayname[m];
}

}

return holder;
}

ne555 (10692)
[code] "Please use code tags" [/code]

int count[arraylength]; That's illegal, uninitialized and unnecessary (you are using just 2 values)
if (arrayname[m] = arrayname[n]) That's assignment, == is comparison
biplav17 (159)
bump!
Disch (13742)
Doesn't ne555's reply answer your question?
biplav17 (159)
no it still does not work :(


i have modified it this way

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
 
int mode_calculator(int arrayname[] , int arraylength)
{
      
    int holder, count, repeat;
    count =0;
    repeat=0;
    holder =0;
    
    for (int m=0 ; m < arraylength; m++)
    {
        for (int n = 0 ; n < arraylength ; n++)
        {
            if (arrayname[m] == arrayname[n])
            {
                 count++;         
            }
                          
        }   
        
        if (count  >  repeat)
        {
                   holder = m;
                   repeat = count;
                   count = 0;
        }
        
        
         
                                
    }  
    return arrayname[holder];      
        
    
}
Last edited on
Litaken (7)
Just a sidenote, you are searching for equations in a simple 1D array right? it increases the "count" variable when a value gets compared to itself (when m==n ), i guess you dont need that.
Oh, now i see what this code tryes to do. You definitely need the thing i mentioned above then. Btw whats the exact problem? Cant compile or wrong output?
biplav17 (159)
Ok. SO it is comparing the value of the array to all other value of the array using other loop. And counting it.

Problem is bad output. How much i try it does not work. :(
biplav17 (159)
ok. so now i got this. and it works for some time and it does not. I am pasting the full program but the mode function is the top one. 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
 
#include <cstdlib>
#include <iostream>
#include <string>

using namespace std;


int mode_calculator(int arrayname[] , int arraylength)
{
      
    int holder, count, repeat;
    count =0;
    repeat=0;
    holder =0;
    
    for (int m=0 ; m < arraylength; m++)
    {
        for (int n = 0 ; n < arraylength ; n++)
        {
            if (arrayname[m] == arrayname[n])
            {
                 count++;         
            }
                          
        }   
        
        if (count  >=  repeat)
        {
                   holder = m;
                   repeat = count;
                   count = 0;
        }
        
        
         
                                
    }  
    return arrayname[holder];      
        
    
}


int mean_calculator(int n[], int k)
{
    int calculator=0;
    for (int m=0; m < k ; m++)
    {
        calculator= n[m] + calculator;
    }
    int mean = calculator / k;
    return mean;
    
}

void displayarray (int n[], int k)
{
    for (int  m=0; m < k ; m++)
    {
        cout << n[m] << "," ;
    }
}

int valuechanger (int n[], int k)
{
    int position, changedvalue;
    cout << " which position do you wish to change?" << endl;
    cin >> position;
    cout << "what do you want to chage it to?" << endl;
    cin >> changedvalue;
    n[position] = changedvalue;
    return n[position];
}
   

 

 

int main()
{
    int lengtharray;
    
    cout << "How long do you want your array to be?" << endl;
    
    cin >> lengtharray;
    
    
    int firstarray [lengtharray];
    
    cout << "ok enter your values" << endl;
    
    
   for (int m=0; m < lengtharray ; m++)
    {
        cin >> firstarray[m];
    }
    
    
          
    
    
    cout << "what do you want to do?" << endl;
    
    cout << "1: display your values" << endl;
    
    cout << "2: change your values" <<endl;
    
    cout << "3: Calculate the mean" << endl;
    
    cout << "4: Calculate the mode" << endl;
    
    
    int option;
    
    cin >> option;
    
    if (option ==1)
    {
            displayarray ( firstarray,  lengtharray) ;  
    
            
    }
    
    else if (option==2)
    {
          valuechanger ( firstarray,  lengtharray);
          cout << "Value changed" << endl;
    }
    
    else if (option  == 3)
    {           
        cout << mean_calculator (firstarray , lengtharray);
        cout << "       That is your mean" << endl;
    }
    
    
    else if (option==4)
    {
         
    
        int count;
        count = mode_calculator( firstarray, lengtharray);
        cout << "The mode is  " << count << "." << endl;
        
    } 
    
    else
    {
        cout << "not ready" << endl;
    }   
   
    
    
        
    /*
    
    
    string ans;
    cout << "Do you wish to continue? y/n" << endl;
    cin >> ans;
    while (ans == "y")
    {
           
    cout << "what do you want to do?" << endl;
    
    cout << "1: display your values" << endl;
    
    cout << "2: change your values" <<endl;
    
    cout << "3: Calculate the mean" << endl;
    cout << "4: Calculate the mode" << endl;
    
    
    int option;
    
    cin >> option;
    
    if (option ==1)
    {
               int holder;
            
    }
    
    else if (option==2)
    {
          valuechanger ( firstarray,  lengtharray);
          cout << "Value changed" << endl;
    }
    
    else if (option  == 3)
    {           
        cout << mean_calculator (firstarray , lengtharray);
        cout << "       That is your mean" << endl;
    }
    
    
    else if (option ==4)
    {
        int count;
        count = mode_calculator( firstarray, lengtharray);
        cout << "The mode is  " << count << "." << endl;
        
    } 
    
    
    
    system ("CLS");
    }
    
    
    
    
    
    
    system ("CLS");
    
    */
    
    system("PAUSE");
    return EXIT_SUCCESS;
}
ne555 (10692)
You must reset the count. Always.
biplav17 (159)
I think it works. :) Thanks. I will post again if i find it does not work.
Litaken (7)
It still has the problem i mentioned. You compare each array slot to itself, thus increasing the count variable 1 time, so: 

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
 
for (int m=0 ; m < arraylength; m++)
    {
        for (int n = 0 ; n < arraylength ; n++)
        {
            if (  <<<< (n!=m) >>>> && arrayname[m] == arrayname[n])
            {
                 count++;         
            }
                          
        }   
        
        if (count  >  repeat)
        {
                   holder = m;
                   repeat = count;
                   count = 0;
        }
        
        
         
                                
    }
biplav17 (159)
i changed that as well thanks
Topic archived. No new replies allowed.