Need Help

[Tingting Xu]

Hey guys, I have a piece of code to reverse a null-terminated string here.

#include "stdafx.h"
#include "conio.h"
#include "stdio.h"
#include <iostream>
using namespace std;

void reverse(char *str){
	char *end = str;
	char tmp;
	if(str){
		while(*end){     //find end of the string
			++end;
		}
		--end;           //set one char back, since last char is null
		
		while(str < end){
			tmp = *str;
			*str++ = *end;
			*end-- = tmp;
		}
	}
}

void main(){
	char *myChar = "abcdefg";
	reverse(myChar);
	cout << myChar << endl;
	_getch();
}

There always is error at "*str++ = *end;".
I don't know why.

Thanks so much.

[EricDu]

I think the problem is in line below, you are trying to modify a piece of read only memory.
char *myChar = "abcdefg";

Let us know if you don't know how to fix it.