Hey ..could u plz check wts wrong with my program

[eng soso]

im studying data structuer using c++ in my 1st year
i wrote a c++ programme using class called vector for hangling n-dimrnsional vector..
but i had errors when compiling i don't know why & whats the right solution

#include<iostream>
#include<math.h>
using namespace std;

class vector {

private:int size;
		int index;
		double *array;

public:vector();
	   vector(int n);
	   ~vector();
	   double get_length(int c);
	   void read_vector(int c);
	   void print_vector(int c);
	   vector operator +(vector m);
       vector operator -(vector m);
       double operator *(vector m);
}

/*   constructers   */

vector::vector(){
	size=1;
	index=0;
	array=new double[size];
}



vector::vector(int n){
	size=n;
	index=0;
	array=new double[size];
}  

/*   destructers   */
vector::~vector(){
	delete []array;
}

/*   funcs  */
double vector::get_length(int c){
	double sum=0;
	for(int i=0;i<c;i++)sum+=pow (array[i],2);
	
	cout<<sqrt(sum);
}
void vector::read_vector(int c){cout<<"enter vector elements"<<endl;
	for(int j=0;j<c;j++)cin>>array[j];}


void vector::print_vector(int c){
for(int t=0;t<c;t++)cout<<array[t]<<"\n";
}

vector vector::operator + (vector m){
	vector tmp;
	if(size==m.size){
		for(int ir=0;ir<size;ir++){

			tmp[ir]= array[ir]+m[ir];
			
			return tmp;}
	}
	else cout<<"not possible"<<endl;
}

/*    operaters   */

vector vector::operator-(vector m){
	vector tmp;
	if(size==m.size){
		for(int ir=0;ir<size;ir++){

			tmp[ir]= array[ir]-m[ir];
			
			return tmp;}
	}
	else cout<<"not possible"<<endl;
}



double vector::operator+(vector m){
    double pro,product;
	if(size==m.size){
		for(int ir=0;ir<size;ir++){

			pro = array[ir]*m[ir];product+=pro;}
			
			return product;
	}
	else cout<<"not possible"<<endl;
}

/*    main 4 check  */

int main(){

	vector v1(5);
double w;
	v1.get_length(5);

	vector x1(7);
	vector x2(7);
	x1.read_vector(7);
	x2.read_vector(7);
	vector x3(8);
    vector x4(10),x5(10),x6(10);
    
	x4=x1+x2;
	x5=x1-x2;
    w=x1*x2;

    cout<<w<<endl;
	x1.print_vector(7);
	x5.print_vector(10);

	return 0;
}

[Albatross]

It would help if you told us what are these errors of which you speak.

I would like to warn you that you're coming very close to having a naming conflict with the class "vector" in the C++ standard library. The only thing that's stopping you from having it (as far as I can see) is the fact that you didn't #include <vector>. :/

-Albatross

[eng soso]

thx for replying ..here's the errors

--------------------Configuration: 1 - Win32 Debug--------------------
Compiling...
1.cpp
C:\HW\1.cpp(29) : error C2533: 'vector::vector' : constructors not allowed a return type

C:\HW\1.cpp(64) : error C2264: 'vector::vector' : error in function definition or declaration; function not called

C:\HW\1.cpp(68) : error C2676: binary '[' : 'class vector' does not define this operator or a conversion to a type acceptable to the predefined operator

C:\HW\1.cpp(68) : error C2676: binary '[' : 'class vector' does not define this operator or a conversion to a type acceptable to the predefined operator

C:\HW\1.cpp(78) : error C2264: 'vector::vector' : error in function definition or declaration; function not called

C:\HW\1.cpp(82) : error C2676: binary '[' : 'class vector' does not define this operator or a conversion to a type acceptable to the predefined operator

C:\HW\1.cpp(82) : error C2676: binary '[' : 'class vector' does not define this operator or a conversion to a type acceptable to the predefined operator

C:\HW\1.cpp(91) : error C2556: 'double __thiscall vector::operator +(class vector)' : overloaded function differs only by return type from 'class vector __thiscall vector::operator +(class vector)'

C:\HW\1.cpp(22) : see declaration of '+'

C:\HW\1.cpp(91) : error C2371: '+' : redefinition; different basic types

C:\HW\1.cpp(22) : see declaration of '+'

C:\HW\1.cpp(91) : error C2084: function 'class vector __thiscall vector::operator +(class vector)' already has a body

C:\HW\1.cpp(96) : error C2676: binary '[' : 'class vector' does not define this operator or a conversion to a type acceptable to the predefined operator

C:\HW\1.cpp(118) : error C2264: '+' : error in function definition
or declaration; function not called

C:\HW\1.cpp(118) : error C2088: '+' : illegal for class

Error executing cl.exe.

1.exe - 13 error(s), 0 warning(s)

[Albatross]

Hmm. cl.exe has a funny way of saying "missing a semicolon after the class declaration".

That aside, you forgot to define a few operators. You forgot to define operator[] for use in your operator definitions. Also, do you have a typo on line 90? It looks as though you have one character that's not quite what it's supposed to be. :)

-Albatross

[EricDu]

Your first problem is very simple ;-), class vector is not completed with "};"

[eng soso]

Albatross & EricDu thank u very much ..

i carried out what u noticed me ..but i still have this strange error i don't know wts wrong now
& wt u said about "define operator[] for use in your operator " i did'nt take any thing about that in university ..so i didn't know wt u meant ..

here's the error's i had - !!!!!

--------------------Configuration: 1 - Win32 Debug--------------------
Compiling...
1.cpp
C:\HW\1.cpp(72) : error C2676: binary '[' : 'class vector' does not define this operator or a conversion to a type acceptable to the predefined operator

C:\HW\1.cpp(72) : error C2676: binary '[' : 'class vector' does not define this operator or a conversion to a type acceptable to the predefined operator

C:\HW\1.cpp(86) : error C2676: binary '[' : 'class vector' does not define this operator or a conversion to a type acceptable to the predefined operator

C:\HW\1.cpp(86) : error C2676: binary '[' : 'class vector' does not define this operator or a conversion to a type acceptable to the predefined operator

C:\HW\1.cpp(101) : error C2676: binary '[' : 'class vector' does not define this operator or a conversion to a type acceptable to the predefined operator
Error executing cl.exe.

1.exe - 5 error(s), 0 warning(s)

[EricDu]

The above errors mean that you wrote codes to call function of vector::operator[](), but you don't define it yet. For example in line 72, you wrote "tmp[ir]= array[ir]+m[ir]", both tmp and m are vector type, but vector doesn't have operator[] defined. To define it, just like to define other operators such as operator+, operator- etc.

[eng soso]

ohh ..now i understand that one ..merci eric
:)