Problems with a function

[cascade384]

So I can call the getscore funtion from the main funtion and validate the data, but my problem is getting the main function to call the calcaverage funtion to calculate the validated data. I've been toying around with it all day and the examples from my book have yet to get me anywhere. I would greatly appreciate any tips.

#include <iostream>
using namespace std;

// function prototypes
void getscore(int &);         //: refrence variable
void calcaverage();

int main ()
{	int score1, score2, score3, score4, score5;
	double averagescore;

	cout <<"Please enter five scores.\n\n";
	
	getscore(score1);
    getscore(score2);
    getscore(score3);
    getscore(score4);
    getscore(score5);
	
	averagescore = calcaverage();

	cout <<score1<< " "<<score2<< " "<<score3<< " "<<score4<<" "<<score5<<endl;
	cout <<"The average of the scores is " << averagescore << endl;
system ("pause");

return 0;
}

void calcaverage()
{ 
	int average ;
	average = score / 5;
	return average;
}


void getscore(int &score)
{  
   cin >> score;  
   

   if (score < 1 || score > 100)
   {cout<<"Scores must be between 1 and 100, re-enter the score" << endl;
	cin >> score;
   }
}

[grcunning]

One problem is that each time you call getscore, score gets overwritten with the new value, so that by the time you get to calcaverage, score has the value of score5 instead of the total. You need to keep a running total of score in main.
after you call getscore each time, do something like
totalscore += score;
Or alternatively, you could add a totalscore parameter to getscore(), then you would only have to use the line once.

Another problem is that the calcaverage() function has no idea what score is. Since that variable is declared in main, it goes out of scope when you call getscore. You have to send the function that variable in an argument.

One more thing, you have calcaverage defined as a void function (meaning it doesn't return a value), and then you try to return average. If you want a good average, that variable should also be a double, not an int.

Try fixing some of these problems, then repost the code and we can take a new look at it.

[cascade384]

// 

#include <iostream>
using namespace std;

// function prototypes
void getscore(int &);         //: refrence variable
double calcaverage(double &);

int main ()
{	int score;
	
	double averagescore;
	double totalscore = 0;

	cout <<"Please enter five scores.\n\n";
	
	getscore(score);
	totalscore += score;
	getscore(score);
	totalscore += score;
	getscore(score);
	totalscore += score;
	getscore(score);
	totalscore += score;
	getscore(score);
    totalscore += score;
	
	
	
	averagescore = calcaverage();
	

	cout <<"The total is "<< totalscore << endl;
	cout <<"The average of the scores is " << averagescore << endl;

system ("pause");

return 0;
}
//==========================================================================================//
double calcaverage(double &totalscore)
{	double average ;
	average = totalscore / 5;
	return totalscore;


}

//===========================================================================================//
void getscore(int &score)
{  cin >> score; 
    
  while (score < 1 || score > 100)
   {cout<<"Scores must be between 1 and 100, re-enter the score" << endl;
	cin >> score;
   }
}

The total score accumulator works, but I have the problem of letting calcaverage recongnize it and send data back based on the average equation.

[grcunning]

when you call calcaverage, you want it to return the average, not totalscore

[cascade384]

So is it something kind of like this? I keep getting the error that calcaverage can not take 0 arguments

averagescore = calcaverage();

double calcaverage(double &totalscore)
{	double average ;
	average = totalscore / 5;
	return average;


}

[grcunning]

calcaverage cannot take 0 arguments because the function has one parameter, totalscore.
You need to pass totalscore to the function, then it calculates and returns the average.
average=calcaverage(totalscore);

[cascade384]

Thank you!

[firedraco]

I don't see why you are passing it by reference, you aren't modifying the value inside of the function (although it doesn't really make much difference).

[cascade384]

I'm not sure what you mean. My assignment called for me to inlcude some sort of reference variable in getscore(), so I looked at a group of examples to express what was asked. Firedraco, in what way would you have approached it?