What do you think of my code?
This is my first program that is larger than 1000 lines. It works perfectly, but I'm fairly sure that it could have been written quite a bit better. What mistakes did I make, and what could I generally improve upon? Also, how does it look for Linux compatibility?
The code::blocks project is here: http://www.mediafire.com/?yiae3o8e3jmt693
The code::blocks project is here: http://www.mediafire.com/?yiae3o8e3jmt693
I'll compile it and let you know how it works on my Linux system.
EDIT: It compiles fine, albeit with warnings.
When I try to play it, however, the click system seems to be very glitchy. There are never any problems with it not detecting clicks, but it seems to place clicks far off target. The distance it displaces them varies with each run of the game. I'm not sure whether this is an issue due the SFML packages for Ubuntu or if the click system simply wasn't working yet, but...
You have a few comparisons between signed and unsigned integers on lines 1466 and 1547 in go-functions.cpp. You may wish to fix those.
Finally, although this isn't a much of a coding detail, if the board was larger it would make the game easier to play.
Good work on everything else, though!
-Albatross
EDIT: It compiles fine, albeit with warnings.
When I try to play it, however, the click system seems to be very glitchy. There are never any problems with it not detecting clicks, but it seems to place clicks far off target. The distance it displaces them varies with each run of the game. I'm not sure whether this is an issue due the SFML packages for Ubuntu or if the click system simply wasn't working yet, but...
You have a few comparisons between signed and unsigned integers on lines 1466 and 1547 in go-functions.cpp. You may wish to fix those.
Finally, although this isn't a much of a coding detail, if the board was larger it would make the game easier to play.
Good work on everything else, though!
-Albatross
Last edited on
You can already make the board larger, but that re-sizes the window, which doesn't work for Linux by the sound of it.
EDIT: The clicking problem is most likely the window failing to re-size, I ran into that problem quite a bit while fixing bugs.
EDIT: The clicking problem is most likely the window failing to re-size, I ran into that problem quite a bit while fixing bugs.
Last edited on
Topic archived. No new replies allowed.