Roll the Dice (keep getting 6)

[aspirewire]

I'm trying to simulate rolling a dice, but every time the "random" number is 6. What am I doing wrong? Please help!


This is what I have:

#include <iostream>
#include <cstdlib>
#include <cmath>
#include <ctime>

using namespace std;

int die()
{
return ((rand() % 6) + 1);
}
//////////////////////////////////////////////////////////
int main()
{
int num;
int die;

die=(int)(rand()%6+1);

cout << "What is your prediction? " << endl;
cin >> num;



if ((num >= 1) && (num <= 6)) {
srand((unsigned)time(0));
cout << die << endl;
}


if ((num==die)) {
srand((unsigned)time(0));
cout << die << endl;
cout << "You were correct. " << endl;
}

else if (num > 6 || num < 0) {
cout << "\n Invalid input. \n" << endl;
}

system("PAUSE");
return(0);

} // end main

[Intrexa]

You need to seed the random number generator, the easiest is to use the current time. Place this anywhere before you call rand (only needed once): srand(time()) You have the required headers, time() needs ctime, srand(int) needs cstdlib.

[carebearboy]

I ran the code and kept getting the same result too. I fixed it by adding the command in bold:

srand(time(0));
die=(int)(rand()%6+1);

Works fine now.

p.s Make sure to run it 'before' you roll the dice (create the random number).


* edit *

I had a little time to play around and streamline some stuff in the program if you're interested:

#include <iostream>
#include <cstdlib>
#include <cmath>
#include <ctime>

using namespace std;

int dice()
{
	return ((rand()%6)+1);
}

int main()
{
	int num;
	int die;

	srand(time(0));		// Seed random generator
	die = dice();		// Call dice function
		
	cout << "\nWhat is your prediction? ";
	cin >> num;

	
	if (num==die)
	{
		cout << "\nYou guessed correct!";
	}
	else if (num < 7 && num > 0)
	{
		cout << "\nYou are incorrect.";
	}
	else
	{
		cout << "\nInvalid input.";
	}

	cout << "\nThe number rolled was: " << die << endl;
	
	system("PAUSE");
	return(0);
	
} // end main 

I'm still new myself so if anyone can improve upon that feel free.

[Daniel Spain]

heres what i use to get random numbers:

long rndnum(long lwoest,long highest)
{
     if(highest - lowest +1)
     {
             return((rand()%(highest-lowest+1))+lowest);
     }
     else
     {
             return(lowest);
     }
}

works pretty good, you cold use it like so:

int main()
{
	int num;
	int die;

	die = rndnum(1,6);
		
	cout << "\nWhat is your prediction? ";
	cin >> num;

	
	if (num==die)
	{
		cout << "\nYou guessed correct!";
	}
	else if (num < 7 && num > 0)
	{
		cout << "\nYou are incorrect.";
	}
	else
	{
		cout << "\nInvalid input.";
	}

	cout << "\nThe number rolled was: " << die << endl;
	
	system("PAUSE");
	return(0);
	
} // end main