is there a better way for this random 500-1000?

[metulburr]

is this the way you would generate a number from 500 to 1000, or this there a more efficient way, cuz when i run this it sometimes takes awhile to come up with a number(meaning the do-while loop and if-else)??

#include <iostream>
#include <cstdlib>
#include <ctime>
using namespace std;

int generate_random(int ran);

int main(int random)
{
    int your_number = generate_random(random);
    cout << "Your ID number is "<< your_number <<endl;
}

int generate_random(int i)
{
    do
    {
        srand(time(0));
        i = (rand() % 1000) + 1;
        if(i < 500)
            continue;
        else
            return i;
    }while(i < 500);
}

[3hM2Nwbp]

// Sneaky Trick
int generate_random()
{
    return (rand() % 500) + 500;
}

:)

Ah and I should mention that srand only needs to be called once during the life of your program.

[metulburr]

thanks
one question though, how come using the same technique
(rand() % 1) + 12;
always returns the number 12
wouldnt it return from 1 to 12???

[jsmith]

Any number modulo 1 is 0, and 0 + 12 == 12.