memory leaks

[phoenix1990]

Hi,
I'm having some problems with memory leaks and can't figure out how to fix the problem.
the code below is used to change letters in a string

#include <string.h>
#include <stdlib.h>
char *abc(char *string){
..... <-Just some declarations
char *encode = new char;
strsize = strlen(xxx);
enc = (char*) malloc (strsize);
for(int n=0;n<strsize;n++){
    ....<-process in which a new char is being change in string
    enc[n]=newchar;
}
encode[strsize]='\0';
return encode;
}

void main(){
	char *newstring;
	newstring = abc("Hello");
	delete newstring;
}

The code compiles fine.
The problems is that when the code reaches the delete command i get an error.
"Heap Corruption Detected"
"CRT detected that the application wrote to memory after end of heap buffer."
I have no clue how to solve this problem.
Any help is appreciated.
Thanks,
phoenix1990

[kooth]

A couple of things: You shouldn't mix malloc and delete: Either use new/delete or malloc/free.
Second thing is add one to strsize when you allocate your string for the null byte. Remember, arrays are zero-based, so your valid indices are 0 to strsize - 1.

[Moschops]

char *encode = new char;

encode is a pointer that points to enough space for a single character.

encode[strsize]='\0';

Is strsize is anything other than zero, you're writing over memory that isn't yours, because encode points to enough memory for one char only.

If you're going to code in C++, don't use these C-style strings if you can aviod it. Use proper C++ string objects.

[phoenix1990]

You shouldn't mix malloc and delete: Either use new/delete or malloc/free.

Is strsize is anything other than zero, you're writing over memory that isn't yours, because encode points to enough memory for one char only.

Thanks for the help kooth and Moschops.
Your comments really help me to resolve all the issues i was having with the code.
Now everything works perfectly.
Thankyou guys.