Breaker??

[vastrolorde]

when i runned my program i run into somekind of error. it compiled program, but when runned i started to getl oads and laods of errors. Can somone help me to fix these errors.

#include <iostream>
#include <string>
#include <sstream>
using namespace std;

int long long fibo(int n);
string output_formatted_string(string u);
string x[70];
int main (void) {
int n= 0;
string c = 0;
cout << "Enter a number: ";
cin >> n;
fibo(n);
output_formatted_string(c);
for(int f = 0; f<= 70; f++){
cout << x[f] << endl;
}
system("PAUSE");
return 0;
}

long long fibo(int n)
{
int i = 0;
if (n <2)
return 1;
long long temp1 = 1;
long long temp2= 2;
long long total = 0;
stringstream l;
while (n-- > 1)
{
total = temp1 + temp2;
temp2 = temp1;
temp1 = total;
l << total;
x[i] = l.str();
i++;
}
return 1;
}

#define GROUP_SEP ','
#define GROUP_SIZE 3

string output_formatted_string(string u){
stringstream temp, out;
string num;
for(int d = 0; d <= 70; d++){
	num = x[d];
temp << num;
string s = temp.str();
int n = s.size() % GROUP_SIZE;
int i =0;
if(n > 0 && s.size() > GROUP_SIZE){
out << s.substr(i, n) << GROUP_SEP;
i += n;
}

n = s.size() / GROUP_SIZE -1;
while (n-- > 0){
out << s.substr(i, GROUP_SIZE) << GROUP_SEP;
i += GROUP_SIZE;
}
out << s.substr(i);
x[d] = out.str();
}
return u;
}

[z05DSL3A]

Your for loops on lines 16 and 50 are going out of bounds, should be for(int f = 0; f < 70; f++) and for(int d = 0; d < 70; d++)

Line 11, string c = 0; what are you trying to do here?

[vastrolorde]

out of bound i cna fix by makeing the array bit ibgger. and line 11 i just needed it cause there is no value i want ot osend there i just need to call the function, so taht it would go through my array and formatt every member in there.

i get these 2 errors:
Error 1 error C2664: 'std::basic_string<_Elem,_Traits,_Ax>::basic_string(const std::basic_string<_Elem,_Traits,_Ax> &)' : cannot convert parameter 1 from 'int' to 'const std::basic_string<_Elem,_Traits,_Ax> &' c:\users\...\desktop\c++\39\projekt\projekt\main.cpp 68


2 IntelliSense: no suitable constructor exists to convert from "int" to "std::basic_string<char, std::char_traits<char>, std::allocator<char>>" c:\users\...\desktop\c++\39\projekt\projekt\main.cpp 68

[z05DSL3A]

Just make line 11: string c;

[vastrolorde]

i already got that working ja jsut made it a void. but now, problem is that the errors wont go away. New code is:

#include <iostream>
#include <string>
#include <sstream>
using namespace std;

int long long fibo(int n);
string output_formatted_string(void);
string x[71];
int main (void) {
int n= 0;
cout << "Enter a number: ";
cin >> n;
fibo(n);
for(int f = 0; f<= 70; f++){
cout << x[f] << endl;
}
system("PAUSE");
return 0;
}

long long fibo(int n)
{
int i = 0;
if (n <2)
return 1;
long long temp1 = 1;
long long temp2= 2;
long long total = 0;
stringstream l;
while (n-- > 1)
{
total = temp1 + temp2;
temp2 = temp1;
temp1 = total;
l << total;
x[i] = l.str();
i++;
}
output_formatted_string();
}

#define GROUP_SEP ','
#define GROUP_SIZE 3

string output_formatted_string(string u){
stringstream temp, out;
string num;
for(int d = 0; d <= 70; d++){
	num = x[d];
temp << num;
string s = temp.str();
int n = s.size() % GROUP_SIZE;
int i =0;
if(n > 0 && s.size() > GROUP_SIZE){
out << s.substr(i, n) << GROUP_SEP;
i += n;
}

n = s.size() / GROUP_SIZE -1;
while (n-- > 0){
out << s.substr(i, GROUP_SIZE) << GROUP_SEP;
i += GROUP_SIZE;
}
out << s.substr(i);
x[d] = out.str();
}
return 1;
}

but now the problem is in return 1;

[z05DSL3A]

it should be returning a sting not a number.

What is the program meant to be doing?

[vastrolorde]

first 70 fibonacci numbers, writes em into array, then formats the numbers so that the output woud be 43,546,464,546 not 43546464546 and then prints all 70 fibonacci numbers in array.

[vastrolorde]

im getting an error that output_formatted_string must retun a value. but what should i return, i wnat it to go to main and then read out the array.

[z05DSL3A]

im getting an error that output_formatted_string must retun a value.

string output_formatted_string(string u) it need to return a string.

#include <iostream>
#include <string>

using namespace std;

long long Fib(const int);

string FormatNumber(const long long &num);

int main () 
{
    const int size = 70;
    long long fibSequence[size];
    
    for(int i = 0; i < size; ++i)
    {
        fibSequence[i] = Fib(i);
    }
    
    for(int i = 0; i< size; ++i)
    {
        cout << FormatNumber(fibSequence[i]) << endl;
    }
    
    return 0;
}

long long Fib(const int n)
{
    if ( n == 0 || n == 1 ) 
        return n;
 
    long long fib1 = 0; 
    long long fib2 = 1;
    long long fib = 2;
 
    for ( int i = 2; i <= n; i++ ) 
    {
        fib = fib1 + fib2;
        fib1 = fib2;
        fib2 = fib;
    }

    return fib;
}

string FormatNumber(const long long &num)
{
    const string thousands = ",";
    int i = 0;
    long long tempNum = num;
    string fmt,digit;
    do 
    {
        if((i !=0) && !(i % 3)) 
        {
            fmt = thousands + fmt;
        }
        digit = (tempNum % 10) + '0';
        fmt = digit + fmt;
        tempNum /= 10;
        i++;
    }while((tempNum) || (i < 1));
    
    return fmt;
}

[vastrolorde]

im stuck here

#include <iostream>
#include <string>
#include <sstream>
using namespace std;

int long long fibo(int n);
string output_formatted_string(void);
string x[71];

int main (void) {
int n= 0;
cout << "Enter a number: ";
cin >> n;
fibo(n);
for(int f = 0; f<= 70; f++){
cout << x[f] << endl;
}
system("PAUSE");
return 0;
}

long long fibo(int n)
{
int i = 0;
if (n <2)
return 1;
long long temp1 = 1;
long long temp2= 2;
long long total = 0;
stringstream l;
while (n-- > 1)
{
total = temp1 + temp2;
temp2 = temp1;
temp1 = total;
l << total;
x[i] = l.str();
i++;
}
output_formatted_string();
}

#define GROUP_SEP ','
#define GROUP_SIZE 3

string output_formatted_string(void){
stringstream temp, out;
string num;
for(int d = 0; d <= 70; d++){
	num = x[d];
temp << num;
string s = temp.str();
int n = s.size() % GROUP_SIZE;
int i =0;
if(n > 0 && s.size() > GROUP_SIZE){
out << s.substr(i, n) << GROUP_SEP;
i += n;
}

n = s.size() / GROUP_SIZE -1;
while (n-- > 0){
out << s.substr(i, GROUP_SIZE) << GROUP_SEP;
i += GROUP_SIZE;
}
out << s.substr(i);
x[d] = out.str();
}
return ????;
}

i dunno what to return.

[z05DSL3A]

Okay, you don't seem to be using the value returned from output_formatted_string() so why not make it

void output_formatted_string();
void output_formatted_string()
{
   //....
   return;
}

or return out.str();

[vastrolorde]

ok i did it , but now whe n i run it i get this endles amount of numbers cause:

Warning 1 warning C4715: 'fibo' : not all control paths return a value c:\users\...\desktop\c++\39\projekt\projekt\main.cpp 41

[z05DSL3A]

I think you need to read up on functions again.

http://www.cplusplus.com/doc/tutorial/functions/

[vastrolorde]

something has gone wrong

long long fibo(int n)
{
int i = 0;
if (n <2)
return 1;
long long temp1 = 1;
long long temp2= 2;
long long total = 0;
stringstream l;
while (n-- > 1)
{
total = temp1 + temp2;
temp2 = temp1;
temp1 = total;
l << total;
x[i] = l.str();
i++;
}
output_formatted_string();
return 1;
}

It doesent calculate fibo

i get:
3
34
348
3481
34811
348111
and so on

[vastrolorde]

i dont have naything to return from fibo. i just need it to go back to main and finsih its probram. cause array has already been filled.

[vastrolorde]

It is almost fully functional only problem is tha fibo does not calculate fibonacci anymore, just gives em random numbers.

[z05DSL3A]

You are doing it a very odd way, however, the problem is the stringstream. In your loop you never clear the contents of it, so you jest keep adding number to it. Move line 9 [stringstream l;] to inside the while loop.

[vastrolorde]

i was told to manipulet the origial code not to write enirely new. i moved stringstream l into while loop, i stlee get endles amountso f numbers.

cin >> n;
fibo(n);
for(int f = 0; f<= 70; f++){
cout << x[f] << endl;
}
system("PAUSE");
return 0;
}

long long fibo(int n)
{
int i = 0;
if (n <2)
return 1;
long long temp1 = 1;
long long temp2= 2;
long long total = 0;
while (n-- > 1)
{
stringstream l;
total = temp1 + temp2;
temp2 = temp1;
temp1 = total;
l << total;
x[i] = l.str();
i++;
}
output_formatted_string();
return 1;
}

#define GROUP_SEP ','
#define GROUP_SIZE 3

void output_formatted_string(void){
stringstream temp, out;
string num;
for(int d = 0; d <= 70; d++){
	num = x[d];
temp << num;
string s = temp.str();
int n = s.size() % GROUP_SIZE;
int i =0;
if(n > 0 && s.size() > GROUP_SIZE){
out << s.substr(i, n) << GROUP_SEP;
i += n;
}

n = s.size() / GROUP_SIZE -1;
while (n-- > 0){
out << s.substr(i, GROUP_SIZE) << GROUP_SEP;
i += GROUP_SIZE;
}
out << s.substr(i);
x[d] = out.str();
}
return;
}

if u can try running it yourself

[z05DSL3A]

i was told to manipulet the origial code not to write enirely new.

I believe that your current path is a little off track. If this is homework it might be worth just checking you are on the correct path. If you want post the original code and assignment.

i moved stringstream l into while loop, i stlee get endles amountso f numbers.

In that case you also have a problem in output_formatted_string()

fibo() still dose not calculate the correct number, temp1 should be 0 (zero) and temp2 should be 1 (one).

To satisfy yourself that the looping number problem is in output_formatted_string(), comment out the call to it at the end of fibo() build and run the program.

I don't have the time at the moment to look at output_formatted_string() to work out what you are trying to do but from a quick look it seems that you are not clearing the stringstream and just keep adding number to it.

[vastrolorde]

hat was the problem, in output_formatted_string() i didnt clear hte string stream, that caused the error. now its fixed and working well