Run-time error

[Maese909]

I am getting a run-time error with this program and can't figure out what is wrong with my code. I basically created a class called bookType and created a program to test it out. The run-time error is occuring at lines 60-63, because the for loop isn't executing when it seems it should. Any advice on what has gone wrong is welcomed.

#include <iostream>
#include <string>

using namespace std;

const int MAX_ARRAY_SIZE=4;

class bookType
{
public:
	void printTitle() const; //member functions dealing with the title
	void setTitle(string bookTitle);
	bool compareTitle(string compTitle) const;

	void amountOfCopies() const; //member functions dealing with the copies of book
	void setCopies(int a);
	void incrementCopies();
	void decrementCopies();
	int returnCopies() const;

	void setPublisher(string pub); //member functions dealing with publisher of book
	void printPublisher() const;
	bool comparePublisher(string compPublisher) const;

	void setIsbn(string isbn); //member functions dealing with ISBN of book
	void printIsbn() const;
	bool compareIsbn(string compIsbn) const;

	void setPrice(double bookPrice); //member functions dealing with price of book
	void printPrice() const;
	bool comparePrice(double compPrice) const;

	void setAuthors(string authorList[], int size); //member functions dealing with author of book
	void printAuthors() const;
	bool compareAuthor(string compAuthor) const;
	int returnAuthors() const;

private:
	string title;
	string author[4]; //objects of type bookType can contain up to 4 authors
	string publisher;
	string ISBN;
	double price;
	int numOfCopies;
	int numOfAuthors;
};

int main()
{

	bookType myBook;
	int amountOfAuthors;
	string title;
	string listOfAuthors[MAX_ARRAY_SIZE];
	
	cout << "How many authors does your book have?";
	cin >> amountOfAuthors;

	cout << "Enter the author(s) of your book: ";
	for(int index=0;index<amountOfAuthors;index++)
	{
		getline(cin,listOfAuthors[index]);
	}

	myBook.setAuthors(listOfAuthors, amountOfAuthors);
                
                cout << endl;

	cout << "Enter the title of your book: ";
	getline(cin,title);
	myBook.setTitle(title);

	cout << "The authors of ";
	myBook.printTitle();
	cout << "are ";
	myBook.printAuthors();

	return 0;
}

void bookType::printTitle() const
{
	cout << title << endl;
}

void bookType::setTitle(string bookTitle)
{
	title=bookTitle;
}

bool bookType::compareTitle(string compTitle) const
{
	if(title==compTitle)
		return true;
	return false;
}

void bookType::amountOfCopies() const
{
	cout << numOfCopies << endl;
}

void bookType::setCopies(int a)
{
	numOfCopies=a;
}

void bookType::incrementCopies()
{
	numOfCopies++;
}
void bookType::decrementCopies()
{
	numOfCopies--;
}

int bookType::returnCopies() const
{
	return numOfCopies;
}

void bookType::setPublisher(string pub)
{
	publisher=pub;
}

void bookType::printPublisher() const
{
	cout << publisher << endl;
}

bool bookType::comparePublisher(string compPublisher) const
{
	if(publisher==compPublisher)
		return true;
	return false;
}

void bookType::setIsbn(string isbn)
{
	ISBN=isbn;
}

void bookType::printIsbn() const
{
	cout << ISBN << endl;
}

bool bookType::compareIsbn(string compIsbn) const
{
	if(ISBN==compIsbn)
		return true;
	return false;
}
void bookType::setAuthors(string authorList[], int size)
{
	numOfAuthors=size;
	for(int index=0;index<numOfAuthors;index++)
		author[index]=authorList[index];
}

void bookType::printAuthors() const
{
	for(int index=0;index<numOfAuthors;index++)
		cout << author[index] << " ";
}

bool bookType::compareAuthor(string compAuthor) const
{
	for(int index=0;index<numOfAuthors;index++)
		if(author[index]==compAuthor)
			return true;
	return false;
}

[Moschops]

This is not a run-time error. The code is doing what you told it to; it's just not what you expect.

Try changing all your uses of getline to cin >> instead (e.g. cin >>listOfAuthors[index];)

[Maese909]

Oh, I just fixed it right now by adding cin.get(ch)

cout << "How many authors does your book have?";
	cin >> amountOfAuthors;
	cin.get(ch);

where ch is a char variable. I wasn't thinking about the newline character after hitting enter.

[Moschops]

What happens if there are more than 9 authors?

[Maese909]

Thanks...that just made me realize I need to add a loop..

cout << "How many authors does your book have?";
	cin >> amountOfAuthors;
	while(amountOfAuthors<=0 || amountOfAuthors >4)
	{
		cout << "Invalid amount of authors. Please reenter the number of author(s): ";
		cin >> amountOfAuthors;
	}
	cin.get(ch);