Errors

[renzokuzen]

I know that what im going to post is a massive lines of codes but i hope you guys can help me to solve the problems...well, basically, i was asked to find the mode, median, mean and range of a set of numbers. The problem is, it seems that the codes somehow malfunction and i've got no idea how to debug it...i hope you guys can help me...

#include <dos.h>
#include <stdlib.h>
#include <conio.h>
#include <iostream.h>
#include <fstream.h>

void displayarr (int* arr, int n);
float calculateMean (int* arr,int n);
void sort (int* arr, int n);
float calculatemedian(int* arr, int n);
float calculatemode (int* arr, int n);

void main()
{
   clrscr();
   unsigned int n;
   int* arr;
   //ifstream fin;
   //ofstream fout;

   //fout.open("assignment.txt");
   cout << "Enter the size of the array: ";
   //fin.open("assignment.txt");
   cin >> n;

   arr = new int[n];
   srand(time(0));

    int i=0;
  do
  {

   arr[i] = rand() % 9+4;
   cout <<  "The random numbers generated are: " << arr[i] <<endl;
   i++;
  }
   while (i<n);






   /*for (int i=0;i<n;i++)
      arr[i] = rand() % 9 + 4;*/

   cout << "The numbers in the array is: \n";
   displayarr (arr, n);

   float mean = calculateMean (arr, n);
   sort (arr, n);

   cout << "The mean is: " << mean << endl;

   float median = calculatemedian (arr, n);
   cout << "The median is: " << median <<endl;

   float mode = calculatemode (arr, n);
   cout << "The mode is: " << mode <<endl;


   getch();
   //fout.close();
   //fin.close();
}


float calculateMean (int *arr, int n)
{
   float total = 0;
   for (int i=0;i<n;i++)
      total = total+arr[i];
   
   return (total/n);
}


void sort (int* arr, int n)
{
   for (int i =0; i<n-1; i++)
   {    
       for (int j=i+1; j<n; j++)
      {
         if (arr[j] <arr[i])
         {
             int temp = arr[j];
             arr [j] = arr [i];
             arr [i] = temp;
          }
      }
   }
}     
   
      

void displayarr (int* arr, int n)
{
   for (int i=0; i<n; i++)
   cout << arr[i] << "\t";
   cout << endl;
}

float calculatemedian(int* arr, int n)
{
   float median;
   if (n%2 == 0)
   {
      median = (float) (arr[n/2] + arr[n/2-1])/2;
   }
   else
   {
      median = arr[(n-)1/2];
   }

return (median);
}


float calculatemode (int* arr, int n)
{

   int freqtable[9] = {0,0,0,0,0,0,0,0,0};
   for(int i=0; i<n; i++)
   {
     ++(freqtable [arr[i]-4]);
   }

   int indexlargest=0;
   int largest = arr[0];

   for (int a=1; a<n; a++)
   {
      if (arr[a] > largest)
      {
	 indexlargest =i;
	 largest =arr[a];
      }
   }
   return (indexlargest+4);
}

i know the codes are terribly long but please...i really need help...desperate T_T

I need to find the range of data too but i've got no idea how to find the last number in an array...

[helios]

I could very well just copy the code and test it (if it wasn't for the fact that you're using non-standard and deprecated libraries), but I'm not going to.
Instead, you're going to learn to ask a proper question and post the expected output, the actual output, and your theories about what could be going wrong.

[renzokuzen]

oh im sorry....im very new in c++ and in the same time, in this forum...so, what exactly should i do??? I know my codes are messy but well, i've got no idea how could i actually urm...arrange them...

[helios]

Output, man. Output.
When you run it, what happens?

[Umz]

Say what you want it to do, what it does, and what the error message is. Give more details on the problem your having don't just say there's an error you gotta be more specific.

[renzokuzen]

oh! no Error....just some bugs stuff...

it's something like...



The mean is:7

The median is: 13321

The mode is: 7


Which is all wrong....

[helios]

Line 108: I think this: (arr[n/2] + arr[n/2-1])/2 should be like this: (arr[n/2] + arr[n/2+1])/2
Line 112: What is this supposed to mean? (n-)1/2
Lines 128-139: If you call this function while the array is sorted, then you can easily determine the largest element: it'll be on the tail.

[renzokuzen]

okay...thanks for finding the error for me on line 112... it's suppose to be (n-1)/2 and also for line 108...

and for lines 128 - 139,
yes it's sorting...but i do not know how to find the range =.=" sorry for this noob question...but i really got no idea how to start...

[firedraco]

Well, if the array is sorted from least to biggest...it should be too hard to find the range. Just look at the first/last elements.

[renzokuzen]

the problem is, i don't really know how. It's because im quite fresh in all this C++ and on the other hand, the size of the array is unknown. It is designated to be set by users. That is the problem why i've got no idea on how to find the last element.



Oh okay...i've just got a clue...from the above codes and since "n" is the number of arrays that should be keyed in by the user, so could it be that i call the sort function and i do something like,

arr[0] - arr[(n-1)]

since the last element in an array is always the total number of elements - 1...

[firedraco]

Well...since you tell it the array is of size 'n' (they input that value) then the maximum value is (n-1).

[renzokuzen]

THAAAAAAAAAAAAAAAAAAAAAAAANK YOU GUYS!!!!!!!!!!!!!!!!!!!! THANK YOU VERY MUCH!!!!! YOU guys RAWKS!