need some help(update)

[theman]

I have this code. The problem is that the program compile but it doesn´nt work when try to start the program. I start my program from cmd. I use diversion to start the program. excuse from my bad english. I hope you understand what i mean.(You need a textfile to start the program.)



#include <iostream>
#include <string>
#include<map>
#include<set>

using namespace std;

void tolower(string& sma);

void tolower(string& sma)
{

string::iterator sit = sma.begin();
while(sit!=sma.end())
{

if(isupper(*sit))
{
*sit = tolower(*sit);
sit++;
}
}


}



int main()
{

map<string, int> ord_lista;
string ord, rad;
//int count =0;
string::size_type beg = 0, end = 0;
while (getline(cin,rad))
{
ord+=rad;
end = 0;
beg = rad.find_first_not_of("\" .!?,", end);

while (beg != string::npos)
{

end = rad.find_first_of(" \".!?,", beg);
ord = rad.substr(beg, end - beg);
cout<<ord<<endl;
tolower(ord);


beg = rad.find_first_not_of("\" .!?,", end);

}

}

}

[ne555]

[code] "Please use code tags" [/code]
Could you be a little more explicit about the problem?
What are you trying to do? what are you getting?

[dangrr888]

Hi theman,

I've been looking at your code. From what I can gather, you want the user to enter a series of strings, where for each string you want to determine and isolate the characters not belonging to those in the string literal "\".!?,".

You then seem to want to invoke the overloaded function tolower to take these parts of the string and set all capital letters to lower case.

What I am not clear about is what you want to do with them then. You append rad to ord only then to overwrite ord later on(!), which doesn't make much sense to me.

In any case, I think the problem with compilation is due to the tolower function, since the isupper function is supposed to take a char rather than a std::iterator_traits<string::iterator>::value_type.

I made some modifications to the tolower function, and it seems to work:

string tolower(const char* sma, size_t sz)
{
  size_t i = 0;
  char ret[sz];

  while(sma[i])
    {
      ret[i] = tolower(sma[i]);
      ++i;
    }
  ret[i] = '\0';
  return ret;
}

where the first argument is the input string converted to a char[], and the second argument is a size_t containing the size of that array. The function then returns the desired string.

I am not sure what you want to do in main() after tolower is utilised. However, I changed your main() function to append all parts of the user-inputted strings that don't include the characters in the string literal "\".!?," after being converted to lower case:

int main()
{
  map<string, int> ord_lista; //not sure what this does
  string ord, rad, temp;

  string::size_type beg = 0, end = 0;

  while(getline(cin,rad))
    {
      end = 0;	
      beg = rad.find_first_not_of("\".!?,", 0);
	
      while (beg != string::npos)
        {
          end = rad.find_first_of("\".!?,", beg);
	
          temp = rad.substr(beg, end - beg);
          cout << temp << endl;

          ord += tolower(temp.c_str(), temp.size());

          beg = rad.find_first_not_of("\".!?,", end);
	}
    }

}

As indicated, I am not sure what you want to do with the map<string, int>, ord_lista, but I guess you might now be in a better position to determine that.

I hope this helps, good luck!