Using String class to output a word

[kowbonez]

We learned about object oriented programming. The assignment was to make two classes and have it output specific data. The first class -- Box -- works fine. I'm having trouble with the second class.

The String class needs to get a message from the main, store it in the method Set and then output it with the method Print. Thinking it would be simple like with the Box class, I coded it similarly, but it's not working. I think I screwed up somewhere trying to make the Set method store a word. I'm very bad with strings if that isn't obvious from my code.

Here is the code. I commented out the code that works.

#include<iostream>
using namespace std;
#include<fstream>



/*class Box
{
private:
	int height;
	int width;
	int x;
	int y;
public:
	Box(int, int, int, int);
	Box();
	void Initialize();
	void Move();
	void Resize();
	void Set1(int init_height, int init_width);
	void Set2(int init_x, int init_y);
	void GetPosition();
	void GetDimensions();
};*/

class String
{
private:
	char data;
	int size;
public:
	String(char);
	String();
	void Set(char str1);
	void Print();
};

/*Box::Box(int init_height, int init_width, int init_x, int init_y)
{
	Set1( init_height, init_width);
	Set2( init_x, init_y);
	
}



Box::Box()
{
	Set1(0,0);
	Set2(0,0);

}
void Box::Initialize()
{
	cout << "The height is " << height<< endl;
	cout << "The width is " << width << endl;
	cout << "x is " << x << endl;
	cout << "y is " << y << endl;


}


void Box::Move()
{
	int new_x, new_y;
	cout << "Enter x: ";
	cin >> new_x;
	cout << "Enter y: ";
	cin >> new_y;
	Set2(new_x, new_y);
}

void Box::Resize()
{
	int new_height, new_width;
	cout << "Enter height: ";
	cin >> new_height;
	cout << "Enter width: ";
	cin >> new_width;
	Set1(new_height, new_width);
}

void Box::Set1(int init_height, int init_width)
{
	if( init_height < 0)
		height= 0;
	else
		height= init_height;
	if ( init_width < 0)
		width= 0;
	else
		width= init_width;
}

void Box::Set2(int init_x, int init_y)
{
	if( init_x < 0)
		x= 0;
	else
		x= init_x;
	if ( init_y < 0)
		y= 0;
	else
		y= init_y;
}

void Box::GetPosition()
{
	cout << "The new x is " << x << endl;
	cout << "The new y is " << y << endl;
}

void Box::GetDimensions()
{
	cout << "The new height is " << height << endl;
	cout << "The new width is " << width << endl;

}*/

String::String(char str1)
{
	Set(str1);
}

String::String()
{
	Set(256);
}

void String::Set(char str1)
{
	data= str1;
}

void String::Print();
{
	cout << data << endl;
}



void main()
{	
	/*Box InitBox(100, 200, 50, 75);
	InitBox.Initialize();
	Box NewBox;
	NewBox.Move();
	NewBox.Resize();
	NewBox.GetPosition();
	NewBox.GetDimensions();*/

	String NewString("Hello");
	NewString.Print();
}

Can anyone lead me in the right direction?

[Albatross]

chars are individual one-byte characters, not entire strings. I think you meant to use std::string in place of all the chars (I hope they let you use that). :)

-Albatross

[kowbonez]

Oh thanks! Yes, we're allowed to use them.

So I changed those and this is what I have now.

class String
{
private:
	string data;
	int size;
public:
	String(std::string);
	String();
	void Set(std::string str1);
	void Print();
	
};

String::String(std::string str1)
{
	Set(str1);
}

String::String()
{
	Set(str1); 
}

void String::Set(std::string str1)
{
	data= str1;
}

void String::Print()
{
	cout << data << endl;
}



void main()
{	
	
	String NewString("Hello");
	NewString.Print();
}

I'm aware that I'm not sending the string correctly, but I don't know how to do it. A frustrating case of knowing what I want it to do, but not how to tell it to do it.

Also, I'm getting an error while trying to compile:
4 error C2761: 'void String::Print(void)' : member function redeclaration not allowed

Not sure what that means. Is this because of the strings or did I make a mistake somewhere else?

Figured it out. And now it compiles fine. :)

[Zhuge]

I have to ask, if you can use std::string, why even make this class? It seems to only wrap an std::string object and contain a useless member while restricting the uses of string methods.