output errors

[tonystark]

#include <iostream>
#include <fstream>
#include <string>
#include <iomanip>
using namespace std;
void InputError();

struct drinks
{
	long itemno;
	char itemname[100];
	int quantity;
	double unitprice;
};
 
void InsertNewRecord()
{
	ofstream outDrinks;
	int choice;
	drinks x;
	if(outDrinks)
	{
		do 
		{
			cout << "Please enter the new record " << endl;

			cout << "New Item No: "; 
			cin >> x.itemno;
			cout << "New Item Name: ";
			cin >> x.itemname  ;
			cout << "New Quantity: ";
			cin >> x.quantity ;
			cout << "New Price: ";
			cin >> x.unitprice ;
			
			cout << "1. Save || 2. Cancel" << endl;
			cin >> choice;
		}
		while (!(choice==1 || choice==2));
		if (choice==1)
		{
			ofstream outsRecord("Drinks.txt",ios::app,ios::binary);
			outsRecord.write((char*)&x,sizeof(drinks));
			outsRecord.close();
			cout << "Record Saved" << endl ;
		}
		else 
		{
			cout << "Record Cancel" << endl;
	}
	}
	else
	{
	cout << "Invalid File Opening" << endl;
	outDrinks.close();
	}
		
}

void DeleteRecord() 
{
	drinks x;	
	int num;

	cout << "DELETE RECORD" << endl;
	cout << "Please enter the record that you want to delete: "; 
	cin >> num;
	
	ifstream Drinksa("Drinks.txt",ios::in,ios::binary);

	int stop=0,c=0;

	if(Drinksa)
	{
	while(Drinksa.read((char*)&x,sizeof(drinks)))
	{
		c++;
	if((num==x.itemno))
	{
		stop=c;
	}
	}
	}
	else
	cout << "Invalid File Opening" << endl;
	Drinksa.close();

	rename("Drinks.txt","Temp.txt");

	int counter=0;
	
	ofstream Drinks("Drinks.txt",ios::app,ios::binary);
	ifstream temp("Temp.txt",ios::in,ios::binary);


	if(temp)
	{
	while(temp.read((char*)&x,sizeof(drinks))){
		counter++;
	if((counter==stop))
	{
		cout << "Record Deleted"  << endl;
	}
	else
		Drinks.write((char*)&x,sizeof(x));
	}
	}
	else
		cout << "Invalid File Opening"<< endl;
	
	Drinks.close();
	temp.close();
	system("Del Temp.txt");
}

void UpdateRecord() 
{
	fstream in, temp;
	drinks x;
	int num;
	 
	cout<<"UPDATE RECORD"<<endl;

	cout << "Enter Item No : "; 
	cin >> num;
	rename("drinks.txt","temp.txt");

	in.open("drinks.txt");
	temp.open("temp.txt");

	while(temp.read((char*)&x,sizeof(drinks))) {
		if (num == x.itemno) 
		{
			cout << "Current Record is:"  << endl ;
			cout << "Item NO: " << x.itemno << endl  ;
			cout << "Item Name: " << x.itemname << endl  ;
			cout << "Quantity: "  << x.quantity << endl ;
			cout << "Unit Price: " << x.unitprice << endl  ;

			cout << "Please enter the new value" << endl  ;
			cout << "Update Item No: " << endl ; 
			cin >> x.itemno ;
			cout << "Update Item Name: " << endl ; 
			cin >> x.itemname ;
			cout << "Update Quantity: "<< endl  ;
			cin >> x.quantity ;
			cout << "Update Unit Price: "<< endl ; 
			cin >> x.unitprice ;
		}
			in.write((char*)&x,sizeof(drinks));
		
	}
	in.close();
	temp.close();
	system("Del temp.txt");
}

void DisplayAllRecord()
{
	drinks x;	
		
		ifstream iRecord("drinks.txt",ios::app,ios::binary);
		if(iRecord)
		{
			cout << "Item No"<<setw(12)<<"Item Name"<<setw(14)<<"Quantity" <<setw(17)<<"Unit Price"<< endl;

			while (iRecord.read((char*)&x,sizeof(drinks))) 
			{	 
			cout <<x.itemno<<setw(12)<<x.itemname<<setw(14)<<x.quantity<<setw(17)<<x.unitprice<< endl;
			}
		}
	else
		cout <<"Error Not Found" << endl;
		iRecord.close(); 
}

void Name() 
{
	drinks x;
	int recordFound;
	char InputName[100];

	cout << "Enter Item Name: ";
	cin >> InputName;
	ifstream iRecord("drinks.txt");
	if(iRecord)
	{
		while(!iRecord.eof())
		{
			iRecord.read((char*)&x,sizeof(drinks));
			if(strcmp(InputName,x.itemname) == 0){
				cout << "Item No"<<setw(12)<<"Item Name"<<setw(14)<<"Quantity" <<setw(17)<<"Unit Cost"<< endl;
				cout <<x.itemno<<setw(18)<<x.itemname<<setw(12)<<x.quantity<<setw(16)<<x.unitprice<< endl;
				recordFound = 1;
				break;
			}
			else 
				recordFound = 0;
			}
		if (recordFound==0)
		{
			cout << "Record not found" << endl;
		}
	}
	else
	cout << "Invalid file Opening" << endl ;
	iRecord.close();
}

void Number() 
{
	drinks x;
	int recordFound;
	int number;

	cout << "Enter Item Number: " << endl;	
	cin >> number;
	ifstream iRecord("drinks.txt");
	if(iRecord)
	{
		while(!iRecord.eof())
		{
			iRecord.read((char*)&x,sizeof(drinks));
			if(number == x.itemno){
				cout << "Item No"<<setw(12)<<"Item Name"<<setw(14)<<"Quantity" <<setw(17)<<"Unit Cost"<< endl;
				cout <<x.itemno<<setw(18)<<x.itemname<<setw(12)<<x.quantity<<setw(16)<<x.unitprice<< endl;
				recordFound = 1;
				break;
			}
			else 
				recordFound = 0;
			}
		if (recordFound==0)
		{
			cout << "Record not found" << endl;
		}
	}
	else
	cout << "Invalid file Opening" << endl ;
	iRecord.close();
}

void DisplayRecord()
{
	int num;
	int choose;
	cout << "1. Search with item name || 2. Search with item no. :"; 
	cin >> choose;
	switch(choose)
	{
		 case 1:
			 Name(); 
			 break;

		 case 2:
			 Number(); 
			 break;
	 }
}

void Menu()
	{
	char choice;
	cout << "INTI COLLEGE DRINK STALL" << endl;
	cout << "Sarawak, Malaysia" << endl;
	cout << "***********************" << endl << endl;
	cout << "Choose one of the following menu: " << endl << endl;
	cout << "(a) Display a record" << endl;
	cout << "(b) Insert a new record" << endl;
	cout << "(c) Delete a record" << endl;
	cout << "(d) Update a record" << endl;
	cout << "(e) Display all records" << endl;
	cout << "(f) Exit" << endl << endl;
	cout << "Please enter your choice: " ;
	cin >> choice;
					
	switch (tolower(choice))
	{
		case 'a': 
			DisplayRecord() ; 
			break;

		case 'b': 
			InsertNewRecord(); 
			break;

		case 'c':
			DeleteRecord();	
			break;

		case 'd': 
			UpdateRecord(); 
			break;

		case 'e':
			DisplayAllRecord() ;
			break;

		case 'f': 
			InputError(); 
			break;

		default: 
			cout << "Invalid Input!" ;
	}
}

void InputError()
{
	char choice;
	cout << "Y: Exit || R: Return" << endl;
	cout << "Do you want to Exit: "; 
	cin >> choice;
		switch (tolower(choice))
		{
			case 'y':
				cout << "Thank you for using this program. Have a nice day!  " << endl;
				break;

			case 'r':
				Menu();
		}
}

THe preview should be a table listed with unit and unit prices
end up it bcm like this
[IMG]http://i11.photobucket.com/albums/a183/hahabinxq/dwq.jpg[/IMG]
but when i am compiling i got non errors msg, is there anything wrong with my coding?

thanks in advance.

[PanGalactic]

Looks like you C strings are not NUL terminated.