nooby mistake hopefully

i have two problems atm.

1) the first one is for some reason it skips the first question "clients name"
2) the secord one is i cant get it to save the questions to the array,( its only does numbers but not chars )

please compile and say where ive gone wrong :)

heres the code

 // basic file operations
#include <iostream>
#include <fstream>
#include <stdio.h>
#include <windows.h>
#include <sstream>
#include <string>
using namespace std;
int menu[4] ;
int client[6];
int item[5];
 string filename; 
 
 void delay()
 {
 int time =1;
 
 for(time != 500; time++;){
          system("cls");
         
          break;
          
          }
          
}

void menu1()
{
     cout << "What would you like to do? \n \n";
     cout << "   [1] start a new file. \n";
     cout << "   [2] Load a file. \n";
     cout << "   [3] Edit a file. \n";
     cout << "   [4] Edit the header file. \n\n";
     cout << "---PLease enter a number (1-4)--- \n";
    
     
     cin >> menu[0];
      
      delay();
     
  
     }
 
 void menu1op1()
 {   
      string mystr;
      
         ofstream myfile;
    cout << "What would you like to call this file:  " ;
    cin >> filename;  
  myfile.open((std::string(filename) + ".txt").c_str());
 



delay();
cout << "Client name: "; // SKIPS THIS ONE
 
 getline (cin, mystr);
    stringstream(mystr) >> client[0];
   
   delay();
    
 
 cout << "Contact phonenumber: ";
 
 getline (cin, mystr);
    stringstream(mystr) >> client[1];
   delay();
    
 cout << "Address line one: ";
 
 getline (cin, mystr);
    stringstream(mystr) >> client[2];
  
   delay();
 
 
 cout << "Address line two: ";
 
 getline (cin, mystr);
    stringstream(mystr) >> client[3];
    
    delay();
 
 
 
 cout << "Address line three: ";
 
 getline (cin, mystr);
    stringstream(mystr) >> client[4];
    
 delay();

 
 cout << "Postcode: ";
 

 getline (cin, mystr);
    stringstream(mystr) >> client[5];
    
    delay();

 
 cout << "Is this correct? \n";
 cout << client[0] << "\n";
  cout << client[1] << "\n";
   cout << client[2] << "\n";
    cout << client[3] << "\n";
     cout << client[4] << "\n";
      cout << client[5] << "\n";
      
      
 
 myfile << client[0] << "\n";
  myfile << client[1] << "\n";
   myfile << client[2] << "\n";
    myfile << client[3] << "\n";
     myfile << client[4] << "\n";
      myfile << client[5] << "\n";    // DOESNT SAVE TO THE ARRAYS AS IT SHOULD.
 
  myfile.close();
     
}

int main () {
   
   menu1();
   
   switch(menu[0]){
                  case 1:
                       menu1op1();
                       break;
                       }
                       system("pause");
  return 0;
}

Last edited on

Zaita (2770)

Use getline() not cin >> x. Or you have to flush the buffer of newline characters :) This should solve your problem.

Zaita (2770)

Also, client is an int. So it can only hold a number.

thecrrrg (16)

thanks zaita but i have already used getline() i think etc that one at the top which i have just changed...

anyway i got the same errors and what can i used instead of a int?

Zaita (2770)

Mixing getline and cin >> will cause issues if you don't use cin.ignore().

You have to think about what you're saving. You're not saving ints (numbers), so why is clients an int? What should clients be?

thecrrrg (16)

oh okay thanks

words and numbers?

danaigo (22)

I am a student at UAT online, hopefully I can help.

at line 52 add

cin.ignore(1) ;

this will flush the gratuitous enter from the buffer and allow you to see the next line rather than cycling through to the client number.

thecrrrg (16)

thanks that sloved problem one :)

now what data type can i used instead of int?

Zaita (2770)

string

thecrrrg (16)

how?

Mercurialol (20)

string client[6]; instead of int client[6];

thecrrrg (16)

is their another way when using strings's for getline? or cin?

thecrrrg (16)

okay i put this together to simple it down. atm it only can save one word to a array... how can i save a sentence.
also i got to be able t know how to load it back in, a way that doesnt depend on how many words someoen enters.

#include <iostream>
#include <string>
using namespace std;

int main ()
{
    string test[5];
cout << "enter \n";
cin >> test[5];
cout << test[];
system("pause");
  return 0;
}

anonymouscoder6 (42)

system("pause") is non-standard and should never be used.

thecrrrg (16)

okay i will take it out but stll anoyone know how to answer the questions xD

Zaita (2770)

1) Why is menu an array?
2) item appears unused.

You clearly need to do some reading on C++ arrays. You example above is likely to cause a crash. Before you tell me you've already read it, read it again and you'll notice while your array example above is wrong.

http://www.cplusplus.com/doc/tutorial/arrays/

thecrrrg (16)

because i didnt get around to making more use off it

Topic archived. No new replies allowed.

C++

Forum

nooby mistake hopefully