Runtime Error when using char arrays

[sohalezakeri]

Hey everyone. I would like to start off this post by intoroducing myself as a beginner to C++. I have been working with C++ through Visual Studio 2010 for the past 4 months and have recently began Object Oriented Programming in school. Regardless here is my problem.

I am trying to write a program that ultimately must take a user defined sentence as an input, and output the number of times each letter of the alphabet appears in this input. As well, the program must also state the length of each word.

So, I decided I would go about it by first receiving the users input and storing it in a char array. I then pass this char array to another function that "purifies" the array by removing all characters that are not alphabetic or a space.

The problem I have run into is this. The code compils fine, and after I enter a sentence and hit enter I receive a runtime Error stating:

Expression: (unsigned)(c+1)<=256

Using breakpoints, I have narrowed the problem down to my for loop. Before the program exits the for loop and reaches my cout statement, this error occurs.

Any help would be greatly appreciated. Thanks in advanced.

#include <iostream>
#include <cstdlib>
#include <string>

using std::char_traits;
using std::cout;
using std::cin;
using std::getline;
using std::string;


char initializeArray (char* input, const int size)
{

	cout << "Please enter a sentence\n";
	cin.get (input, size);

	return* input;

}

void cleanArray(char* input, const int size)
{
	int counter = 0;

	for (int i = 0; i < size; i++)
	{ 
		if ( isalpha (input [i]) || isspace (input [i]))

			cin.get (input, i);

	}
	cout << input;
}
	
int main ()
{
	const int size = 2048;
	char input [size];
	initializeArray(input, size);
	cleanArray(input, size);
	
	system ("pause");

	return 0;
}

[Zhuge]

You need to loop on strlen(input), not size. Otherwise you will read past the '\0' at the end, which seems to be causing the problem.

[sohalezakeri]

thanks Zhuge, that took care of the problem :)