patient question

[hakspek]

I can not seem to find the bugs in the code .. I know it's not over, but I have no nerves, so please help...

#include <iostream>
#include <exception>
#include <string>
#include <vector>
#include <sstream> 

using namespace std;


template<class T> 
class collection
{
private:
  T*   _elements; 
  int * _max; 
  int * _currentElements; 
public:   
	collection()
	{
		_max = new int(10); 
		_currentElements = new int(0); 
		_elements = new T[*_max];
	}
 
	collection(const collection<T> &obj)
	{
		_max = new int(*(obj._max)); 
		_currentElements = new int(*(obj.currentElements)); 
		_elements = new T[*_max];
		
		for (int i = 0; i < *_currentElements; i++)
			_elements[i] = obj._elements[i];
	}

	int GetCurrentElements() const 
	{
		return *_currentElements;
	}

	int GetMax() const 
	{
		return *_max;

	}
	~collection()
	{
		delete _elements; 
		delete _max; 
		delete _currentElements; 
	}
 
	void AddElement(const T obj)
	{
		if(*_currentElements == *_max)
			throw exception ("collection is full!");
		else
		{
			bool exist = false;

			for (int i = 0; i < *_currentElements; i++)
			{
				if (_elements[i] == obj._elements[i])
				{
					exist = true; 
					break;
				}
			} 
			if (!exist)
			{
				_elements[*_currentElements] = T (obj);
				(*_currentElements)++;
			}
		}
	}
  
	bool RemoveElement(int location)
	{
		if((*_currentElements)==0)
		{
			throw exception ("collection is empty!");
			return false;
		}

		if(location<=0 || lokacija>*_currentElements)
		{
			throw exception ("Location is outside the rank!");
			return false;
		}

		if( location != *_currentElements)
		{
			for (int i=location-1; i<GetCurrentElements()-1; i++)
			{
				_elements[i] = _elements[i+1];
			}
		}
		

		_elements[*_currentElements]= NULL;
		(*_currentElements)--;
	}

 
	bool operator==(collection <T> &org)
	{
		for (int i=0; i<  *_currentElements; i++)
		{
			if((*(_elements[i]))!=(*(org._elements[i]))) return false;
			return true;
		}
	}

	T& operator [](int index)
	{
		return (*_elements[index]);
	} 

	friend ostream& operator<<(ostream &out, const collection <T> &obj)
	{
		out<<"current Elements: "<<*(obj._currentElements)<<endl;
		out<<"Max elements: "<<*(obj._max)<<endl;
		for (int i=0; i<*_currentElements;i++)
		{
			out<<*_elements[i];
		}

		return out;
	}

}; 
 
class examination
{ 
  string _diagnosis; 
  float _payment; 
public: 
  examination()
  {
	  _diagnosis = "no name";
	  _payment = 0;
  }

  examination(string diagnosis, float payment)
  {
	  _diagnosis = diagnosis;
	  _payment = payment;
  }

  ~examination()
  {
  }

  string GetDiagnosis() 
  {
	  return _diagnosis;
  }

  float GetPayment()
  {
	  return _payment;
  }

  void SetDiagnosis(string d)
  {
	  _diagnosis=d;
  }

  void SetPayment(float p)
  {
	  _payment=p;
  }

  bool operator == (examination &p)
  {
	  if (_diagnosis == p.GetDiagnosis() && _payment == p.GetPayment())
		  return true;

	  return false;
  }

  void Info()
  {
	  cout<<"Diagnosis: "<<this->_diagnosis<<endl;
	  cout<<"Payment: "<<this->_payment;
  }

}; 



class patient
{ 
protected: 
  const int _patientID; 
  char * _name;   
  collection<examination> _examinationOfThePatient; 
public:   
	patient():_patientID(0)
	{
		this->_name = new char[strlen("N/A") + 1];
		strcpy(this->_name, "N/A");
	}

	patient(const int patientID, char* name ) : _patientID(patientID)
	{
		this->_name=new char [strlen(name)+1];
		strcpy(this->_name,name);
	}

	patient (const patient &obj) : _patientID(obj._patientID)
	{
		this->_name = new char[strlen(obj._name)+1];
		strcpy(this->_name, obj._name);

		this->_examinationOfThePatient=obj._examinationOfThePatient;
	}


	~patient()
	{
		delete [] this->_name;
		this->_name = NULL;
	}

	int GetPatientID() const
	{
		return this->_patientID;
	}

	char* GetName()
	{
		return this->_name;
	}

	void SetName(char* name)
	{
		delete [] this->_name;
		this->_name=new char[strlen(name)+1];
		strcpy(this->_name,name);
	}

	
	examination operator[] (int location)
	{
		return _examinationOfThePatient[location];
	}


	int NumberOfExamination()
	{
		return _examinationOfThePatient.GetCurrentElements();
	}


	void AddExamination(examination diagnosis)
	{

		if (diagnosis.GetPayment() == 0)
			throw exception("Please make your payment");

		bool exist = false;

		for (int i = 0; i < _examinationOfThePatient.GetCurrentElements(); i++)
		{
			examination tempExamination = _examinationOfThePatient[i];
			if(tempExamination == diagnosis)
			{
				exist = true;
				break;
			}
		}
		
		if(!exist)
			_examinationOfThePatient.AddElement(diagnosis);	
	}

	bool RemoveExamination(int location)
	{
		bool remove = false;
		try
		{
			this->_examinationOfThePatient.RemoveElement(location);
			remove = true;
		}
		catch (exception &e)
		{ 
			remove = false;
		}
		return remove;
	}

	friend ostream& operator <<(ostream &out, const patient &obj)
	{
		out<<"patient ID: "<<obj._patientID<<endl;
		out<<"Name of the patient: "<<obj._name<<endl;

		return out;

	
	}
}; 
 
class ForeignPatient : public patient
{  
private: 
   char * _citizen;  
public: 

	ForeignPatient():patient()
	{
		this->_citizen=new char[strlen("N/A")+1];
		strcpy(this->_citizen, "N/A");
	}

	ForeignPatient(int pacID, char* n, char* cit):patient(pacID, n)
	{
		this->_citizen=new char[strlen(cit)+1];
		strcpy(this->_citizen, cit);
	}

	~ForeignPatient()
	{
		delete [] this->_citizen;
		this->_citizen=NULL;
	}

	char* GetCitizen() const { return this->_citizen; }

	void SetCitizen(char *cit)
	{
		delete [] this->_citizen;
		this->_citizen=new char[strlen(cit)+1];
		strcpy(this->_citizen, cit);
	}


	string patientInfo()
	{
		stringstream myStream;

		myStream<<"PatientID: "<< this->GetPatientID()<<endl<< " "<<"Name: "<< this->GetName()<< endl<< " "<<"Citizen: "<<this->_citizen;


		return myStream.str();
	}
}; 


vector<examination> operator()(patient& patient, float minPayment, float maxPayment)
{
	vector<examination> examinations;
	for (int i = 0; i < patient.NumberOfExamination(); i++)
	{
		if(patient[i].GetPayment() >= minPayment && patient[i].GetPayment() <= maxPayment)
			examinations.push_back(patient[i]);
	} 
	return examinations; 
}


void main()
{
      try
        {

		examination s1("pneumonia", 100);
		examination s2("carcinoma", 200);
	
		patient p1(222, "Man");
		patient p2(333, "Lady");
	

		p1.AddExamination(s1);
		p2.AddExamination(s2);

		p1.RemoveExamination(1);
	
	}
	catch (exception &e)
	{
		cout<<"Error: "<<e.what()<<endl;
           }
	
}

[Return 0]

How about providing the error messages, 383 loc is a lot to look through without knowing what you're looking for.

[filipe]

if(patient[i].GetPayment() >= minPayment && pacijent[i].GetPayment() <= maxPayment)

I just took a very quick look, but it looks like that "pacijent" identifier is non existent. It doesn't help that you don't add spaces around operators like << and +, though. It makes your code less readable.

But really, listen to Return 0.

[hakspek]

When I compiled, one error appears to me (maybe there are more), but it tells me:

error C2801: 'operator ()' must be a non-static member 350

vector<examination> operator()(patient& patient, float minPayment, float maxPayment)
{
	vector<examination> examinations;
	for (int i = 0; i < patient.NumberOfExamination(); i++)
	{
		if(patient[i].GetPayment() >= minPayment && patient[i].GetPayment() <= maxPayment)
			examinations.push_back(patient[i]);
	} 
	return examinations; 
}

p.s. I corrected the mistake the patient

[firedraco]

You can't just have the () operator sitting outside like that. It needs to be inside a class (and non-static).

[filipe]

The message is crystal clear. Your overload is not a member of any class. operator() must be a member of some class.

[hakspek]

yes, i know, but in my assignment operator () must be implement like a global function...