RPG battle system

[idono]

im tring to get the combat system the way i want it the goblin is to attack randomly but when he attacks its always the same 2 numbers for attack how do i make it more random every time?

#include<iostream>
#include<cmath>
#include<cstdlib>
#include<iomanip>
#include<ctime>
using namespace std;
int main()
{
    int space;
    int player1;
    //monster always attaks first
    
    ///////weapons & Damage///
    double Flint_Gun = 5;
    double Small_Dagger = 3;
    double health = 70;
    double Wooden_stick = 3;
    double Gobling_health = 30;
    double health_potion = 10;
    double bonus_10 = 10;
    ///i ran the program no loss of data found in my program.
    unsigned Gobling_Damage = time(0);
    //////////////////////////
       
     
       
        while (Gobling_health >= 1 && health >= 1)
       
       
        {///master while for combat

    srand(static_cast<unsigned int>(time(0)));      
    
    cout<<"  your health "<<health<<endl;
    cout<<"  the Gobling "<<Gobling_health<<endl;
 
    srand(Gobling_Damage);

    Gobling_Damage = (rand() % 5) + 1;
    
    cout<<"  The Goblin did "<<Gobling_Damage<<" Damage"<<endl;

    health = health - Gobling_Damage;
   
    ///1 spaces////////////////
    space = 1; 
     
        while(space <= 1)
{
            cout <<""<<endl;
            space++;
}     
    ///////////////////////////
   
    cout<<"  your health "<<health<<endl;
    cout<<"  the Gobling "<<Gobling_health<<endl;
       
    system("pause");
       
    ///1 spaces////////////////
    space = 1; 
     
        while(space <= 1)
{
            cout <<""<<endl;
            space++;
}     
    ///////////////////////////
   
    char Attack;

        //condition that player1 dies in fight
        if(Gobling_health > 0 && health < 1)
        {
            cout<<"  Your killed lolz sorry"<<endl;
       
        system("Title        Game Over          ");
       
        system ("pause");
        return 0;
        }
   
    cout<<"  pick a weapon and fight or he will kill you!"<<endl;
    cout<<"  S:Small Dagger attack 3"<<endl;
    cout<<"  F:Flint Gun attack 5"<<endl;
    cout<<"  W:Wooden stick 2"<<endl;
    cout<<"  P:health bottle"<<endl;
    cout<<"  pick or die: ";
    cin >>Attack;
   
    ///2 spaces////////////////
    space = 1; 
     
        while(space <= 2)
{
            cout <<""<<endl;
            space++;
}     
    ///////////////////////////
   
    //these are the condition of fighting
        if(Attack == 'S' || Attack == 's')
        {             
    Gobling_Damage = (rand() % 10) + 1;   
    Gobling_health = Gobling_health - Small_Dagger;
    cout<<"  Small Dagger Attack dealed 3 Damage! "<<endl; 
        }
     
       
       
        if(Attack == 'F' || Attack == 'f')
        {         
    Gobling_Damage = (rand() % 10) + 1;
    Gobling_health = bonus_10 + Gobling_health - Flint_Gun;
    cout<<"  Flint Gun attack dealed 5 Damage! "<<endl; 
    cout<<"  you hit the monster but bullets make it Stronger!!!"<<endl;
        }
     
       
        if(Attack == 'W' || Attack == 'w')
        {         
    Gobling_Damage = (rand() % 10) + 1;
    Gobling_health = Gobling_health - Wooden_stick;
    cout<<"  Wooden stick attack dealed 3 Damage! "<<endl; 
        }
           
           
    if(Attack == 'P' || Attack == 'p')
        {         
    Gobling_Damage = (rand() % 10) + 1;
    health =  health + health_potion ;
    cout<<"  Monster Attacked you but"<<endl;
    cout<<"  health bottle gave you 5 health! "<<endl; 
        }
       
    ///5 spaces////////////////
    space = 1; 
     
        while(space <= 5)
{
            cout <<""<<endl;
            space++;
}     
    ///////////////////////////


    //ondiction that player1 wins
          if(Gobling_health <= 0 && health > 0)
        {
         
        system("Title        The Tale of Argoonia          ");
        system("Color 3"); 
                 
  cout<<"  you did it "<<player1<< " the town of Argonia is safe but for how long"<<endl;
    cout<<"                          The End"<<endl;

  ///2 spaces////////////////
    space = 1; 
     
        while(space <= 2)
{
            cout <<""<<endl;
            space++;
}     
    ///////////////////////////

 cout<<"  Tale of Argonia 2:The Wizzerd and the Demon Bull King coming     soon!!!"<<endl;           
 
  
                                                
    system ("pause");                         
    return 0;                                    
                                                   
          }                                        
   
            }///master while for combat end


}

[mahlerfive]

One problem is that you are seeding with srand() every time in the loop. You should only seed once, at the beginning of the program. Also, is that static_cast necessary?

[idono]

no static_cast is not necessary but nope it still giving the same 2 random numbers each time the monster attacks

[mahlerfive]

Take out this line:
srand(Gobling_Damage);

Like I said, you should only seed once, at the beginning.

[idono]

thanks mahlerfive i got it to work but just one more question, i'm using dev c++ to make a text base rgp and i was wondering what would be the best way to store items like gold and potions using an array ect..?

[mahlerfive]

You probably want to use a structure to store the player's inventory. Let's say you want to store the number of health potions, the amount of gold, and which weapons the player has. You could make a structure like this:

[code=c++]
struct inventory {
int gold;
int potions;
bool stick;
bool dagger;
bool gun;
};
[/code]

If you don't know how to use structures, now would be a good time to learn, just google c++ structures.

[Knight01]

Hi idono can you teach me how to make RPG with C++ because i am a beginner and i don't know how the code...... Please!!!!

GBU

[unknown]

Thanks for posting this code, it inspired me to try to do something similar (obviously using my own knowledge) tsk. one question , where did you get the "system" commands?, I really liked them (I thought there was no way to change the font o.o at least in the command prompt....).