Looking for a few more efficient ways...

[galameth]

Picking up C++ again and to teach myself how to use order of operations and different function statements I hammered through a couple of hours of coding, but, i'm wondering, with the scope of what i'm doing, are there any points where there is a more efficient, smaller, or less sludgy way of doing things? Any shouts or pointers would be amazing.

Example below, and looking at it, the sheer number of if statements is scaring me considering I want to eventually add lots of people running through this same (and to be bigger) daily checklist.

/*
Zombie sim 0.1

An attempt to simulate the daily life of a human (broken down 24 hours in 24 minutes) to see the
odds of surviving on a per day basis and the expansion of the zombie populous vs the human populous

:D
*/
#include <cstdlib>
#include <cmath>
#include <iostream>
#include <time.h>
using namespace std;

int main(){
    
//declare our variables
int awake, eat, safe, mate, survive, attempts, slept, ate, mated, survived, zombie, zombiefied, stupid, runs, eaten, starved;
string didsleep, dideat, aresafe, didmate, didsurvive, arezombie, starve;

//thrown here to work out how to do longest consecutive time spent alive
int chain, longest;

//zeroing out variables cause I know no better way
slept = 0;
ate = 0;
mated = 0;
survived = 0;
zombiefied = 0;
stupid = 0;
eaten = 0;
starved = 0;
chain = 0;
longest = 0;

//be polite, ask how long they want it to run first
cout << "How many attempts would you like to simulate? :>";
cin >> runs;

//loop with odds of one thing or the other happening
while( attempts < runs ){
awake = rand() % 3;
eat = rand() % 3;
safe = rand() % 3;
mate = rand() % 3;
survive = rand() % 3;
zombie = rand() % 5;
//+++++++++++++++++++++++++++++++++++++++++++
//are you awake? (will later determine if you more vulnerable to zombification
// due to being unconscious as well as whether or not you are forcefully
//put to sleep from exhaustion (how many days without sleep)
if( awake == 1 ){
    didsleep = "you did";
    slept++;}
else
    {didsleep = "you did not"; 
};
//+++++++++++++++++++++++++++++++++++++++++++
//Have you eaten today? Will move into how strong/weak you are from lack
//of nutrition (and overall food supply for when we start including
//larger numbers of people, also helps determine if you have starved to death
if( eat == 1 ){
    dideat = "you did";
    ate++;
    eaten = 0;
    }
else 
    {dideat = "you did not";
    eaten++;
};
//++++++++++++++++++++++++++++++++++++++++++++
//dunno why this is here yet, it seemed like an idea to have it but it might later
//determine your odds of encountering a zombie (and then determine your odds of surviving
//that encounter (i.e. 1 zombie = good odds, unsafe = 100's of zombies = death T_T
if(safe == 1){
    aresafe = "you are";}
else
    {aresafe = "you are not";
};
//+++++++++++++++++++++++++++++++++++++++++++++
//er... im assuming the human race is going try to keep going, which means the population
//will fluctuate....
if(mate == 1){
    didmate = "you did";
    mated++;}
else
    {didmate = "you did not";
};
//+++++++++++++++++++++++++++++++++++++++++++++
//well? did you?!? also helps determine how long you stayed alive
if (( survive == 1 ) && ( eaten < 14 )){
    didsurvive = "you did";
    survived++;
    chain++;}
    
else
    {didsurvive = "you did not";
    chain = 0;
};

if(chain > longest)
longest++;
//++++++++++++++++++++++++++++++++++++++++++++++
//Have you joined the undead horde?
if( zombie == 1){
    arezombie = "you are";
    zombiefied++;}
else
    {arezombie = "you are not";
};
//+++++++++++++++++++++++++++++++++++++++++++++++
//its here that we determined how many  attempts you have failed at eating, 
//assuming overall attempts were 3 times daily and 14 days till starvation... or
//was that dehydration o_O
if( eaten > (13 * 3) ){
    starve = "starved";
    starved++;}
else
    {starve = "did not starve";};
    

    
//daily statistics
cout << "Welcome to your day!" << endl;
cout << "Today: " <<endl;
cout << didsleep << " sleep..." << endl;
cout << dideat << " eat..." << endl;
cout << aresafe << " safe..." << endl;
cout << didmate << " mate..." << endl;
cout << didsurvive << " survive..." << endl;
cout << "And " << arezombie << " a zombie!" << endl;
cout << endl;


attempts++;
};

//global statistics after it has finished the overall loop
cout << "In total you:" << endl;
cout << "Slept " << slept << " times" << endl;
cout << "Ate " << ate << " times" << endl;
cout << "Mated " << mated << " times" << endl;
cout << "And survived " << survived << " times!" << endl;
cout << "You starved " << starved << " times!" << endl;

//if you didnt die from old age or natural death, and if you werent zombified
//or starved to death, you obviously did something you are less then comfortable
//admitting and died cause of it =D
stupid = runs - survived - zombiefied - starved;

cout << "You died " << stupid << " times from idiocy" << endl;
cout << "Sadly, you became a zombie " << zombiefied << " times T_T" << endl;
cout << "Your longest run was " << longest << " days alive!" << endl;

return 0;
}

[Browni3141]

One thing I recommend is reducing the number of variables you're using. It's killing me just to look at lines 18-19. There must be a better way to do this.

You can't declare all of your variables as integers. For a string you must use a character array.

[pabloist]

Do you mean you plan on having multiple virtual people in the game? I'd suggest looking into classes so that it's easier to manage. Since you want to keep track of a variety of statistics (ie, # times slept/ate/died?/zombified?(cant those only happen once?)/mated etc), I think it's unavoidable using all those variables.

Also, strings, "things in quotation marks", can't be put into int variables. You would need to use either a string or a character array (I'd recommend strings because they're far easier to use if you don't really need to manipulate the words so much)

You should also try using functions to clean up the code. Having everything in main is a headache.

Combining functions with classes, your main() might look something like:

int main()
{
    Person people[100];
    int deathcount = 0;

    while (true)
    {
        for (int i=0; i<100; i++)
        {
            people[i].Update();
            people[i].PrintStatus();
            if (people[i].isDead) 
                deathcount++;
        }
        // then, 
        if (deathcount == 100) 
                break;
    }
    return 0;
}

[galameth]

Yes indeed i do ultimately intend it to grow in virtual person size. I was afraid of the multi-variable kludge being necessary >_< zeroing all those out is really sucking.

As for the string suggestion, my above code does indeed declare strings o.o
line 19.

//declare our variables
int awake, eat, safe, mate, survive, attempts, slept, ate, mated, survived, zombie, zombiefied, stupid, runs, eaten, starved;
string didsleep, dideat, aresafe, didmate, didsurvive, arezombie, starve;

Also, I guess its time to bust into learning how do do classes. I've never done them so it'll be an experience i'm sure.

Since each person has to individually go through the exact same checklist of if() statements, would it be easier to just group all the if's into a class then, i guess, call the class and feed the persons identifying marker into it to see if that one person survived, then move onto the next person and repeat?

[edit] Just meandered into the Functions(I) and (II) tutorials and in thinking im grasping how to condense alot of this.