Issue with maze solving program!

[Evote]

I'm not sure whats wrong with this program
It runs but has something incorrect in it and please don't yell at me for using system(""); commands i know they security stuff i'll fix that later.

The programs not quite finished but it should show movement of The computer abit not finish it though!! WHY WON"T IT lol.
My programs abit long sorry;

#include <iostream>
#include <stdlib.h>
#include <windows.h>
#include <fstream>
#include <string>
#include <sstream>
#include <stdio.h>
#include <string.h>
#include <utility>

using namespace std;

string Direction(string &up, string &down, string &left, string &right) {
    string ReturnTXTl;
    int check = 0;
    Sleep(100);

    if (up == "_" or up == "F") {
        check++;
        ReturnTXTl = "up";
    }
    if (down == "_" or down == "F") {


        check++;
        ReturnTXTl = "down";

    }
    if (left == "_" or left == "F") {

        check++;
        ReturnTXTl = "left";

    }
    if (right == "_" or right == "F") {
        check++;
        ReturnTXTl = "right";

    }
    if (check > 1)

    {
        ReturnTXTl = "checkpoint";
    }
    if (check ==0) {
        ReturnTXTl = "previous";
    }
    cout<<ReturnTXTl<<endl;
    return ReturnTXTl;
}



char stringtochar(string a, int b) {
    char character = a[b];
    return character;
}

void Create() {

start:
    string tmp;
    int Mode;
    int x, y;
    char Filename[100];
    cout << "Enter: \n1. To create a new maze.\n2. To edit a saved maze.\n3. To quit to main Menu." << endl;
    cin >> Mode;

    if (Mode == 1) {

        cout << "Enter filename to save to with .txt at end." << endl;
        cin >> Filename;
        ofstream Mazer1(Filename);
        cout << "Creating file...." << endl;
        Sleep(100);
        cout << "Opening file....." << endl;
        cout << "Enter maze width:";
        cin >> x;
        cout << "Enter maze height:";
        cin >> y;
        string Maze[y];
        Mazer1 << y << endl;
        system("cls");
        cout << endl << "Enter Lines:\t\tLines left: " << y << endl;

        for (int n = 0; n < y; n++) {
            cin >> tmp;
            Maze[n] = tmp;
            Mazer1 << tmp.substr(0, x) << endl;
        }

        Mazer1.close();

        system("PAUSE");
    }


    else if (Mode == 2) {

        cout << "Enter filename to edit:" << endl;
        cin >> Filename;
        string Line[100];
        int lines, count = 1, Tempw;
        fstream Mazer2;
        Mazer2.open(Filename, fstream::in | fstream::out);

        if (!Mazer2) {
            cerr << "Error opening input!!!" << endl;
            system("PAUSE");
        }

        while (! Mazer2.eof()) {
            getline(Mazer2, Line[count]);
            cout << Line[count] << endl;
            count++;
        }

        char temp[100];

        for (int i = 0; i < Line[1].length(); i++) {
            temp[i] += Line[1][i];
        }

        lines = atoi(temp);

        cout << "There are: " << lines << " lines!!" << endl;
        Sleep(1000);
        cout << "How many lines will you be adding?" << endl;
        cin >> Tempw;
        lines += 2;
        Mazer2.close();
        ofstream Mazer3(Filename);

        for (int t = 0;t < lines;t++) {
            cout << Line[t] << endl;
        }

        for (int j = 0; j < Tempw; j++) {
            cin >> tmp;
            Line[lines+j] = tmp;
        }

        for (int e = 0; e <= (lines);e++) {
            Mazer3 << Line[e+1] << endl;
        }


        system("PAUSE");

        Mazer3.close();
    }



    else if (Mode == 3) {
        return;
    }

    else {
        cout << "Invalid Entry Try again!!!" << endl;
        Sleep(1000);
        system("cls");
        goto start;
    }
}

void Solve() {
    //Inilisation of Variables

    bool Finished = false, foundstart = false;
    string Maze[100][100];
    char Filename[100];
    cout << "Enter filename to edit:" << endl;
    cin >> Filename;
    string Line[100];
    int lines, count = 1;
    fstream Mazer2;
    Mazer2.open(Filename, fstream::in | fstream::out);

    if (!Mazer2) {
        cerr << "Error opening input!!!" << endl;
    }

    while (! Mazer2.eof()) {
        getline(Mazer2, Line[count]);
        cout << Line[count] << endl;
        count++;
    }

    char temp[100];

    for (int i = 0; i < Line[1].length(); i++) {
        temp[i] += Line[1][i];
    }

    lines = atoi(temp);

    cout << "There are: " << lines << " lines!!" << endl;

    //Maze Inilisation

    for (int a = 1;a <= lines;a++) {
        for (int b = 0;b < (Line[a+1].size());b++) {
            Maze[b][a] = stringtochar(Line[a+1], b);
            cout << Maze [b][a];
        }

        cout << endl;
    }

    int Position[3];

    int checkpoint1[50];
    int checkpoint2[50];


    while (foundstart == false) {
        for (int a = 1 ;a < 10;a++) {
            if (Maze[a][1] == "S") {
                foundstart = true;
                checkpoint1[1] = a+10;
                checkpoint2[1] = 1;
                Position[0] = a+1;
                Position[1] = 1;


            }
        }
    }
    cout<<Position[0]<<" ,"<<Position[1]<<endl;

    string up, down, left, right, arrow;
    system("PAUSE");
    int previous = 1;

    while (Finished == false) {
        up   =  Maze[Position[0]][Position[1] - 1];
        down  = Maze[Position[0]][Position[1] + 1];
        left  = Maze[Position[0] - 1][Position[1]];
        right  = Maze[Position[0] + 1][Position[1]];
        arrow = Direction(up, down, left, right);

        if (arrow == "up") {
            Position[1]--;
            Maze[Position[0]][Position[1]] = 'P';
        }

        else if (arrow == "down") {
            Position[1]++;
            Maze[Position[0]][Position[1]] = 'P';
        }

        else if (arrow == "left") {
            Position[0]--;
            Maze[Position[0]][Position[1]] = 'P';
        }

        else if (arrow == "right") {
            Position[0]++;
            Maze[Position[0]][Position[1]] = 'P';
        }

        else if (arrow == "checkpoint") {
            checkpoint1[previous] = Position[0];
            checkpoint2[previous] = Position[1];
            previous++;
        }
        else if (arrow == "previous") {
            Position[0] = checkpoint1[previous];
            Position[1] = checkpoint2[previous];
            previous--;
        }

        else if (Maze[Position[0]][Position[1]] == "f") {
            Finished = true;
        }



    }


    cout << endl;

    Mazer2.close();
    for (int a = 1;a <= (lines);a++) {
        for (int b = 0;b < (Line[a+1].size());b++) {
            cout << Maze [b][a];
        }

        cout << endl;
    }
    system("PAUSE");
}



int main() {

start:
    ofstream Mazer;
    int Mode;
    cout << "Welcome to maze bot!!" << endl << endl;
    Sleep(500);
    cout << "Enter: \n1. To create a maze.\n2. To solve it.\n3. To quit program." << endl;
    cin >> Mode;

    switch (Mode) {

    case 1:
        system("cls");
        Create();
        system("cls");
        goto start;
        break;

    case 2:
        system("cls");
        Solve();
        system("cls");
        goto start;
        break;

    case 3:
        exit(1);

    default:
        cout << "Incorrect Syntax!!!(Jerk)";
        Sleep(1000);
        system("cls");
        goto start;
        break;

    }

    Mazer.close();
}


Sorry bout code length and how do i make tabs work with these questions??
[/c0de]

Compiler=CODE::BLOCKS:
and it runs

bump!!!
BLA BORED NEED ANSWER LOL!!

[Evote]

Bump i really need answer before within an hour

[z05DSL3A]

It compiles?


else if ( check > 1 ); somewhere around line 76, should probably be else if ( check > 1 )


In your solve function you have code like Maze[Position[1]][Position[2]] == 'P';, this will do nothing, should it be Maze[Position[1]][Position[2]] = 'P';?


string Maze[y]; I would not expect this to compile, as y is not constant.
...


How to: Put code into your postings
http://www.cplusplus.com/forum/articles/1624/

[Evote]

Lol mingw isn't that fussy usually Thank you though Helped alot
everything besides one thing is fixed
whats wrong with this?

up = Maze[Position[1]][Position[2] - 1];

[z05DSL3A]

With int Position[2]; you should be referencing as Position[0] and Position[1].

[Evote]

Bump still doesn't work somethings up in the Direction function i think.

[Evote]

Bump

[z05DSL3A]

Re-post the code in its current state and give a little more detail to "still doesn't work..."

[Evote]

I have reposted the code :p
and when i go into solve from the menu and type in the file to load it'salright then when i press a key to continue it errors!!

         up   =  Maze[Position[0]][Position[1] - 1];
        down  = Maze[Position[0]][Position[1] + 1];
        left  = Maze[Position[0] - 1][Position[1]];
        right  = Maze[Position[0] + 1][Position[1]];

Those lines are flagged in debug
both strings though

[z05DSL3A]

Sorry, can you also post the contents of a sample 'maze' file, so I can run it.

[Evote]

just create a maze with
3
#S#
#_#
#F#

goto create maze then create new maze then do that :p
line by line
without the 3
the 3 is automatic
and is it amount of lines

[z05DSL3A]

The results from compiling the code at the top of the post

Compiling...
test.cpp
c:\data\projects\consoletest\test\test.cpp(82) : error C2057: expected constant expression
c:\data\projects\consoletest\test\test.cpp(82) : error C2466: cannot allocate an array of constant size 0
c:\data\projects\consoletest\test\test.cpp(82) : error C2133: 'Maze' : unknown size
c:\data\projects\consoletest\test\test.cpp(121) : warning C4018: '<' : signed/unsigned mismatch
c:\data\projects\consoletest\test\test.cpp(122) : warning C4244: '+=' : conversion from 'int' to 'char', possible loss of data
c:\data\projects\consoletest\test\test.cpp(193) : warning C4018: '<' : signed/unsigned mismatch
c:\data\projects\consoletest\test\test.cpp(194) : warning C4244: '+=' : conversion from 'int' to 'char', possible loss of data
c:\data\projects\consoletest\test\test.cpp(204) : warning C4018: '<' : signed/unsigned mismatch
c:\data\projects\consoletest\test\test.cpp(288) : warning C4018: '<' : signed/unsigned mismatch


NB: Line numbers are off by one to your code as I have to add #include <iso646.h> , so line 82 in the error message is line 81 in your code.

to be continued... (soon).

[Evote]

Thanks for this hope you like my program :D.
btw this is not in visual c++
it's in MingW
OOOH
and if you create a txt file through notepad INCLUDE THE AMOUNT OF LINES AT TOP
3
#S#
#_#
#F#
which in that case is 3

[z05DSL3A]

I have 'fixed' the size of the 'Maze' array at 10 for my testing (line 81).

I have created a maze file, when I go to 'Solve' it reads the file but says there are zero lines and then just sits in a loop (haven't had time to look at why yet, I'm 'rebuilding' a computer on the network). The file seems to be created ok.

[Evote]

Thats cool
Umm in the Maze file did you create it in the program?
if not do that

[z05DSL3A]

I did use the program to create the Maze file.

I have changed the code at line 192 from:

for (int i = 0; i < Line[1].length(); i++) {
        temp[i] += Line[1][i];
    }

to:

for (int i = 0; i < Line[1].length(); i++) {
        temp[i] = Line[1][i];
    }

This then gives me the correct number of lines.

I think I'm now at the point where you are;
Enter filename to edit:
maze.txt
3
#S#
#_#
#F#

There are: 3 lines!!
#S#
#_#
#F#
2 ,1
Press any key to continue . . .
previous
previous


Then it crashes with an Access violation reading location ...
It would suggest that your code is going out off the bounds of the Maze array. For example if the current Position is (0,0) then your code will try to access the Maze array at [0,-1] for the up direction.

You will need to put in some code to gaurd against going out of bounds.

HTH.

[Evote]

Thank You :p lol why did i put that + there lol ooh well thanks i will do that :P