This *should* sort my vector

[xander333]

This is for a little database program i'm writing.
It should sort the vector from highest price ( getPrijs() ) to lowest and show it.
But for some reason it just shows them backwards (on ID)
For example:

ID name price
1 football 50
2 game 75
3 cards 15

After I call the function, it shows:

ID name price
3 cards 15
2 game 75
1 football 50

this is the code:

 cout<<setw(10)<<left<<"ID"<<setw(15)<<"Product: "<<setw(15)<<"Price"<<"Amount in stock\n";
    int high;
    int size = data.size();

    for(int j = 0; j != size; j++)
    {

    for(int i = 0; i != data.size(); i++)
    {
        int maxi = -1;
        {
            if (data[i].getPrijs() > maxi)
            {
            high = i;
            maxi = data[i].getPrijs();
            }
        }
    }

    cout<<"\n"<<setw(10)<<data[high].getId()<<setw(15)<<data[high].getNaam()<<setw(15)<<data[high].getPrijs()<<data[high].getAantal();
    vector<item>::iterator pos = data.begin() + high;
    data.erase(pos);
    }

[Athar]

Please use std::sort:

http://www.cplusplus.com/reference/algorithm/sort/

[xander333]

Wouldn't work...I need to keep the vectors as they are...
Unless I'm understanding it wrong. What I understand:
It switches integers so that vector[0] would contain the highest?

[Athar]

Well, you can either operate on a copy of the vector or on a (temporary) vector of pointers to the original elements.
Besides, data.erase(pos); isn't exactly "keeping the vectors as they are", is it?

[xander333]

wait, I'll try the first you said...

[xander333]

Doesn't work, it can't sort objects, even with the example...
But why doesn't my way work?

[Athar]

Doesn't work, it can't sort objects, even with the example...

It can sort anything you want it to. You should post your modified code.

But why doesn't my way work?

You declared maxi at the wrong place.

[xander333]

Found out and hour ago, just came here to post it was fixed.
It indeed was maxi declarationat the wrong place :)

Fixd!


PS: for those who want to see:

modified code;

void ordenPrijs(vector<item> data)
{
    system("CLS");
    cout<<setw(10)<<left<<"ID"<<setw(15)<<"Product: "<<setw(15)<<"Price"<<"Amount in stock\n";
    int high;
    int size = data.size()-1;


    for(int j = 0; j != size; j++)
    {
        int maxi = -1;

    for(int i = 0; i != data.size(); i++)
    {

        {
            if (data[i].getPrijs() > maxi)
            {
            high = i;
            maxi = data[i].getPrijs();
            }
        }
    }

    cout<<"\n"<<setw(10)<<data[high].getId()<<setw(15)<<data[high].getNaam()<<setw(15)<<data[high].getPrijs()<<data[high].getAantal();
    vector<item>::iterator pos = data.begin() + high;
    data.erase(pos);
    }
    Sleep(7000);
}