Tic Tac Toe game problems

[kaduuk]

Hey guys!

I've been writing this tic tac toe game (grey wolf posted a thread, it's sort of included in the comments):

/*Level:
Beginner


Your ‘Assignment’ Stage 1:
Write a simple program that will allow two ‘human’ players to play Tic-tac-toe on the screen, there is no need to determine Win, lose, or draw yet.
Just make sure that the players can not put marks in places that already have marks and finish the ‘playing’ sequence when all spaces are taken.

Stage 2:
Modify your program from stage 1 to allow your program to determine Win, lose, or draw states.

Stage 3:
Modify your program from stage 2, to have the option of playing against a ‘computer’ opponent.

*/

/*1) Display the Grid
2) Display the 'pieces' on the grid
3) Determine if more pieces can be placed
4) Enter position for next piece.
For stages 2 point (3) can be extended to check for Win, Lose or Draw, and for stage 3 you can develop a (4a) wich is an computer placement.
Having done a first take on simplifying the problem, you then think about relationships between the stages - common data, functions, classes, etc.*/


#include <iostream>
#include <string>
using std::cout;
using std::cin;

void DispGrid();
int Move1();
int Move2();
bool CheckMove(int);
bool GameWin=false;
char one=1, two=2, three=3, four=4, five=5, six=6, seven=7, eight=8, nine=9;
void RedrawGrid(int,char);
//============================================================================================

int main(int argc, char *argv[])
{
    cout<<"Player one = X\nPlayer two = O\n";
    while(GameWin!=true){ //playing loop
    DispGrid();
    Move1();
    DispGrid();
    Move2();
    }
    
    cin.clear();
    cin.ignore();
    cout<<"Press enter to continue...";
    cin.get();
    return 0;
}
//===========================================================================================================

void DispGrid() //display the grid function
{
 cout<<"\n"<<one<<"|"<<two<<"|"<<three<<"\n";
    cout<<"-+-+-\n";
    cout<<four<<"|"<<five<<"|"<<six<<"\n";
    cout<<"-+-+-\n";
    cout<<seven<<"|"<<eight<<"|"<<nine<<"\n\n";  
}
//==================================================================================================
bool CheckMove(int move, bool check) //function to check if the move is valid
{
    check=true;
    switch(move)
    {
        case 1: //if the spot is occupied this returns false, otherwise it returns true
            if(one=='X'||one=='O')
            {cout<<"That's an invalid move, please try again!\n";
            check=false;}
            break;
        case 2:
            if(two=='X'||two=='O')
            {cout<<"That's an invalid move, please try again!\n";
            check=false;}
            break;
        case 3:
            if(three=='X'||three=='O')
            {cout<<"That's an invalid move, please try again!\n";
            check=false;}
            break;
        case 4:
            if(four=='X'||four=='O')
            {cout<<"That's an invalid move, please try again!\n";
            check=false;}
            break;
        case 5:
            if(five=='X'||five=='O')
            {cout<<"That's an invalid move, please try again!\n";
            check=false;}
            break;
        case 6:
            if(six=='X'||six=='O')
            {cout<<"That's an invalid move, please try again!\n";
            check=false;}
            break;
        case 7:
            if(seven=='X'||seven=='O')
            {cout<<"That's an invalid move, please try again!\n";
            check=false;}
            break;
        case 8:
            if(eight=='X'||eight=='O')
            {cout<<"That's an invalid move, please try again!\n";
            check=false;}
            break;
        case 9:
            if(nine=='X'||nine=='O')
            {cout<<"That's an invalid move, please try again!\n";
            check=false;}
            break;
    }
}
//==================================================================================================
int Move1() //player number 1's move
{
    int place;
    bool check=true;
 start:
 cout<<"Where would you like to place your X? ";
 cin>>place;
 CheckMove(place,check);
 if(check=false)
 goto start;
 char sg='X';
 RedrawGrid(place,sg);
 
}
//==================================================================================================
int Move2() //player number 2's move
{
    int place;
    bool check=true;
    start:
    cout<<"Where would you like to place your O? ";
    cin>>place;
    CheckMove(place,check); //check if the move is valid
    if(check=false)
    goto start; //get the move again if it's not valid
    char sg='O';
 RedrawGrid(place,sg);
}
void RedrawGrid(int place, char sg) //function to change the grid accordingly to the users input
{
    if(place=1)
    one=sg;
    else if(place=2)
    two=sg;
    else if(place=3)
    three=sg;
    else if(place=4)
    four=sg;
    else if(place=5)
    five=sg;
    else if(place=6)
    six=sg;
    else if(place=7)
    seven=sg;
    else if(place=8)
    eight=sg;
    else if(place=9)
    nine=sg;
}

Now, I've got three problems:

- firstly I can't figure out what data type i should use for the numbers in the grid (one, two, three etc), since I'd like it to start of as an int, but later on be a char. I tried making it a string, but that didn't work.

- secondly somehow I can only alter the grid once (if it asks for the O it doesn't change the grid)

- lastly the fallback for any mistakes made by the user (so if the move is invalid) doesn't work, which i can't figure out why.

So could somebody please explain to me what data type i should use, how i can alter the grid more then once and how to make the fallback work?

Any suggestions (and corrections) are appreciated.

Thanks in advance!

Cheers :)

[hamsterman]

CheckMove, Move1 and Move2 don't return anything. I believe they should all return check.
Your problem is that in RedrawGrid you're confusing = with ==. = is assignment, == is comparison.
For grid, use chars : '1', '2', '3' ...
You're making life hard for yourself. Instead of char one, two, three and so on, use char grid[9]; That way, for example, your Redraw function could look like this: grid[place-1] = sg;

[kaduuk]

Thanks!

Ok so now i did it and i'm able to alter the grid :D

However, somehow check still always ends up true, so if grid place 1 is entered by both players, it'll alter it both times :S
So then I tried removing the assignment to check, but then it always returns false :S

Sorry for my noobness, but i just cant seem to correct it..

[Lynx876]

I don't know if it'll help, cause the code is a bit messy and I can't be bothered to fix it, as the game works fine with a few little problems with formatting etc.

The code for the tic-tac-toe game I made:

http://sites.google.com/site/davevisone/home/cplusplus/tic---tac---toe