Program doesn't work as supposed

[bobmarley]

okay here is code:

#include <iostream>
using namespace std;

int main() {
    int a,b,rez;
    char choice[1];
    cout<<"First: ";
    cin >> a;
    cout<<"\nChoice: ";
    cin >> choice;
    cout <<"\nSecond: ";
    cin >> b;
    if (choice == "+"){
               rez = a + b;
               cout<<"Result: "<<rez;
               }
    else if (choice == "*"){
               rez = a * b;
               cout<<"Result: "<<rez;
               }           
    system("PAUSE");
    return 0;
           }

my program doesn't output result at all?
what do I do wrong herE?
thank you

[kfmfe04]

your problems are on lines 13 and 17.

"+" and "*" are string literals that are allocated on the heap so there are addresses associated with them. choice is an automatic variable located on the stack. When you use ==, you are comparing the two addresses - they will never equal.

What you want is:

#include <string.h>
// ...
if ( !strcmp( choice, "+" )) {
// ...
} else if ( !strcmp( choice, "*" )) {
// ...
}

Or, you can declare choice as a character and compare against characters:

char choice;
// ...
if ( choice=='+' ) {
// ...
} else if ( choice=='*' ) {
// ...
}

If you still want to use strings, but avoid C-like code and strcmp(), you should google std::string and use it in place of char choice[1]

There are many ways to skin this cat.

[hamsterman]

choice == "+"This is not how you compare cstrings.
a few options:
choice is one char, so why not use one char?

char choice;
if(choice == '+')...

If you ever want to do this with longer cstrings

char choice[50];
if( strcmp(choice, "+") == 0 )...

Though it would be better to use std::string

#include <string>
...
std::string choice;
if(choice == "+")...

edit: too slow..