assertion failed

[karlherbert]

Hi people, I've that code.. when I do debbuging the code's Ok but message error starts up and shows me additional error:debbug assertion failed...when I remove the destructors the error disappear but the output does't show right results...
This programme is for counting dots of some string...
here's code:


#include<iostream>
#include<cstring>
#include<string>
using std::cout;
class mojetrida
{
private:
char *podretezec;
char *ps;
int citac,i,p;
int kraska;
public:
mojetrida();//,int citac,int p);
~mojetrida();
void udelej();
};
mojetrida::mojetrida()//,int citac,int p)
{
podretezec="deb.i.ll.ek";
kraska=strlen(podretezec);
podretezec=new char[];
ps=new char[kraska];
citac, p=0;
};
mojetrida::~mojetrida()
{
delete []podretezec;
delete []ps;
};
void mojetrida::udelej()
{
using std::cerr;
//int citac=0;
//int p=0;
ps=podretezec;
int krasa=strlen(ps);
for(i=0;i<krasa;i++)
{

if (ps[i]=='.')
{
++citac;
}
else if (ps[i]!='.')
{
break;
};

};

cerr<<"vystup je"<<ps<<citac;
};
int main()
{
using namespace std;
cout<<"zadejte retezec";
mojetrida obj=mojetrida();
obj.udelej();
return 0;
}

[Galik]

Please put your code in [code] tags: http://www.cplusplus.com/forum/articles/16853/

[karlherbert]

#include<iostream>
#include<cstring>
#include<string>
using std::cout;
class mojetrida
{
private
       char *podretezec;
       char *ps;
       int citac,i,p;
       int kraska;
public:
	mojetrida();
       ~mojetrida();[BR]
	void udelej();
};

mojetrida::mojetrida()
{
	podretezec="deb.i.ll.ek";
	kraska=strlen(podretezec);
	podretezec=new char[];
	ps=new char[kraska];
	citac, p=0;
};
mojetrida::~mojetrida()
{
  delete []podretezec;
  delete []ps;
};
	 void mojetrida::udelej()
	            { 
				  using std::cerr;
				  ps=podretezec;
                  int krasa=strlen(ps);
	                 for(i=0;i<krasa;i++)
	                    {
			
	                      if (ps[i]=='.')
		                     { 
				            ++citac;
		                      }
		                  else if (ps[i]!='.')
		                  {
				            break;
		                  };

	                   };
	 
					cerr<<"vystup je"<<ps<<citac;
	             };
int main()
{
	using namespace std;
	cout<<"zadejte retezec";
	mojetrida obj=mojetrida();
	obj.udelej();
	return 0;
}

[Null]

podretezec=new char[]; this shouldn't even compile.

I suggest you to use C++ strings instead of C-style character arrays.
Also,

 else if (ps[i]!='.')
  {
      break;
  };

You don't need this code; if character is not a dot, loop will quit without counting all dots in the string

Here's the fixed code:

#include <iostream>
using namespace std;
class mojetrida
{
private:
string podretezec; // <---
string ps;
int citac,i,p;
int kraska;
public:
mojetrida();//,int citac,int p);
~mojetrida();
void udelej();
};
mojetrida::mojetrida()//,int citac,int p)
{
podretezec="deb.i.ll.ek";
kraska=podretezec.length(); // .length() gets the length of the string

citac=0, p=0;
};
mojetrida::~mojetrida()
{

};
void mojetrida::udelej()
{
using std::cerr;
//int citac=0;
//int p=0;
ps=podretezec;
int krasa=ps.length();
for(i=0;i<krasa;i++)
{

if (ps[i]=='.')
{
++citac;
}


};

cerr<<"vystup je "<<ps<<citac;
};
int main()
{

cout<<"zadejte retezec ";
mojetrida obj=mojetrida();
obj.udelej();
return 0;
}

Hope this helps.

[Galik]

You should only call delete[] if you allocated your pointer using new;

mojetrida::mojetrida()
{
	podretezec="deb.i.ll.ek"; // You should not delete[] this, you didn't allocate it using new
	kraska=strlen(podretezec);
	podretezec=new char[]; // what is this for?
	ps=new char[kraska];
	citac, p=0;
};