Please help me

[abuh]

Write your question here.
Extend the class Linkedlist by overloading the insertion operator (<<) to display the elements of a linked list. For example:

Suppose L is an object of type Linkedlist . The statement:

cout << L << endl;

should display the elements of the linked list L without any errors .

  Put the code you need help with here.
template <class type>
class node
{
public:
type info;
node *link;
};

template <class type>
class Linkedlist
{
private:
node<type> *head, *tail;
int counter;
public:
Linkedlist()
{
head = tail = NULL;
counter = 0;
}

bool isEmpty()
{
return (head==NULL);
}

type getLast()
{
if (isEmpty()) {
cout << "Linked list is empty !!!" << endl; assert(!isEmpty());
}
return tail->info;// (*tail).info
}

void Append(type e)
{
node<type> *newnode = new node<type>;
newnode->info = e;
newnode->link = NULL;// (*newnode).link=NULL

if (isEmpty())
{
head = tail = newnode;
}
else
{
tail->link = newnode;
tail = newnode;
}
++counter;
}

void print()
{
if (isEmpty()) { cout << "Linked list is empty !!!" << endl; return; }
node<type> *current = head;

while (current != NULL)
{
cout << current->info << ",";
current = current->link;
}
cout << endl;
}

 

 

};

[againtry]

#include <iostream>

using namespace std;

template <class type>
class node
{
public:
    type info;
    node *link;
};

template <class type>
class Linkedlist
{
private:
    node<type> *head, *tail;
    int counter;
public:
    Linkedlist()
    {
        head = tail = nullptr;
        counter = 0;
    }

    bool isEmpty()
    {
        return (head==nullptr);
    }

    type getLast()
    {
        if (isEmpty()) {
            cout << "Linked list is empty !!!" << endl; assert(!isEmpty());
        }
        return tail->info;// (*tail).info
    }

    void Append(type e)
    {
        node<type> *newnode = new node<type>;
        newnode->info = e;
        newnode->link = NULL;// (*newnode).link=NULL

        if (isEmpty())
        {
            head = tail = newnode;
        }
        else
        {
            tail->link = newnode;
            tail = newnode;
        }
        ++counter;
    }

    void print()
    {
        if (isEmpty()) { cout << "Linked list is empty !!!" << endl; return; }
        node<type> *current = head;

        while (current != NULL)
        {
            cout << current->info << ",";
            current = current->link;
        }
        cout << endl;
    }

    friend ostream& operator<<(ostream& os, const Linkedlist< type> dt)
    {
        node<type> *current = dt.head;
        while (current != nullptr)
        {
            os << current->info << ",";
            current = current->link;
        }
        os << endl;
        return os;
    }
};

int main()
{
    Linkedlist<int> L;

    L.Append(10);
    L.Append(20);
    L.Append(30);
    L.Append(40);

    L.print();
    cout << L << '\n';
}

10,20,30,40,
10,20,30,40,

Program ended with exit code: 0

[seeplus]

Apart from the provision of operator>>, there are several issues with the provided code - notably, no destructor and no copy constructor etc.

Consider:

#include <iostream>
#include <initializer_list>

template <class type>
class Linkedlist {
private:
	template <class type>
	class node {
	public:
		type info {};
		node* link {};

		node(const type& i) : info(i) {}
	};

	node<type> *head {}, *tail {};
	int counter {};

public:
	Linkedlist() {}

	Linkedlist(std::initializer_list<type> il) {
		for (const auto& i : il)
			Append(i);
	}

	~Linkedlist() {
		while (head != nullptr) {
			const auto nd {head->link};

			delete head;
			head = nd;
		}
	}

	// TO BE PROVIDED IF NEEDED
	Linkedlist(const Linkedlist&) = delete;
	Linkedlist& operator=(const Linkedlist&) = delete;

	bool isEmpty() const { return (head == nullptr); }

	type getLast() const {
		if (isEmpty()) {
			std::cout << "Linked list is empty !!!\n";
			//assert(!isEmpty());
		}

		return tail->info;
	}

	void Append(const type& e) {
		auto newnode {new node<type>(e)};

		if (isEmpty())
			head = tail = newnode;
		else {
			tail->link = newnode;
			tail = newnode;
		}

		++counter;
	}

	void print() const {
		if (isEmpty())
			std::cout << "Linked list is empty !!!\n";
		else
			std::cout << *this;
	}

	friend std::ostream& operator<<(std::ostream& os, const Linkedlist< type>& dt) {
		for (auto current = dt.head; current != nullptr; current = current->link)
			os << current->info << (current->link != nullptr ? ',' : '\n');

		return os;
	}
};

int main()
{
	const Linkedlist<int> L {10, 20, 30, 40};

	std::cout << L;
}

10,20,30,40

[againtry]

... and then there is that hanging comma at the end which so far 3 of us have decided to ignore.

[seeplus]

Now fixed in my code above!

[againtry]

good

[dhayden]

You can move the test for a comma outside the loop if you print the comma before the node instead of after:

    friend ostream &operator<<(ostream &os, Linkedlist<type> &rhs)
    {
	if (rhs.head) {
	    os << rhs.head->info;

	    for (node<type> *current = rhs.head->link; current; current = current->link) {
		os << ',' << current->info;
	    }
	}
	return os;
    }