Average word length

[bstroe]

How to find the average word lengths without taking into account the spaces?

 
int is_letter(char c) {
    if (('a' <= c && c <= 'z') || ('A' <= c && c <= 'Z')) {
        return 1;
    }
    return 0;
}


int nr_words(char s[101]) {
    int n = strlen(s);
    int i_have_words = 0;
    int nr_words = 0;
    for (int i = 0; i < n; i++) {
        if (is_letter(s[i])) {
            i_have_words = 1;
        } else if (i_have_words == 1) {
        nr_words++;
        i_have_words = 0;
        }
    }

    if (i_have_words == 1) {
        ++nr_words;
    }
    return nr_words;
}


int main() {
 // ifstream fin("date.in");
  char s[101];
    cin.getline(s, 101);
    char len = strlen(s);
   double average_length_words = len  / nr_words(s);

   cout << fixed << setprecision(2) << average_length_words;

}

Input:
Asd asd assd
Output: 3.33 (I get 4.00)

The string will contain uppercase and lowercase letters as well as punctuation

[coder777]

Line 14: You cannot use strlen(...). You need a loop to count all letters. With strlen(...) you count everything including whitespaces.

Line 35: This is a integer division. At least one of the numbers needs to be double (may be cast one).

[seeplus]

It's easiest using string rather than c-style null terminated strings. Consider:

#include <string>
#include <sstream>
#include <iostream>
#include <iomanip>

int main() {
	// ifstream fin("date.in");
	std::string txt;

	std::cout << "Enter text: ";
	std::getline(std::cin, txt);

	std::istringstream iss(txt);

	size_t wrds {}, chars {};

	for (std::string s; iss >> s; ++wrds, chars += s.size());

	std::cout << std::fixed << std::setprecision(2) << "Average word length is " << (chars + 0.0) / wrds << '\n';
}

Enter text: Asd asd assd
Average word length is 3.33

[Handy Andy]

Hello bstroe,

The first 2 things you need to do is post the instructions that you were given, so that everyone will know what you have to do along with what you can use and can not use.

Next it is best to post a whole program that can be compiled and tested. A large program can be cut down to enough to demonstrate your problem.

If using a "std::string" is not an option then consider the function"strtok()" https://en.cppreference.com/w/c/string/byte/strtok to break up the whole string into individual tokens, or words in this case.

If you can use the header file "<cctype>", or "<ctype.h>" you will have the function "isalpha()" https://en.cppreference.com/w/c/string/byte/isalpha There are others for numbers and punctuation. This could eliminate the "is_letter" function or enhance it.

With out further input I do not know if numbers and punctuation are not to be counted in a word.

Last I have to say the some blank lines and proper indentation would make youe code easier to read. As an example:

int is_letter(char c)
{
    if (('a' <= c && c <= 'z') || ('A' <= c && c <= 'Z'))
    {
        return 1;
    }

    return 0;
}

int nr_words(char s[101])
{
    int n = strlen(s);
    int i_have_words = 0;
    int nr_words = 0;

    for (int i = 0; i < n; i++)
    {
        if (is_letter(s[i]))
        {
            i_have_words = 1;
        }
        else if (i_have_words == 1)
        {
            nr_words++;
            i_have_words = 0;
        }
    }

    if (i_have_words == 1)
    {
        ++nr_words;
    }
    return nr_words;
}


int main()
{
    // ifstream fin("date.in");
    // <--- if used HOW do you know if the stream is open. Or is it that you have not written that code yet?

    char s[101];

    cin.getline(s, 101);
    
    char len = strlen(s);  // <--- Defined as a "char", but "strlen()" returns a "size_t". This may work, but could be a better type.
    
    double average_length_words = len / nr_words(s);

    cout << fixed << setprecision(2) << average_length_words;

}

Just a suggestion, but one you should pay attention to.

Andy

[bstroe]

1

[lastchance]

#include <iostream>
#include <iomanip>
#include <cctype>
using namespace std;

void wordCount( char *p, int &words, int &letters, bool inWord )
{
   if ( !(*p) ) return;
   if ( isalpha( *p ) )
   {
      letters++;
      if ( !inWord ) words++;
      inWord = true;
   }
   if ( isspace( *p ) ) inWord = false;
   wordCount( p + 1, words, letters, inWord );
}


int main()
{
   // ifstream fin("date.in");
   const int SIZE = 1001;
   char s[SIZE];
   cin.getline( s, SIZE );
   int words = 0, letters = 0;
   wordCount( s, words, letters, false );
   if ( words > 0 ) cout << fixed << setprecision( 2 ) << ( letters + 0.0 ) / words << '\n';
}

asd "ABC" @ab234-ef"
3.33