Need help!

[DragNinja1]

I need to have attack skill be used for the Sword and Nunchuck attack function that is overriding the weapon virtual function. I can't figure it out. The equations for the attack damage is the ones shown for each classes' attack function.

#include <iostream>
#include <string>

using namespace std;

class Weapon {
private:
    string name;
    int attackDamage;
    int attackDecay;
public:
    Weapon() {
        this->name = "";
        this->attackDamage = 0;
        this->attackDecay = 0;
    }
    Weapon(string name, int attackDamage, int attackDecay) {
        this->name = name;
        this->attackDamage = attackDamage;
        this->attackDecay = attackDecay;
    }

    virtual int attack(int attackSkill) {
        int damage;
        damage = attackDamage;
        attackDamage = (attackDamage + attackSkill) - attackDecay;
        return damage;
    }
   
    int getAttackDamage() {
        return this->attackDamage;
    }
    int getAttackDecay() {
        return this->attackDecay;
    }
    string getName() {
        return this->name;
    }

    void setAttackDamage(int newAttackDamage) {
        this->attackDamage = newAttackDamage;
    }
    void setAttackDecay(int newAttackDecay) {
        this->attackDecay = newAttackDecay;
    }
    void setName(string newName) {
        this->name = newName;
    }
};

class Sword : public Weapon {
private:
    int attackDamage;
    int attackDecay;
public:
    Sword() {
        this->attackDamage = 0;
        this->attackDecay = 0;
    }
    Sword(int attackDamage, int attackDecay) {
        Weapon("Sword", attackDamage, attackDecay);
    }


    int getAttackDamage() {
        return this->attackDamage;
    }
    void setAttackDamage(int newAttackDamage) {
        this->attackDamage = newAttackDamage;
    }
    int getAttackDecay() {
        return this->attackDecay;
    }
    void setAttackDecay(int newAttackDecay) {
        this->attackDecay = newAttackDecay;
    }
    int attack() {
        int damage;
        damage = attackDamage;
        attackDamage = (attackDamage + attackSkill) - attackDecay;
        return damage;
    }
};

class Nunchucks : public Weapon {
private:
    int attackDamage;
public:
    Nunchucks() {
        Weapon("Nunchucks", 0, 0);
    }
    Nunchucks(int attackDamage) {
        Weapon("Nunchucks", attackDamage, 0);
    }

    int getAttackDamage() {
        return this->attackDamage;
    }
    void setAttackDamage(int newAttackDamage) {
        this->attackDamage = newAttackDamage;
    }
    int attack() {
        int damage;
        damage = attackDamage;
        attackDamage = (attackSkill * attackDamage) / 10;
        return damage;
    }
};

class Ninja {
private:
    string name;
    int health;
    int attackSkill;
protected:
    Weapon* weapon = new Sword;
public:
    Ninja() {
        this->name = "";
        this->health = 0;
        this->attackSkill = 0;
        this->weapon = nullptr;
    }
    Ninja(string name, int health, int attackSkill) {
        this->name = name;
        this->health = health;
        this->attackSkill = attackSkill;
        this->weapon = nullptr;
    }
    Ninja(Ninja& player) {
        cout << "Copy Constructor called" << endl;
        this->name = player.getName();
        this->health = player.getHealth();
        this->attackSkill = player.getAttackSkill();
        //Need to create a New Sword
        Weapon* weaponCopy;
        weaponCopy = new Weapon("", 0, 0);
        weaponCopy->setAttackDamage(player.getSword()->getAttackDamage());
        weaponCopy->setAttackDecay(player.getSword()->getAttackDecay());
        this->weapon = weaponCopy;
    }
    Ninja& operator=(Ninja& player) {
        cout << "Overload Operator Called" << endl;
        this->name = player.getName();
        this->health = player.getHealth();
        this->attackSkill = player.getAttackSkill();
        Sword* swordOverload;
        swordOverload = new Sword(0, 0);
        swordOverload->setAttackDamage(player.getSword()->getAttackDamage());
        swordOverload->setAttackDecay(player.getSword()->getAttackDecay());
        this->weapon = swordOverload;
    }

    void setName(string newName) {
        this->name = newName;
    }
    string getName() {
        return this->name;
    }
    void setHealth(int newHealth) {
        this->health = newHealth;
    }
    int getHealth() {
        return this->health;
    }
    void setAttackSkill(int newAttackSkill) {
        this->attackSkill = newAttackSkill;
    }
    int getAttackSkill() {
        return this->attackSkill;
    }
    Weapon* getSword() {
        return this->weapon;
    }
    void pickupWeapon(Weapon* weapon) {
        this->weapon = weapon;
    }
    int attack() {
        int damage;
      
        damage = weapon->attack(attackSkill) + attackSkill;
       
        return damage;
    }
    
};

[coder777]

When compiling it has the following errors/warning:

 In member function 'int Sword::attack()':
80:40: error: 'attackSkill' was not declared in this scope
 In member function 'int Nunchucks::attack()':
105:25: error: 'attackSkill' was not declared in this scope
 In member function 'Ninja& Ninja::operator=(Ninja&)':
152:5: warning: no return statement in function returning non-void [-Wreturn-type]

You don't have a member variable attackSkill.

In class Sword you have:

int attackDamage;
    int attackDecay;

and in class Nunchucks
int attackDamage;
They are hiding the variables of class Weapon. They shouldn't there.

This

    Nunchucks() {
        Weapon("Nunchucks", 0, 0); // Creates and dismisses a temporary variable
    }

should be this:

    Nunchucks() : Weapon("Nunchucks", 0, 0) { // Calls the base constructor
    }