Whats wrong with this code?

[galadys]

#include <iostream>

int iHelloTimes;

int main()
{
	std::cin >> iHelloTimes;
    say_hello(iHelloTimes);
}

int say_hello(iHelloTimes)
{
    for( int iCounter = 0; iCounter <= iHelloTimes; iCounter++){
		std::cout << "Hello" << std::endl;
    }
}

What am I doing wrong, for some reason Visual Studio 2008 and Code::Blocks are both not working for this program, Visual Studio says its fine but when I run it
the console window appears then disappears, Code::Blocks tells me to put semi-colons where I know they shouldn't be( before the { in my functions.)

[filipe]

First, identifiers must be declared before they're mentioned. So either move the definition of say_hello() to before main() or forward declare it.

Second, if you're using a global variable to pass data between functions, you don't require parameters. You must use an empty parameter list. However, globals aren't very friendly as your programs get bigger and you can't tell which functions change their state. You should use an int as parameter and get rid of the global variable, like this:

int say_hello(int times)
{
    // function body
}

Third, this is just a convention really, but typically you'd use i as the identifier for a loop counting variable. It's short, it's very common, and pretty soon it's second nature.

Finally, this is just an opinion, but I really recommend you stay away from "Hungarian notation". Whenever you use a variable, you should know what type it is, otherwise why are you using it if you don't know what it's for? The original point of "Hungarian", as described in Charles Simonyi's famous paper, was to indicate something the type system couldn't deal with, such as the difference between rows and columns (both integers) and so on.