Problem with 'Banking System' code

[Jason2132]

Hi Guys

I'm working on a project for school were I need to create a simple banking system.(Acct creation, withdraws, deposits, simple processes like that) My code is pretty much finished but I'm having trouble with the acct. creation. After the user enters the name and int deposit the programs proceeds to close out. This of course happens too when any other process is chosen because all other options are based on the acct creation. I'm new to programing and im sure the mistake is right in front of my face but any thoughts on the matter would help. Thanks.

Heres my code:

Bank.cpp

#include <iostream>
#include <string>
#include <iomanip>
#include <fstream>
#include <time.h>
#include "Bank Class.h"
#include <sstream>

Banking::Banking()
{
acctNumber[13] = 0;
acctBalance = 0;
}


char Banking::menu()
{
char choice;
cout << "\t\t -=[ Main Menu ]=- \n\n"
<< "\tA) Create New Account\n"
<< "\tB) View Account Balance\n"
<< "\tC) Transfer Funds From Checking To Savings\n"
<< "\tD) Transfer Funds From Savings To Checking\n"
<< "\tE) Exit\n"
<< "\n\n\tSelection: ";
cin >> choice;
cin.ignore();
choice = toupper(choice);

while(!isalpha(choice))
{
invalid("[!!] Invalid selection.\n[!!] Choose a valid option: ");
cin >> choice;
cin.ignore();
}

switch(choice)
{
case 'A':
createNewAccount();
break;
case 'B':
getAcctInfo();
break;
case 'C':
cout << "Choice C" << endl;
break;
case 'D':
cout << "choice D" << endl;
break;
case 'E':
cout << "Exiting" << endl;
exit(1);
break;
default:
system("cls");
invalid("\n\n\n\n\t\t [!!] Invalid Selection \n\t\t Good-bye \n\n\n\n\n\n\n");
exit(1);
break;
}


return choice;
}



void Banking::invalid(char *msg)
{
cout << msg;
}



void Banking::fatal(char *msg)
{
cout << msg;
exit(1);
}



void Banking::createNewAccount()
{
srand(time(NULL)); // Seed random generator with time initialized to NULL
char acctChoice; // choice for the account type
float initCheckDeposit = 0; // The initial deposit for checking account
float initSaveDeposit = 0; // The initial deposit for saving account


ofstream checkFile("checking.dat", ios::out | ios::binary | ios::app); // For saving checking accounts
ofstream saveFile("saving.dat", ios::out | ios::binary | ios::app); // For saving savings accounts
system("cls");
cout << "\t\t-=[ New Account Creation ]=-\n\n" << endl;
cout << "A) Checking Account\n"
<< "B) Savings Account\n"
<< "C) Checking and Saving Account\n" << endl;
cout << "New account type: ";
cin >> acctChoice;
acctChoice = toupper(acctChoice);
cin.clear();
cin.sync();

switch(acctChoice)
{
case 'A':
system("cls");
cout << "\t\t -=[ New Checking Account ]=- \n" << endl;
cout << "Name of the main holder to be on the account: ";
getline(cin, acctName);
cout << "Initial deposit amount: $";
cin >> initCheckDeposit;

if(!checkFile)
fatal("[!!] Fatal Error 251: Miscommunication with server\n");

for(int i = 0; i < 12; i++)
{
acctNumber[i] = (rand() % 10); // Build a random checking account number
}

checkFile << acctName << endl;
checkFile << acctNumber << endl;
checkFile << initCheckDeposit << endl;

break;

case 'B':
system("cls");
cout << "\t\t -=[ New Savings Account ]=- \n" << endl;

cout << "Name of the main holder to be on account: ";
getline(cin, acctName);
cout << "Deposit Amount: $";
cin >> initSaveDeposit;

if(!saveFile)
fatal("[!!] Fatal Error 251: Miscommunication with server\n");

for(int i = 0; i < 12; i++)
{
acctNumber[i] = (rand() % 10);
}

saveFile << acctName << endl;
saveFile << acctNumber << endl;
saveFile << initSaveDeposit << endl;

break;

case 'C':
system("cls");
cout << "\t -=[ New Checking / Saving Account ]=- \n" << endl;

cout << "Name of the main holder to be on account: ";
getline(cin, acctName);
cout << "Checking Deposit Amount: $";
cin >> initCheckDeposit;
cout << "Saving Deposit Amount: $";
cin >> initSaveDeposit;

if(!saveFile || !checkFile)
fatal("[!!] Fatal Error 251: Miscommunication with server\n");

for(int i = 0; i < 12; i++)
{
acctNumber[i] = (rand() % 10);
}

saveFile << acctName << endl;
saveFile << acctNumber << endl;
saveFile << initSaveDeposit << endl;

checkFile << acctName << endl;
checkFile << acctNumber << endl;
checkFile << initCheckDeposit << endl;
break;

default:
system("cls");
fatal("[!!] Invalid option\n");
break;

}
}



void Banking::getAcctInfo()
{
int i = 0;
double balance = 0;
char choice;
string name;
fstream checkFile("checking.dat", ios::in | ios::binary | ios::beg);
fstream saveFile("saving.dat", ios::in | ios::binary | ios::beg);
system("cls");
cout << "\t\t -=[ View Account Balance ]=-\n\n";

cout << "A) View Checking Account\n"
<< "B) View Saving Account\n"
<< "C) View Checking \\ Saving Account\n" << endl;
cout << "Choice: " << endl;
cin >> choice;
choice = toupper(choice);

if(!isalpha(choice))
fatal(" [!!] Invalid Choice");

switch(choice)
{
case 'A':
cin.clear();
system("cls");
cout << "\t\t -=[ View Checking Account ]=-\n\n" << endl;
cout << "Account Name: ";
cin.sync();
getline(cin, name);
getline(checkFile, acctName);
while(name != acctName && !checkFile.eof())
{
i++;
getline(checkFile, acctName);
}

if(name == acctName)
{
system("cls");
cout << "\t\t -=[ Account Overview ]=-\n\n" << endl;
cout << "Account Name: " << acctName << "\n";
cout << "Account Number: ";
for(int j = 0; j < 13; j++)
{
char input_number;
stringstream converter;
checkFile.get(input_number);
converter ;input_number;
converter ;acctNumber[j];
cout << acctNumber[j];
}

cout << endl;
checkFile >> acctBalance;
cout << "Balance: $" << acctBalance << endl;
}
else
{
fatal("[!!] Invalid Entry\n");
}
break;
}



}

-------------------
Bank Class.h

#ifndef MAINBANKCLASS_H
#define MAINBANKCLASS_H
#include <iostream>

using namespace std;


class Banking
{
private:
string acctName; // Name on the account
int acctNumber[13]; // Account number
float acctBalance; // Amount in the account
public:
void getAcctInfo(); // Get name on account for displaying relevant information
void createNewAccount(); // Create a new account and assign it a random account number
// void transferFunds(); // Transfer funds checking <--> savings, passing amount as the argument, saving for later day
void invalid(char *); // If an invalid option is chosen
char menu(); // Print the main menu for the user.
void fatal(char *);
Banking();
};
#endif

-----------------
Main.cpp

#include "Bank Class.h"
using std::cout;



int main()
{
Banking bank;

bank.menu(); // Call the banking menu

return 0;
}

[Skillless]

>#include "Bank Class.h"

should be .cpp

or just put the Bank Class.cpp functions inside Bank Class.h

[Duncan]

Skillless is mistaken you're right to #include "Bank Class.h" instead of "Bank Class.cpp". The linker links it all up and it works. Also, that would be a compile error not a run-time error so you would have known about that before even running the program.

As far as your problem, I think you actually aren't having a problem. You call the menu(), which then calls createAccount(), and then you create your account.. createAccount() exits, and then menu() exits and then main() exits and the program ends. There's no action in Banking::menu() after it calls createAccount().

I'm not using a compiler to check any of this but just looking through your code it looks like it'll execute just as you said: the user enters the account information and the program exits. So I'm guessing there isn't actually a problem with your code.

If you want something to happen after the account creation, then you'll want to put whatever you want probably after the switch block in Banking::menu() or maybe before the break; in the switch block after the call to createAccount().

I hope I've made sense and not led you astray.

In other news, when posting code segments please outline it with [code] tags :).