Alphabetizing a string array

[Pelephant]

I've been trying to create a program that alphabetizes a given array of strings. The program builds just fine, but when I try to debug it, it crashes on me and displays the message "Unhandled exception at 0x5fc0c0e7 (msvcr100d.dll) in Alphabetize.exe: 0xC0000005: Access violation reading location 0xcccccccc."

I've looked over the program, but I can't see whats wrong with it. I've never programmed with strings before, so it might be something very fundamental that I'm not getting correct. Help would be much appreciated!

#include <iostream>
#include <string>
using namespace std;

//Function Prototypes
void sortArray(string[], int);

int main()
{
	const int NUMBER = 6;
	string names[NUMBER] = {"Bob", "Tina", "Peter", "Kara", "Emily", "Harry"};


	cout << "This program will sort an array of 6 strings.";
	sortArray(names, NUMBER);


	//Display
	for (int count = 0; count < NUMBER; count++)
		cout << names[count] << endl;


	system("PAUSE");
	return 0;

}


void sortArray(string names[], int size)
{
	
	bool flag;

	do
	{
		flag = 0;
		for( int count = 0; count < size; count++)
		{
			if (names[count] > names[count+1])
			{
				names[count].swap(names[count+1]);
				flag = 1;
			}
			
		}
	} while (flag = 1);

}
	

[firedraco]

for( int count = 0; count < size; count++)
{
	if (names[count] > names[count+1])
	{
		names[count].swap(names[count+1]);
		flag = 1;
	}
}

What happens when count is size-1?

[Pelephant]

Thank you firedraco! I got rid of the "unhandled exception error" by changing it to the following. However, the next problem I ran into is that the program seems to continue looping on forever, without stopping or going on to the next part. I'm not sure what the problem is.

Sorry for all the questions, but I'm fairly new at this and my logic isn't all that great. Thanks in advance.

void sortArray(string names[], int size)
{
	
	bool flag;

	do
	{
		flag = 0;
		for( int count = 0; count < (size-1); count++)
		{
			if (names[count] > names[count+1])
			{
				names[count].swap(names[count+1]);
				flag = 1;
				
			}
			
		}
		
	} while (flag = 1);
}

[Zhuge]

Your while loop should use == for comparison, not = as that does assignment, ensuring flag is always true and the loop continues forever.

[Pelephant]

Thanks! That solved my problem.